Message ID | 20240126-x1e80100-dts-missing-nodes-v5-0-3bb716fb2af9@linaro.org |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp568241dyb; Fri, 26 Jan 2024 02:32:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFI+kAuubykiZVnkBY31Sg/AGkKbp7VU0D2hSeQIw2CpvZ1khVbEkFZjHTzz1yVyGRH0msH X-Received: by 2002:a05:6402:2883:b0:559:6c9e:96fe with SMTP id eg3-20020a056402288300b005596c9e96femr618119edb.37.1706265126126; Fri, 26 Jan 2024 02:32:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706265126; cv=pass; d=google.com; s=arc-20160816; b=m/nU+7NgnAt+7T67gZE7CrKo/FCHmDQ8zhr2NotespGN1G0b4/pbtbfZDM6naeXLBk z4g6TENgKQeIc3WPOYjL8ZEfK4DvBtfkN1y6ZhgYwUgZhkzVza6DBsm4HJ9FaoITfZnm 8SEoWk3xCL9hVRhNjMOgfryX4V0hQkaDmLVDQ+EsGsVJMAeWN9cS6RvdsCbiY+gKHupE YhFJ5G5MX/taybSiV+IbashtbigMroAZEM/xhubflNPobNHZNuzOWT4iqFlJ/6a4YdAt SkhCEf/UZ4A0FbIfJPjbzMrrwhub53O5yR7/6nHBVgah/6bAIYgFQnqJ3LRW3bsVm6nq L8jA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=y5O+kjgBDmNmptknsqNCUzo00Hmm0udZIBS0cofcDho=; fh=KvaJsPjjy/nH1PcWvzpfRp4O8bLpxgiJHP1SzcQ8o5w=; b=p7w76re4TZgHf1ctGNAcbhH8sasbGH4LWIfTbOY4HQEbIHfGl0jGyusmkZRODDBM86 eB0rnRQrrf0OpKt/naGW7M+ACVBAM3NNbcx076rqRt4/4d+pDvmtsJ42SjY4OlmhjB4L 5lAYDogQ4dUU/cNHciHAQc7ttTK7S32FUTZj8CLxRdgVrpn9vtDrtJTi/qi6OFVGLEHo MzDwYPu0GbXbgYZPqlEuCo6+B8fR9l7l1MVGSf7USr6KTtK8gflmk2lHdJ31mqNnWtfi fksAV0QeJRJeo7mkHIsWBgs+S+vmwuP9irWCk4HyIySOk2Jh3eXxwBwX8ItoKQssP2Do Vrxg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hf0+exwv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id s4-20020a50ab04000000b0055a5cda9ce8si483960edc.47.2024.01.26.02.32.05 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 02:32:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hf0+exwv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39967-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E20E71F2E2D6 for <ouuuleilei@gmail.com>; Fri, 26 Jan 2024 10:23:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 74E855B5BC; Fri, 26 Jan 2024 10:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hf0+exwv" Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E1A125AB for <linux-kernel@vger.kernel.org>; Fri, 26 Jan 2024 10:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706263238; cv=none; b=gt0BoRf8AqpxJbP40+0YBe60xoiP+hEPggiydLULmkyqhCO13dBHVDGqA03Dfhu+gJ0bArvNKiitdtvpwKUp7by/JHHHlh99oB40tOQjZiOk+wJ1nEsWhtNESFhUkIpOdis4h1/V6PvcQQO2JPW5+fQ765GIeJg5RQenpZkSyVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706263238; c=relaxed/simple; bh=jDG1S3cli+/SN3fqh2FR8VpGIzYKVsUmuM/W0dRG70I=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=pafu96ijtWBaaypVy4xACpooVNEm/vykPhK3c7c6BkBc11cQcSn5HlFGVomK6hMKeOECpciloh+uGntojvM8gPWdxxlFZVZpNmU0cS1WOj/RD4694g3exQhzQE5g1Of9kYbPXjTShBedMB2NlcqwH4cld+noRJ1rC3hZ4zsL34w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Hf0+exwv; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-337cf4eabc9so225415f8f.3 for <linux-kernel@vger.kernel.org>; Fri, 26 Jan 2024 02:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706263235; x=1706868035; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=y5O+kjgBDmNmptknsqNCUzo00Hmm0udZIBS0cofcDho=; b=Hf0+exwv9RN7xnqbzcvCyIAslLR1AKSxw3fn9BHu+dnYt2xT2/KISBasSmqRmKycXe z2jcXheomeEvjXsSEsa56AVuH3WXjqkVwSbM+IGewqmw4sfrXmICe3jqbkHx6k2YKKJC ESwdHYD8lzgcyzv+3bdDlYtM4gIM0eEo4/OatW+mAeFsuCA2zoBeMkVU6yxaeJpjxoMI 9g7vmyI/2/J9KwVcGMoM0mPA0gked8lAtE9Npx8JQMz0QrDnfjMNTEIMen4q6QpzgePY akzZjeNSgM5QIDDFN4/ZkWo69sUEfm0ALIIzGeq+fUN9IU15T3FOi/rEl94vqs6MkpDq s+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706263235; x=1706868035; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y5O+kjgBDmNmptknsqNCUzo00Hmm0udZIBS0cofcDho=; b=nK6zQTv2MiiNjp0AFqaiMeOHu7L4IZTwAjvL+2hJ2YYdDkQJCtb8fuNBXmZFXbt5tE ++QcnIBwxWfatymMuWcN/H+j7YbivugHaxlbrkm1NIVeuqJ+fdZ+GvPN723JWzAddCWG 0MdAyh1v9lBAHIIKPaJZa+rsbgrkC9dvvNky5SE/YhKK1mYfH6B/HeSjltD+8TGPzZff /aDgerCdvdTpsMtM/iUoBRyx/jVKBmeXQMi9AK4TCiCAjHV9Xg5nfeO1qvT5CaF8cLST A13fB3oH4iMERmHLfId4lnr23qKJd8Vkx1Nfgz14eHMB4g40AGaa8uhEvpNgM9brGsUY sgOA== X-Gm-Message-State: AOJu0YyH/mbN/bp5kQ5cKvu4Bxb0i+Y8o7rCrFtYTMU3vpRQwN/jlASM 1SRwgfcj8+HMLtgD2JGtANA2K830cuLXmDjlQSl1nanaAaReul7wP91/dAbxmjDx2HSMVnkWAno i X-Received: by 2002:a5d:4dc4:0:b0:33a:d00e:8840 with SMTP id f4-20020a5d4dc4000000b0033ad00e8840mr662247wru.96.1706263235097; Fri, 26 Jan 2024 02:00:35 -0800 (PST) Received: from [127.0.1.1] ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id ox27-20020a170907101b00b00a3221b95ce8sm448494ejb.77.2024.01.26.02.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 02:00:34 -0800 (PST) From: Abel Vesa <abel.vesa@linaro.org> Subject: [PATCH v5 00/11] arm64: dts: qcom: Add more support to X1E80100 base dtsi, CRD and QCP boards Date: Fri, 26 Jan 2024 12:00:11 +0200 Message-Id: <20240126-x1e80100-dts-missing-nodes-v5-0-3bb716fb2af9@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAKuCs2UC/43O3WrDMAwF4Fcpvp42SXHadFd7j7ELx5YTQ2cPO 4SOknef0/2wUQjT3ZHQx7moIjlIUY+7i8oyhxJSrKG92yk7mjgIBFezYuSGGAnOJB0SIripwGs oJcQBYnJSwODRk7jjOqoCvSkCfTbRjivR64ef589TShNMCcoop9P68JbFh/O1zfNLzWMoU8rv1 3IzrduvHsRbPWYCBNIHFi+We+yeTiGanO5THtTqzvzbajctrlZr9uItaodob6zm/1ZTLaulc9T tjfN8Y+lvSyNxs2npauGBnWXfWmqbP9ayLB8NJi1y2gEAAA== To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Sibi Sankar <quic_sibis@quicinc.com>, Rajendra Nayak <quic_rjendra@quicinc.com> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=3312; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=jDG1S3cli+/SN3fqh2FR8VpGIzYKVsUmuM/W0dRG70I=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBls4KwLxPoiuBEUiz+aey2uwx5sPEPRXypR8Js/ 9yXLc91Le2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZbOCsAAKCRAbX0TJAJUV VpmkD/41BZX+r+412BUQXKDZvLiD786KUlCJvJXcn0f+m643U8nWfvO3N9etPAlm8hY0jXUQcPk XEvjUxRVTM1gdDhIYvWU/NzK1fLgU7grNqJpVv1sHVD9WH87YoF8aWaFHVlaW3UCM9ChThyfH3R Xd9RvDEhVvx47HEmdmlcUM86aDCheCIktC0EeUrrIAg2GNzDDi5kpDs8I9lPWieOuU8FDylxUYp MW5jc1GUR+uf3glYzFhYFXUcW6llKCsgyq1hZssEEkXV5Cd3VFREFJpk2QTfiS2FM8ol1/hhNuA ldBTdUYo4s0sXIYkcHx4Jfi7+dMubdggFQFX0TbG8bPvPR1PHH5s1hN9nK8y5NW0bro8GQ6GcsV Jpp/E2jT7gOQvFBblo0mosYBDvxSfdyHaO7STiBwayYUHWCXFb6upCv9KKOb7c4HfqthJCx5KcR DWmvBZO2INuQ/FFco0O3tYZJM+73JtCQUhJtDFA0iv9O8qWkPXOehJS3GKmITZap3tID8aP0jEo SMQCvV71a0Ks07g7xAU5MWLF3H6VE5jI2ZflPln5yb5UokFLCuySgr5sGzp1i1gW1FvgnDMaRMF Oxe9APlvI/3sbvUy6p4EPA1Dd2ioIgXM+DltpnWXeBZ2n7tUy5oI4NHAXDZRvxvADJbTFYY7EIz vwLDBnJLyLgsFHA== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789148660787188301 X-GMAIL-MSGID: 1789148660787188301 |
Series |
arm64: dts: qcom: Add more support to X1E80100 base dtsi, CRD and QCP boards
|
|
Message
Abel Vesa
Jan. 26, 2024, 10 a.m. UTC
This patchset adds every node necessary for both the CRD and QCP to boot
with PCIe, USB and embedded DisplayPort.
This patchset depends on the Disp CC and TCSR CC bindings.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Changes in v5:
- Added Konrad's R-b tags to patches 1 through 4 and A-b tag to patch 11
- Changed the clock of the usb2 HS PHY to TCSR_USB2_2_CLKREF_EN, the USB1
SSx HS PHY seem to be sharing the TCSR_USB2_1_CLKREF_EN
- Prefixed DISP_CC_MDSS_CORE_* gdscs with MDSS_* to be more in line with
SM8[56]50 platforms.
- Added "cpu-cfg" icc path to the mdss node.
- Marked all USB1 SS[1-3] controllers as dma coherent.
- Re-worded the adding TCSR node commit message by just dropping the
"halt" word as the halt registers are not part of this region. The
TCSR offers more than just a clock controller and therefore called it
generically "TCSR register space".
- Link to v4: https://lore.kernel.org/r/20240123-x1e80100-dts-missing-nodes-v4-0-072dc2f5c153@linaro.org
Changes in v4:
- After a discussion off-list, it was suggested by Bjorn to split in separate patches.
- Addressed all of Konrad's comments, except of the clock-names one for the mdss,
which there is nothing to be done about as all non-v5 do clk_bulk_get_all.
- Added more support to QCP, to be more aligned with CRD (except touchscreen
and keyboard)
- Added a patch to fix some LDOs supplies on QCP
- Link to v3: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v3-0-c4e8d186adf2@linaro.org
Changes in v3:
- Reword the commit messages
- Link to v2: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v2-0-5a6efc04d00c@linaro.org
Changes in v2:
- Reword both commits to make it more clear nodes that are being added
- Dropped comments from interrupt maps from pcie nodes
- Replace all 0x0 with 0 in all reg properties
- Moved on separate lines reg, reset and clock names
- Dropped the sram and cpucp nodes
- Dropped pmic glink node
- Reordered all new clock controller nodes based on address
- Dropped unnecessary indent from touchpad and keyboard TLMM nodes
- Link to v1: https://lore.kernel.org/r/20231212-x1e80100-dts-missing-nodes-v1-0-1472efec2b08@linaro.org
---
Abel Vesa (7):
arm64: dts: qcom: x1e80100: Add TCSR node
arm64: dts: qcom: x1e80100: Add USB nodes
arm64: dts: qcom: x1e80100: Add PCIe nodes
arm64: dts: qcom: x1e80100: Add display nodes
arm64: dts: qcom: x1e80100-crd: Enable more support
arm64: dts: qcom: x1e80100-qcp: Enable more support
arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J
Sibi Sankar (4):
arm64: dts: qcom: x1e80100: Add IPCC node
arm64: dts: qcom: x1e80100: Add SMP2P nodes
arm64: dts: qcom: x1e80100: Add QMP AOSS node
arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 222 +++++
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 175 +++-
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1368 ++++++++++++++++++++++++++++-
3 files changed, 1758 insertions(+), 7 deletions(-)
---
base-commit: 853dab01a34378871b37a5e6a800e97a997fe16c
change-id: 20231201-x1e80100-dts-missing-nodes-a09f1ed99999
Best regards,
Comments
On Fri, Jan 26, 2024 at 12:00:11PM +0200, Abel Vesa wrote: > This patchset adds every node necessary for both the CRD and QCP to boot > with PCIe, USB and embedded DisplayPort. > > This patchset depends on the Disp CC and TCSR CC bindings. I'm guessing you're referring to the patches from December, which has review feedback from your colleagues? Please respin the clock series. Thanks, Bjorn > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Changes in v5: > - Added Konrad's R-b tags to patches 1 through 4 and A-b tag to patch 11 > - Changed the clock of the usb2 HS PHY to TCSR_USB2_2_CLKREF_EN, the USB1 > SSx HS PHY seem to be sharing the TCSR_USB2_1_CLKREF_EN > - Prefixed DISP_CC_MDSS_CORE_* gdscs with MDSS_* to be more in line with > SM8[56]50 platforms. > - Added "cpu-cfg" icc path to the mdss node. > - Marked all USB1 SS[1-3] controllers as dma coherent. > - Re-worded the adding TCSR node commit message by just dropping the > "halt" word as the halt registers are not part of this region. The > TCSR offers more than just a clock controller and therefore called it > generically "TCSR register space". > - Link to v4: https://lore.kernel.org/r/20240123-x1e80100-dts-missing-nodes-v4-0-072dc2f5c153@linaro.org > > Changes in v4: > - After a discussion off-list, it was suggested by Bjorn to split in separate patches. > - Addressed all of Konrad's comments, except of the clock-names one for the mdss, > which there is nothing to be done about as all non-v5 do clk_bulk_get_all. > - Added more support to QCP, to be more aligned with CRD (except touchscreen > and keyboard) > - Added a patch to fix some LDOs supplies on QCP > - Link to v3: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v3-0-c4e8d186adf2@linaro.org > > Changes in v3: > - Reword the commit messages > - Link to v2: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v2-0-5a6efc04d00c@linaro.org > > Changes in v2: > - Reword both commits to make it more clear nodes that are being added > - Dropped comments from interrupt maps from pcie nodes > - Replace all 0x0 with 0 in all reg properties > - Moved on separate lines reg, reset and clock names > - Dropped the sram and cpucp nodes > - Dropped pmic glink node > - Reordered all new clock controller nodes based on address > - Dropped unnecessary indent from touchpad and keyboard TLMM nodes > - Link to v1: https://lore.kernel.org/r/20231212-x1e80100-dts-missing-nodes-v1-0-1472efec2b08@linaro.org > > --- > Abel Vesa (7): > arm64: dts: qcom: x1e80100: Add TCSR node > arm64: dts: qcom: x1e80100: Add USB nodes > arm64: dts: qcom: x1e80100: Add PCIe nodes > arm64: dts: qcom: x1e80100: Add display nodes > arm64: dts: qcom: x1e80100-crd: Enable more support > arm64: dts: qcom: x1e80100-qcp: Enable more support > arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J > > Sibi Sankar (4): > arm64: dts: qcom: x1e80100: Add IPCC node > arm64: dts: qcom: x1e80100: Add SMP2P nodes > arm64: dts: qcom: x1e80100: Add QMP AOSS node > arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 222 +++++ > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 175 +++- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1368 ++++++++++++++++++++++++++++- > 3 files changed, 1758 insertions(+), 7 deletions(-) > --- > base-commit: 853dab01a34378871b37a5e6a800e97a997fe16c > change-id: 20231201-x1e80100-dts-missing-nodes-a09f1ed99999 > > Best regards, > -- > Abel Vesa <abel.vesa@linaro.org> >
On 24-01-27 20:36:33, Bjorn Andersson wrote: > On Fri, Jan 26, 2024 at 12:00:11PM +0200, Abel Vesa wrote: > > This patchset adds every node necessary for both the CRD and QCP to boot > > with PCIe, USB and embedded DisplayPort. > > > > This patchset depends on the Disp CC and TCSR CC bindings. > > I'm guessing you're referring to the patches from December, which has > review feedback from your colleagues? > > Please respin the clock series. Was trying to figure out the GCC_DISP_AHB_CLK pm_clk_add()-ed to the dispcc. But as discussed off-list, GCC_DISP_XO_CLK falls into same category and I'm not sure what it is tied to (yet). Anyway, that should be a separate patchset as it should fix SM8550 and SM8650 as well. Meanwhile, here are the clock controllers: https://lore.kernel.org/r/20240129-x1e80100-clock-controllers-v3-0-d96dacfed104@linaro.org > > Thanks, > Bjorn > > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Changes in v5: > > - Added Konrad's R-b tags to patches 1 through 4 and A-b tag to patch 11 > > - Changed the clock of the usb2 HS PHY to TCSR_USB2_2_CLKREF_EN, the USB1 > > SSx HS PHY seem to be sharing the TCSR_USB2_1_CLKREF_EN > > - Prefixed DISP_CC_MDSS_CORE_* gdscs with MDSS_* to be more in line with > > SM8[56]50 platforms. > > - Added "cpu-cfg" icc path to the mdss node. > > - Marked all USB1 SS[1-3] controllers as dma coherent. > > - Re-worded the adding TCSR node commit message by just dropping the > > "halt" word as the halt registers are not part of this region. The > > TCSR offers more than just a clock controller and therefore called it > > generically "TCSR register space". > > - Link to v4: https://lore.kernel.org/r/20240123-x1e80100-dts-missing-nodes-v4-0-072dc2f5c153@linaro.org > > > > Changes in v4: > > - After a discussion off-list, it was suggested by Bjorn to split in separate patches. > > - Addressed all of Konrad's comments, except of the clock-names one for the mdss, > > which there is nothing to be done about as all non-v5 do clk_bulk_get_all. > > - Added more support to QCP, to be more aligned with CRD (except touchscreen > > and keyboard) > > - Added a patch to fix some LDOs supplies on QCP > > - Link to v3: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v3-0-c4e8d186adf2@linaro.org > > > > Changes in v3: > > - Reword the commit messages > > - Link to v2: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v2-0-5a6efc04d00c@linaro.org > > > > Changes in v2: > > - Reword both commits to make it more clear nodes that are being added > > - Dropped comments from interrupt maps from pcie nodes > > - Replace all 0x0 with 0 in all reg properties > > - Moved on separate lines reg, reset and clock names > > - Dropped the sram and cpucp nodes > > - Dropped pmic glink node > > - Reordered all new clock controller nodes based on address > > - Dropped unnecessary indent from touchpad and keyboard TLMM nodes > > - Link to v1: https://lore.kernel.org/r/20231212-x1e80100-dts-missing-nodes-v1-0-1472efec2b08@linaro.org > > > > --- > > Abel Vesa (7): > > arm64: dts: qcom: x1e80100: Add TCSR node > > arm64: dts: qcom: x1e80100: Add USB nodes > > arm64: dts: qcom: x1e80100: Add PCIe nodes > > arm64: dts: qcom: x1e80100: Add display nodes > > arm64: dts: qcom: x1e80100-crd: Enable more support > > arm64: dts: qcom: x1e80100-qcp: Enable more support > > arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J > > > > Sibi Sankar (4): > > arm64: dts: qcom: x1e80100: Add IPCC node > > arm64: dts: qcom: x1e80100: Add SMP2P nodes > > arm64: dts: qcom: x1e80100: Add QMP AOSS node > > arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes > > > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 222 +++++ > > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 175 +++- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1368 ++++++++++++++++++++++++++++- > > 3 files changed, 1758 insertions(+), 7 deletions(-) > > --- > > base-commit: 853dab01a34378871b37a5e6a800e97a997fe16c > > change-id: 20231201-x1e80100-dts-missing-nodes-a09f1ed99999 > > > > Best regards, > > -- > > Abel Vesa <abel.vesa@linaro.org> > >
On Fri, 26 Jan 2024 12:00:11 +0200, Abel Vesa wrote: > This patchset adds every node necessary for both the CRD and QCP to boot > with PCIe, USB and embedded DisplayPort. > > This patchset depends on the Disp CC and TCSR CC bindings. > > Applied, thanks! [01/11] arm64: dts: qcom: x1e80100: Add IPCC node commit: 6a07a4f3f509c370c4f2644c2f576d1e8029354c [02/11] arm64: dts: qcom: x1e80100: Add SMP2P nodes commit: 0b6ae7364b1133f55eec027e358eec09d3bdc2ff [03/11] arm64: dts: qcom: x1e80100: Add QMP AOSS node commit: 2661646f5934c9e6a4067ac325ef023eef611423 [04/11] arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes commit: 5f2a9cd4b1042ade3824cfe324aa02a3c17430a8 [05/11] arm64: dts: qcom: x1e80100: Add TCSR node commit: 8b6e2bf94b278c69746358425daae2a75041f7dc [06/11] arm64: dts: qcom: x1e80100: Add USB nodes commit: 4af46b7bd66fa3ad9bd87e2ded26599d11562d52 [07/11] arm64: dts: qcom: x1e80100: Add PCIe nodes commit: 5eb83fc10289db0c13ceaea601151883c0da43f4 [08/11] arm64: dts: qcom: x1e80100: Add display nodes commit: 1940c25eaa63f65942e6149715e17a61438e2162 [09/11] arm64: dts: qcom: x1e80100-crd: Enable more support commit: d7e03cce0400cb42d79088a3bb0a59f63bdf50b3 [10/11] arm64: dts: qcom: x1e80100-qcp: Enable more support commit: f9a9c11471da32133ea6ee8763f932b91018e256 [11/11] arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J commit: 7eac281cbedbd71d777eabca3a52d97983c61692 Best regards,