mbox series

[v2,0/2] ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+

Message ID 20240125153110.410295-1-krzysztof.kozlowski@linaro.org
Headers
Series ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+ |

Message

Krzysztof Kozlowski Jan. 25, 2024, 3:31 p.m. UTC 
  Hi,

Changelog in individual patches.

v1:
https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

Krzysztof Kozlowski (2):
  ASoC: codecs: tx-macro: split widgets per different LPASS versions
  ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+

 sound/soc/codecs/lpass-macro-common.h |   7 +
 sound/soc/codecs/lpass-tx-macro.c     | 666 +++++++++++++++++++-------
 2 files changed, 501 insertions(+), 172 deletions(-)

Comments

Srinivas Kandagatla Jan. 26, 2024, 1:21 p.m. UTC | #1 
On 25/01/2024 15:31, Krzysztof Kozlowski wrote:
> Hi,
> 
> Changelog in individual patches.
> 
> v1:
> https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@linaro.org/
> 

Unfortunately this is breaking mic on X13s.

--srini

> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (2):
>    ASoC: codecs: tx-macro: split widgets per different LPASS versions
>    ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+
> 
>   sound/soc/codecs/lpass-macro-common.h |   7 +
>   sound/soc/codecs/lpass-tx-macro.c     | 666 +++++++++++++++++++-------
>   2 files changed, 501 insertions(+), 172 deletions(-)
>
Krzysztof Kozlowski Jan. 26, 2024, 1:23 p.m. UTC | #2 
On 26/01/2024 14:21, Srinivas Kandagatla wrote:
> 
> 
> On 25/01/2024 15:31, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Changelog in individual patches.
>>
>> v1:
>> https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@linaro.org/
>>
> 
> Unfortunately this is breaking mic on X13s.

Did you update also your mixer? I was asking last time about this as well...

Best regards,
Krzysztof
Srinivas Kandagatla Jan. 26, 2024, 2:42 p.m. UTC | #3 
On 26/01/2024 13:23, Krzysztof Kozlowski wrote:
> On 26/01/2024 14:21, Srinivas Kandagatla wrote:
>>
>>
>> On 25/01/2024 15:31, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> Changelog in individual patches.
>>>
>>> v1:
>>> https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@linaro.org/
>>>
>>
>> Unfortunately this is breaking mic on X13s.
> 
> Did you update also your mixer? I was asking last time about this as well...

Updating to new mixer setting fixes the issue.

This is going to be a issue with the existing ucm which becomes broken 
with this new patches.

Are you going to send patches to fix the ucm too?


--srini
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Jan. 26, 2024, 2:44 p.m. UTC | #4 
On 26/01/2024 15:42, Srinivas Kandagatla wrote:
> 
> 
> On 26/01/2024 13:23, Krzysztof Kozlowski wrote:
>> On 26/01/2024 14:21, Srinivas Kandagatla wrote:
>>>
>>>
>>> On 25/01/2024 15:31, Krzysztof Kozlowski wrote:
>>>> Hi,
>>>>
>>>> Changelog in individual patches.
>>>>
>>>> v1:
>>>> https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@linaro.org/
>>>>
>>>
>>> Unfortunately this is breaking mic on X13s.
>>
>> Did you update also your mixer? I was asking last time about this as well...
> 
> Updating to new mixer setting fixes the issue.
> 
> This is going to be a issue with the existing ucm which becomes broken 
> with this new patches.
> 
> Are you going to send patches to fix the ucm too?

I could, but we should really think whether affecting sc8280xp is worth.
AFAIK, the microphones work there, so we do not need to fix them even
though fix is correct. It's the other platforms which need the fix.

Best regards,
Krzysztof