Message ID | 20240125-dispcc-sm8550-sm8650-drop-disp-ahb-clk-v1-0-0f8d96156156@linaro.org |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1533843dyi; Thu, 25 Jan 2024 02:06:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwjoFSboMB1cysjP453e4f3RzorMvSA1tdpbWVs64oiCQdFT+3ahjfTMk6yGAEmfe8LgXX X-Received: by 2002:a17:906:3889:b0:a30:f149:153 with SMTP id q9-20020a170906388900b00a30f1490153mr528064ejd.22.1706177183964; Thu, 25 Jan 2024 02:06:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706177183; cv=pass; d=google.com; s=arc-20160816; b=I+XpY0+BBa1bIPxt3xQwXzVQqdyTa+DuUf82adqWlwbmo8MYL8uWzJPC3SIaHsduJ+ M9MrnY5H51qO0eFusYyvjHURVe8GsEXfopkoIz+Na83rS9Ww+GlgReJXmznvCiZVGtrJ 3nfSO4A9nh1olL492fgrmPddhThnG1rliQZpPDQk5pjCpm+dHa/m2OMTIq0LS5x1wL/M 7h3hBlWVhguWW9VSCxc3Az9/FNsRQ2264/ET69oiwuysU/gnt6XCQEl8WTPJ/YprKc62 OsvP5MtiHNW3S/PDYEMn1adf9yzJ+dJBHUEayNgrcDa+MpGs2rhHC6QYtVxXqNpj4bpd Enig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=KH02RcuM2+v9UWcFG0xYMqcwTW43qilDo47iIK70Yx8=; fh=nNej6OTmgaH+TMbac95H/cPehhb0fn+HqF9AwfFMy64=; b=e9lVFJztxOZ1UjgT6CxudiaKSd6h4hRpqOZqfPDOdF8vPYZICnpl+FMyUJmaii3lhH apMvAo0WCQul46cstW6L5FlxUqkYVBI7zEcOMr3WxU5fIeHGkEdsy0f5ytWtXL7Odvkk 4Y8Bd/INXxkXiSQQ3YEwAgJ0rHj8FvjDxlfHdjhBzbTcQocS7NZKReogUyWNpstfqRWB bkudAYn+VBszUHXvgBMnh0PCa0d6LR9WI1Fw5Nl+UZPl+Rh5Ln/bU0yRwvSsfWEbb4JA cIR4AIxZECEfr99u12S0RM4wg9meSaxA+7JT+6UERAPkU2auRGQ295Zn1M3NoSAFMxXe biHw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x6+4eyLj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id r10-20020a1709067fca00b00a2ceb076c21si818571ejs.801.2024.01.25.02.06.23 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:06:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x6+4eyLj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38257-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 821301F2CE48 for <ouuuleilei@gmail.com>; Thu, 25 Jan 2024 09:28:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 710B21CA82; Thu, 25 Jan 2024 09:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x6+4eyLj" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF381BF26 for <linux-kernel@vger.kernel.org>; Thu, 25 Jan 2024 09:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706174885; cv=none; b=cFiiniiZ6tOntAISRSn/ckDli6BwXxW9Kiv2iBjLJVT0qp8NmN+ShrWM5TfJtTJlywnzSILBmXEaHrshJjABIXsjIDZPwg9YZ5gjqk4au6CbIE1nCo5tHoCtzMgWDS3G3wypFMzvkS97zoELJHWRREzltZ5pQP4hadsNBiQ95gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706174885; c=relaxed/simple; bh=gy0zUIMX0ecGhpvp4QAVUCRKbXWcUlLlLRZf94hkeOk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=QLJxbWZ3eqK3dctUirteqPHWRuFMzaYHFOfMj/w/5kqvjhRW5oLDs2YZTLMcrG4fbifgBEQn+H8XzhnqlWL9APNHIgQUQ8jfyIRe31YgnL2yAC0Qz/G1ItV3zlr4gvKsGMvr4T7g8LLBzX3efQDkghs4E03XMiW7YC2HfuV0KHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x6+4eyLj; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-55a90b2b554so5315515a12.1 for <linux-kernel@vger.kernel.org>; Thu, 25 Jan 2024 01:28:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706174882; x=1706779682; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=KH02RcuM2+v9UWcFG0xYMqcwTW43qilDo47iIK70Yx8=; b=x6+4eyLjhocUR6N46/NzRVdBcljV/rOLTyeoqjqYvfI9U83Cha43z7H3aAi/aTAm2O uxin+Ph/c3HnIwiPvvF4Z2VOhztASGo2JjpW3GJOwl4obtmM3xpQUod2l6rOMh7RVwNe M3GZCDLwBh0e7OXN9G39tNrohVDac4grOnp+caS/KIybVzmOOPtfL3YWquQXdebrQYd8 2A4imYpqPaZNHdFjEgZ/CByvqDsRnCqF1wQgUis2QdEHIxIPi55tvCXbAkG2B9adDVKc rLh2sL4TPp8p2prdiBXwGdPbHHlXYgMuY47Dg9wbLQRu6AeMIVOpFHmb3uZ2Cnbj24bB WmVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706174882; x=1706779682; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KH02RcuM2+v9UWcFG0xYMqcwTW43qilDo47iIK70Yx8=; b=ms0nSBRZvwm6/eJ5k4zugooVpOETnLKNxP4tq8r+6iTcNJ/EVp1qEE6++YPX2JhHuk WSnhpPSbqATrSE5X8nOxxOhjBn2PDnEqG8XHletDBEeDb8mG27NuigzUugHjIxyLYqo1 eJTXxJDmDPdovlfgJCzWJ4j7zPYqsVb/zMrB2HsuXssiMHWTr6GxPn/hzzkK/9o8oynb c07BsQQwo2BLXCq9cxKU80p2yez3UlgqcYB7Q8WHFu995pYoGRu3YPkvB9+B2sNPuCJZ NVt+fcnwG05X6UQqvyaJNF3EG+m1K+49vt62m9XH+57DEuq0/0O5tD9jEC1Rmu9xtCR7 3OYA== X-Gm-Message-State: AOJu0YyminRrZjBCtYlTBpZ2tnVlA0kI5IlufsyDxJTQY/6zgJqkgjNZ MnOLZBrW23DB2cZxsvNy7X+8q3Rp6m7zKFfd925faPBVTDF/LUtIB1Tli3hQrh4= X-Received: by 2002:aa7:da8e:0:b0:55c:7dbe:2c47 with SMTP id q14-20020aa7da8e000000b0055c7dbe2c47mr35179eds.29.1706174881745; Thu, 25 Jan 2024 01:28:01 -0800 (PST) Received: from [127.0.1.1] ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id f19-20020a056402005300b00554af5ec62asm17356391edu.8.2024.01.25.01.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 01:28:01 -0800 (PST) From: Abel Vesa <abel.vesa@linaro.org> Subject: [PATCH 0/5] clk: qcom: sm8[56]50: Drop the Disp AHB clock from Display Clock Controller Date: Thu, 25 Jan 2024 11:27:44 +0200 Message-Id: <20240125-dispcc-sm8550-sm8650-drop-disp-ahb-clk-v1-0-0f8d96156156@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAJApsmUC/x2NywqDMBBFf0Vm7UASTFv9FXERk0kd6iNkoBSC/ 27q6nC4cG4BocwkMDQFMn1Z+Nir6LYBv7j9TcihOhhlOqWNxcCSvEfZXtaqPx4VIR/pXtAtM/r 1g9EpreNzpj46qLGUKfLvPhqn87wA7N0rq3gAAAA= To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1190; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=gy0zUIMX0ecGhpvp4QAVUCRKbXWcUlLlLRZf94hkeOk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBlsimVIXDYDCtv1pTKnIrt9mks0y3gW2UWjifWu VCieoCzUouJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZbIplQAKCRAbX0TJAJUV VtvAD/wPCohABL7H3uUrA8gJ+cgaA1bMLZB+k3KUurpKJmMm6vO9Uy1h/rQTDsIN19EvrgoOETz TBCtU4zH7jRCPTy+CBUR0Zb6/rzvZA47l/TxiG2Vy2RyPRvrPyohlcGWMmN8GEGIrn3TRUhcnoT qKtD6TdZqmzeCwoH8PsuezyTiUe8l4mJOUTDv/r4GxvXJb1itQXz669HlF3zjZ6a3YFZ+nGKczi sXRIVDuZFlnSKRSNKH4e2ru7GZi2vAk4d2nWQbRwHMow+iHVC7LY08yGnMrFAza0fc6D8yvGhCn T1EPSohGOJ42PFnRKeLC5eKMDZRhT5iZN+wwbUMZaAFhrzrl0tuHpgjgBjwQkHnZ2JfeDwiG350 n7Dkdjqc8PABVewqRNHIkKd7BHiLtoR+dhWarZd3PYiEi1BMIG7w+w+x4YU+ixM4M/TNrvV/atV /BdWEX/OY4f/SDxKIsD/4jGjBAADoS57s0KD5z4d5sYV8YIEJw+MZaJs9QCA7KpCL2RPUnIYgJa aiAUUikBZiDlQhN/wYj0v3YF7Sh44P83PspafVewi2G6ZriQ1Ozf1Ym3QgZjqS2KFAAvUBwvYb3 Pz5/S4F8ffTC+iLnhBuq44lcJHT43Ox3R8rkG3ncsYsDFQUu3xmn6UWGFQeeygalg4bNyNJhBcj 6RnMzW0Z1c2aoRg== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789055403486855767 X-GMAIL-MSGID: 1789056446895765913 |
Series |
clk: qcom: sm8[56]50: Drop the Disp AHB clock from Display Clock Controller
|
|
Message
Abel Vesa
Jan. 25, 2024, 9:27 a.m. UTC
The Disp AHB clock is provided by the GCC but never registered. It is
instead enabled on probe as it is expected to be always-on. So it should
be dropped from Disp CC entirely.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (5):
dt-bindings: clock: sm8550-dispcc: Drop the Disp AHB clock
arm64: dts: qcom: sm8550: Drop the Disp AHB clock from dispcc node
arm64: dts: qcom: sm8650: Drop the Disp AHB clock from dispcc node
clk: qcom: dispcc-sm8550: Drop the Disp AHB DT provided clock
clk: qcom: dispcc-sm8650: Drop the Disp AHB DT provided clock
Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 2 --
arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 -
arch/arm64/boot/dts/qcom/sm8650.dtsi | 1 -
drivers/clk/qcom/dispcc-sm8550.c | 1 -
drivers/clk/qcom/dispcc-sm8650.c | 1 -
5 files changed, 6 deletions(-)
---
base-commit: 01af33cc9894b4489fb68fa35c40e9fe85df63dc
change-id: 20240125-dispcc-sm8550-sm8650-drop-disp-ahb-clk-fa011f7be9fa
Best regards,
Comments
On 24-01-25 10:49:23, Konrad Dybcio wrote: > > > On 1/25/24 10:27, Abel Vesa wrote: > > The Disp AHB clock is provided by the GCC but never registered. It is > > instead enabled on probe as it is expected to be always-on. So it should > > be dropped from Disp CC entirely. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Abel, you just raised some concerns over my series doing this and now > you're doing the same, plus breaking backwards compatibility for no > good reason, instead of solving the problem. Sorry but, during the off-list discussion, you convinced me that it is OK to drop their registration as long as we enable them on probe. I've not seen the following reply in time before sending current series: https://lore.kernel.org/all/6aa58497-9727-4601-b6eb-264c478997c3@linaro.org/ Since this is blocking the patches for dispcc and dts for X1E80100, I thought I'd just drop the clock as required from DT point of view. But yeah, you're right, it breaks bindings ABI and that's wrong. > > The correct solution here is to register the AHB clock with GCC and > pm_clk_add() it from dispcc's .probe (and enable runtime PM on dispcc > if it's already not the case). Then the AHB clock will be gated when > no display hardware (= no dispcc consumer) is in use. I agree. > > 8[56]50 are in a good position for this, as they already have the > required DTS reference. Unfortunately, I still haven't fully dug > into this for platforms without one, but that's on me. Since I need to do this for the X1E80100, I'll probably do it for the other two as well. Sorry for the misunderstanding. > > Konrad
On 1/25/24 11:44, Abel Vesa wrote: > On 24-01-25 10:49:23, Konrad Dybcio wrote: >> >> >> On 1/25/24 10:27, Abel Vesa wrote: >>> The Disp AHB clock is provided by the GCC but never registered. It is >>> instead enabled on probe as it is expected to be always-on. So it should >>> be dropped from Disp CC entirely. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >>> --- >> >> Abel, you just raised some concerns over my series doing this and now >> you're doing the same, plus breaking backwards compatibility for no >> good reason, instead of solving the problem. > > Sorry but, during the off-list discussion, you convinced me that it is OK to drop > their registration as long as we enable them on probe. > > I've not seen the following reply in time before sending current series: > https://lore.kernel.org/all/6aa58497-9727-4601-b6eb-264c478997c3@linaro.org/ > > Since this is blocking the patches for dispcc and dts for X1E80100, I > thought I'd just drop the clock as required from DT point of view. > But yeah, you're right, it breaks bindings ABI and that's wrong. > >> >> The correct solution here is to register the AHB clock with GCC and >> pm_clk_add() it from dispcc's .probe (and enable runtime PM on dispcc >> if it's already not the case). Then the AHB clock will be gated when >> no display hardware (= no dispcc consumer) is in use. > > I agree. > >> >> 8[56]50 are in a good position for this, as they already have the >> required DTS reference. Unfortunately, I still haven't fully dug >> into this for platforms without one, but that's on me. > > Since I need to do this for the X1E80100, I'll probably do it for the > other two as well. Thanks! > > Sorry for the misunderstanding. The story is confusing as per usual, perhaps I could have explained it better in the first place.. Konrad