mbox series

[v2,0/2] board: imx8mn-rve-gateway: fix compatible description

Message ID 20240124164646.1506814-1-hugo@hugovil.com
Headers
Series board: imx8mn-rve-gateway: fix compatible description |

Message

Hugo Villeneuve Jan. 24, 2024, 4:46 p.m. UTC 
  From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Hello,
this patch series fixes compatible description for the RVE gateway board.

Thank you.

Link: [v1] https://lore.kernel.org/all/20240124154422.3600920-1-hugo@hugovil.com/raw

Changes for V2:
-Add Fixes tags

Hugo Villeneuve (2):
  dt-bindings: arm: fsl: remove redundant company name
  arm64: dts: imx8mn-rve-gateway: remove redundant company name

 Documentation/devicetree/bindings/arm/fsl.yaml       | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: 615d300648869c774bd1fe54b4627bb0c20faed4

Comments

Krzysztof Kozlowski Jan. 24, 2024, 5 p.m. UTC | #1 
On 24/01/2024 17:46, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Company name in compatible description appears twice, which is not really
> helpful, so remove it from product name.

It's just a string. There is no bug, at least you did not describe where
the bug is.

This has probably little impact on user-space, but there could be such
which actually reads compatibles and depends on them. Or bootloader or
whatever. Therefore to me such cosmetic change of correct compatible is
not worth ABI impact.

Best regards,
Krzysztof
Hugo Villeneuve Jan. 24, 2024, 5:08 p.m. UTC | #2 
On Wed, 24 Jan 2024 18:00:00 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 24/01/2024 17:46, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Company name in compatible description appears twice, which is not really
> > helpful, so remove it from product name.
> 
> It's just a string. There is no bug, at least you did not describe where
> the bug is.

Hi Krzysztof,
in fact the fix is based on comments you made in a
review for another board that I submitted:

https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/

------------------
Company name appears twice, which is not really helpful. What's the true
name? Gateway EVK? Then keep only this.
-----------------

> This has probably little impact on user-space, but there could be such
> which actually reads compatibles and depends on them. Or bootloader or
> whatever. Therefore to me such cosmetic change of correct compatible is
> not worth ABI impact.

Yes, normally you would be right, but in this specific case, the board
is a prototype developped by my company and we are still at the
prototype stage, so there is zero ABI impact.

Maybe I can add this to the cover letter if you want me to submit a V3.

Hugo Villeneuve
Krzysztof Kozlowski Jan. 24, 2024, 5:13 p.m. UTC | #3 
On 24/01/2024 18:08, Hugo Villeneuve wrote:
> On Wed, 24 Jan 2024 18:00:00 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 24/01/2024 17:46, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> Company name in compatible description appears twice, which is not really
>>> helpful, so remove it from product name.
>>
>> It's just a string. There is no bug, at least you did not describe where
>> the bug is.
> 
> Hi Krzysztof,
> in fact the fix is based on comments you made in a
> review for another board that I submitted:
> 
> https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/
> 
> ------------------
> Company name appears twice, which is not really helpful. What's the true
> name? Gateway EVK? Then keep only this.

You are mixing arguments. You want to change released compatible based
on style comment. Style comments are reasonable comments for compatibles
while they are patches. Not released commits.

> ----------------- 
> 
>> This has probably little impact on user-space, but there could be such
>> which actually reads compatibles and depends on them. Or bootloader or
>> whatever. Therefore to me such cosmetic change of correct compatible is
>> not worth ABI impact.
> 
> Yes, normally you would be right, but in this specific case, the board
> is a prototype developped by my company and we are still at the
> prototype stage, so there is zero ABI impact.
> 
> Maybe I can add this to the cover letter if you want me to submit a V3.

Any explanation and possible ABI impact should be in commit msg.

Anyway, one patchset per day, so people have chance to respond...

Best regards,
Krzysztof