mbox series

[net-next,0/3] Dynamically allocate BPIDs

Message ID 20240124055014.32694-1-gakula@marvell.com
Headers
Series Dynamically allocate BPIDs |

Message

Geetha sowjanya Jan. 24, 2024, 5:50 a.m. UTC 
  Current hw support 512 backpressure(BP) Ids. These BPIDs are
statically reserved among 4 interface types based on number
of channels supported. Latest HW support configuring
multiple BPIDs per channel. To support this feature, the
patch set creates BPIDs free pool from the BPIDs reserved for
LBK channel as, LBK uses single BPIDs across multiple channels
and on request it dynamically allocates N number of bpids
from the free pool. This patch also reworks the LBK device id
checks.

Geetha sowjanya (3):
  octeontx2-af: Create BPIDs free pool
  octeontx2-af: Add mbox to alloc/free BPIDs
  octeontx2-af: Cleanup loopback device checks

 .../ethernet/marvell/octeontx2/af/common.h    |   1 +
 .../net/ethernet/marvell/octeontx2/af/mbox.h  |  32 ++
 .../net/ethernet/marvell/octeontx2/af/rvu.c   |  14 +-
 .../net/ethernet/marvell/octeontx2/af/rvu.h   |  21 +-
 .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 387 +++++++++++++++---
 .../ethernet/marvell/octeontx2/af/rvu_npc.c   |   8 +-
 .../ethernet/marvell/octeontx2/af/rvu_sdp.c   |   6 +-
 7 files changed, 404 insertions(+), 65 deletions(-)

Comments

Jakub Kicinski Jan. 26, 2024, 2:16 a.m. UTC | #1 
On Wed, 24 Jan 2024 11:20:11 +0530 Geetha sowjanya wrote:
> Current hw support 512 backpressure(BP) Ids. These BPIDs are
> statically reserved among 4 interface types based on number
> of channels supported. Latest HW support configuring
> multiple BPIDs per channel. To support this feature, the
> patch set creates BPIDs free pool from the BPIDs reserved for
> LBK channel as, LBK uses single BPIDs across multiple channels
> and on request it dynamically allocates N number of bpids
> from the free pool. This patch also reworks the LBK device id
> checks.

I looked at this for 20 min, I don't understand how this fits together.
Please improve the commit messages to also explain the functionality
and how user interacts with the features.
Geetha sowjanya Jan. 26, 2024, 9:54 a.m. UTC | #2 
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, January 26, 2024 7:47 AM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXT] Re: [net-next PATCH 0/3] Dynamically allocate BPIDs
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, 24 Jan 2024 11:20:11 +0530 Geetha sowjanya wrote:
> > Current hw support 512 backpressure(BP) Ids. These BPIDs are
> > statically reserved among 4 interface types based on number of
> > channels supported. Latest HW support configuring multiple BPIDs per
> > channel. To support this feature, the patch set creates BPIDs free
> > pool from the BPIDs reserved for LBK channel as, LBK uses single BPIDs
> > across multiple channels and on request it dynamically allocates N
> > number of bpids from the free pool. This patch also reworks the LBK
> > device id checks.
> 
> I looked at this for 20 min, I don't understand how this fits together.
> Please improve the commit messages to also explain the functionality and
> how user interacts with the features.

Will rework on the commit message and submit v2.