From patchwork Tue Jan 23 09:03:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiezhu Yang X-Patchwork-Id: 19308 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp206075dyi; Tue, 23 Jan 2024 01:04:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUab0j0oZFWD2Vzriy1VTcewCvDO/oiS6R+Y9NkDMMY3XsXtmld5DVdQs6QeMOxbDzorKA X-Received: by 2002:a19:9154:0:b0:510:5b0:6cbf with SMTP id y20-20020a199154000000b0051005b06cbfmr345185lfj.92.1706000679890; Tue, 23 Jan 2024 01:04:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706000679; cv=pass; d=google.com; s=arc-20160816; b=OhmqjF8tm7YHCJ7S89ZoD25O3dt0WBcg7UpM8WxnRG+ZxoZT200gAtoSVm51VoQdHy rTo4bIozEN2FV8vGSYHvwYNJtGQnlsBv61birwsPpfRAs81GdhYKv0VIXjGCgrRQMu39 QOQzqkGM505KCCWlfXIAl1i9WwzHn0lrbRsxpoW51E7sJmgYNLteOZ56ZgHiScYZmkZd GHMqDWExAfuPxg5QHpEQBWPTHvreSdbluBN5VO7J3jwTtZYmG4HRQ00Jk6P7raWON+qC 6VNa1/zARhd3VUF+BTFJpLMYn1mXxYWSj6Jl+cuUD0tyGhp2KGeKD8LT8HufKf8PdQT+ eTlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=a8TNjhy/43Sf6wKsqYfvttC3ncgWEvoeXwOIPpyKzlI=; fh=EvR41b01nAjTv94pCV1QdzfpeHL6jIcxejUnN6KALZM=; b=XWLaf/a3dTr6uCvVJu0Zh4lTnh4uz09vhe+O/ENcSV+tSmFy7MBCCU3vQ5D8laMIQ+ EOpXEZpqIA98yeGs3r5UUxeWjiWEyHQG2T2tFyBn+W9XyB+lsMfiHWqgYmMmJ0JjJN2C URcaHGzcE41+Z2p3s4Wt3bJxPo6m3abI0aqf+GvfwTKvVjuVIpam7i4BW3gxJNR+Wq/1 KJT5G8IW0tRc3BM/xTCsXnqFh9piy48SQHdLrapav+18DfME6dw73wPUQ6GFA7GN4qGD tJUnQPjzrFpv4bMVtKkrL0sa4gbj2R+hF12c/vkUOMzri0no2FrTs6e/K3Q0K5rRKitp tE3w== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=loongson.cn); spf=pass (google.com: domain of linux-kernel+bounces-34962-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34962-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i16-20020a17090639d000b00a235f0a36c0si11565387eje.1020.2024.01.23.01.04.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 01:04:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34962-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=loongson.cn); spf=pass (google.com: domain of linux-kernel+bounces-34962-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34962-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 600551F22513 for ; Tue, 23 Jan 2024 09:04:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 94D5C58ABE; Tue, 23 Jan 2024 09:04:05 +0000 (UTC) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C749358116; Tue, 23 Jan 2024 09:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706000644; cv=none; b=Tic86pgEViSNjsVb2TySVGOWzY7kNn4ELbs+5nU6ZnjW/QN9s2Wx/dJG7Uo2W0WVTAHYBJf0joVD+Ja5O1fpQgRt9OdRzHl30QoApSWbWqtEOfvX+/mNG1SAKtWTht6Y6HL8G9QD0DccP4zSg3uhm5dOWJ+nUNhqdDV0Inf+ZV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706000644; c=relaxed/simple; bh=sPZPZpNxCGkjFUXcoESBmSmINqAhV9ErBwBK6gLZhc8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RXt0eb015Omhl8nhgNHoV1p27zr04yHd0GWlAiN8R6Z9qQ3aboz8I+SF0JNPSHBJV2wZ9vBxLdin9gscR8Q9qyPnCAT6oCQ6/aQDsF04yr1wqwYj3dxiXFpf+mY1i0HAWFKda++P7LiwU80RU2GhEP1ZEvAr+eeoQfxzyEP9Ez0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8BxuvD5gK9lOxYEAA--.16509S3; Tue, 23 Jan 2024 17:03:53 +0800 (CST) Received: from linux.localdomain (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxLs_4gK9lWhMUAA--.24458S2; Tue, 23 Jan 2024 17:03:52 +0800 (CST) From: Tiezhu Yang To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Eduard Zingerman , John Fastabend , Jiri Olsa , Hou Tao , Song Liu , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v7 0/2] Skip callback tests if jit is disabled in test_verifier Date: Tue, 23 Jan 2024 17:03:49 +0800 Message-ID: <20240123090351.2207-1-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: AQAAf8BxLs_4gK9lWhMUAA--.24458S2 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7ZFykWF4rtrWkuF1xCF1fXwc_yoW8Jw1kpa 93GwnIgr1rJF1IqF13ArsFqFWSqr4kW3y5Jw17Xr95Ja15AFyxArWfKF10qas8KrWrXr4a y3WIvFyF9F10q3cCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Gb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj64x0Y40En7xvr7AKxVWUJVW8JwAv7VC0I7IY x2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4 x0Y48IcxkI7VAKI48JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC20s02 6xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_Jr I_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v2 6r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj4 0_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8 JrUvcSsGvfC2KfnxnUUI43ZEXa7IU0n2-5UUUUU== X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788871368746073931 X-GMAIL-MSGID: 1788871368746073931 Thanks very much for the feedbacks from Eduard, John, Jiri, Daniel, Hou Tao, Song Liu and Andrii. v7: -- Add an explicit flag F_NEEDS_JIT_ENABLED for checking, thanks Andrii. v6: -- Copy insn_is_pseudo_func() into testing_helpers, thanks Andrii. v5: -- Reuse is_ldimm64_insn() and insn_is_pseudo_func(), thanks Song Liu. v4: -- Move the not-allowed-checking into "if (expected_ret ...)" block, thanks Hou Tao. -- Do some small changes to avoid checkpatch warning about "line length exceeds 100 columns". v3: -- Rebase on the latest bpf-next tree. -- Address the review comments by Hou Tao, remove the second argument "0" of open(), check only once whether jit is disabled, check fd_prog, saved_errno and jit_disabled to skip. Tiezhu Yang (2): selftests/bpf: Move is_jit_enabled() into testing_helpers selftests/bpf: Skip callback tests if jit is disabled in test_verifier tools/testing/selftests/bpf/test_progs.c | 18 ------------------ tools/testing/selftests/bpf/test_verifier.c | 11 +++++++++++ tools/testing/selftests/bpf/testing_helpers.c | 18 ++++++++++++++++++ tools/testing/selftests/bpf/testing_helpers.h | 1 + .../selftests/bpf/verifier/bpf_loop_inline.c | 6 ++++++ 5 files changed, 36 insertions(+), 18 deletions(-)