From patchwork Tue Jan 23 05:45:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 19298 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp137776dyi; Mon, 22 Jan 2024 21:46:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNdYQcP/JKd4oUmCMBIvBnPbd3EH3Eb5MteCeOEONLZRQuYk5kLsiJTixqYbguau0yv9oR X-Received: by 2002:a92:c743:0:b0:360:8554:bc80 with SMTP id y3-20020a92c743000000b003608554bc80mr7486490ilp.39.1705988809338; Mon, 22 Jan 2024 21:46:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705988809; cv=pass; d=google.com; s=arc-20160816; b=Gcn0Nwo4TfzVL52ZMCvR1BoxjiWz09UDVkNaoj/JMX7KRHBJnfZKZCSxXj+0I0/m5u xbN8QF9OLJdem0LsEDSg5v/6gxjkj6+EY7rp5oJMIVXymW2D6HZVoRoUX/7OVS+XhdLT cW5trgQx104JUtw6a+dfG2FQ+OalU9nrmzWZtCIZA4/K8lPAnoBDE/yflFN8Jk1QEm81 F+gd3sLoqjBNZIymjQb5+cmPiQd/Q8oPr6M4molcPJuvSq7WP21XB/wrjEa/2pgUArGD q7dOTwUWQpVTkAqK8LdqPrYbRkRxVQT35MNeY+K/3TeN+fJJ+lK9AFzGoZRujXUBQYl7 fvHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=QKqLKNL5V/BaZEjU093ArrhMOgcjsnmPe1vwzOztNuA=; fh=78ZiYAsMqkMiOIWlhjjSgWn2SS9khyeUqw/r/4rUn1M=; b=fsy7X6HqNJTmWISaFuha7ASfUxc6/Tt69a9Ow+ujutgBgyYo/upwduXqUc5w+B2k0y JhcEl1Szf90dTU1TpuqVdjT/hVm+3XzJAkebUSJrZ17gupMemHJkXbgKd4gWiX0u4u8Y 1/cmEXTcAp1TpJWVHi/5GI0dOrHm48seRKKY5UX4M+AbZcokds+3ZWM8vaBuM9jTvFzB XrXg9jJKpaa5i2XN+weHGuXin9fPdMx8kj0my7890r97TXyjCIZCgENHXBfkkno1heh1 h2l9vhnqyefHd64wI7Wd0VflJLc58/1SCXSN4VPnFyV1MXHDyECsS2Oe2TXfgyEgZMZS bjIA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-34732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34732-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y6-20020a63ce06000000b005cdfc019324si9142364pgf.629.2024.01.22.21.46.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 21:46:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-34732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34732-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1B5DD28182B for ; Tue, 23 Jan 2024 05:46:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADA094C7E; Tue, 23 Jan 2024 05:46:32 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 495D95225; Tue, 23 Jan 2024 05:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705988791; cv=none; b=jozp6N31wgzdsBVVspz+tGwxQHKVchIFI7YumogMKUjxo3wNeX/fyy3yJ3Z+yPHFXP2U59FF4r0bX1C2PM9s/bB9wDoJaBOSXww8rWUTFVNt6SvdALjGEXjakZuU1EFOkgapfV7Ng/UPRl4PMkKZfjrBFPodmDUqm/xpe5dRW8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705988791; c=relaxed/simple; bh=I5/7kgG0RHIfM6JTMemznuMv1VkSOat4HzAutMg0TrU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uZWvDPeeQHQDI05bRnZ3chTSzArYfT9WR/D0+rf2oFTkmm5P+wdOjabHR03o7rEethhiJGSYfqU9o9cg+NN2irsizZVRSgbIaPVyXpII42rxM4xSAHeheZVgRDXh0P5KxtuAKfgfxDgdKUYzQwBju6AuYFu1O08Iov6+R09xl8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB5D51FB; Mon, 22 Jan 2024 21:47:12 -0800 (PST) Received: from a077893.arm.com (unknown [10.163.40.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8CBB63F762; Mon, 22 Jan 2024 21:46:22 -0800 (PST) From: Anshuman Khandual To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Anshuman Khandual , Lorenzo Pieralisi , Sudeep Holla , Mike Leach , James Clark , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH V4 00/11] coresight: Move remaining AMBA ACPI devices into platform driver Date: Tue, 23 Jan 2024 11:15:57 +0530 Message-Id: <20240123054608.1790189-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788858921975816104 X-GMAIL-MSGID: 1788858921975816104 This moves remaining AMBA ACPI devices into respective platform drivers for enabling ACPI based power management support. This series applies on kernel v6.8-rc1 release. This series has been built, and boot tested on a DT based coresight platform. Although this still requires some more testing on ACPI based coresight platforms. https://git.gitlab.arm.com/linux-arm/linux-anshuman.git (amba_other_acpi_migration_v4) Cc: Lorenzo Pieralisi Cc: Sudeep Holla Cc: Suzuki K Poulose Cc: Mike Leach Cc: James Clark Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: linux-acpi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: coresight@lists.linaro.org Cc: linux-stm32@st-md-mailman.stormreply.com Changes in V4: - Fixed PM imbalance in etm4_probe() error path with pm_runtime_disable() - Restored back the pm_runtime_disable() on platform probe error paths in replicator, funnel, catu, tpiu, tmc and stm devices - Dropped dev_caps argument from __tmc_probe() - Changed xxxx_platform_remove() for platform_driver->remove_new() callback Changes in V3: https://lore.kernel.org/all/20231208053939.42901-1-anshuman.khandual@arm.com/ - Split coresight_init_driver/remove_driver() helpers into a separate patch - Added 'drvdata->pclk' comments in replicator, funnel, tpiu, tmc, and stm devices - Updated funnel, and replicator drivers to use these new helpers - Check for drvdata instead of drvdata->pclk in suspend and resume paths in catu, tmc and debug devices - Added patch to extract device name from AMBA pid based table lookup for stm - Added patch to extract device properties from AMBA pid based table look for tmc - Dropped pm_runtime_put() from common __probe() functions - Handled pm_runtime_put() in AMBA driver in success path - Handled pm_runtime_put() in platform driver in both success and error paths Changes in V2: https://lore.kernel.org/all/20231201062053.1268492-1-anshuman.khandual@arm.com/ - Dropped redundant devm_ioremap_resource() hunk from tmc_platform_probe() - Defined coresight_[init|remove]_driver() for both AMBA/platform drivers - Changed catu, tmc, tpiu, stm and debug coresight drivers to use the new helpers avoiding build issues arising from module_amba_driver(), and module_platform_driver() being on the same file Changes in V1: https://lore.kernel.org/all/20231027072943.3418997-1-anshuman.khandual@arm.com/ - Replaced all IS_ERR() instances with IS_ERR_OR_NULL() as per Suzuki Changes in RFC: https://lore.kernel.org/all/20230921042040.1334641-1-anshuman.khandual@arm.com/ Anshuman Khandual (11): coresight: etm4x: Fix unbalanced pm_runtime_enable() coresight: stm: Extract device name from AMBA pid based table lookup coresight: tmc: Extract device properties from AMBA pid based table lookup coresight: Add helpers registering/removing both AMBA and platform drivers coresight: replicator: Move ACPI support from AMBA driver to platform driver coresight: funnel: Move ACPI support from AMBA driver to platform driver coresight: catu: Move ACPI support from AMBA driver to platform driver coresight: tpiu: Move ACPI support from AMBA driver to platform driver coresight: tmc: Move ACPI support from AMBA driver to platform driver coresight: stm: Move ACPI support from AMBA driver to platform driver coresight: debug: Move ACPI support from AMBA driver to platform driver drivers/acpi/arm64/amba.c | 8 - drivers/hwtracing/coresight/coresight-catu.c | 142 +++++++++++++--- drivers/hwtracing/coresight/coresight-catu.h | 1 + drivers/hwtracing/coresight/coresight-core.c | 29 ++++ .../hwtracing/coresight/coresight-cpu-debug.c | 141 ++++++++++++++-- .../coresight/coresight-etm4x-core.c | 3 + .../hwtracing/coresight/coresight-funnel.c | 86 +++++----- drivers/hwtracing/coresight/coresight-priv.h | 10 ++ .../coresight/coresight-replicator.c | 81 ++++----- drivers/hwtracing/coresight/coresight-stm.c | 117 +++++++++++-- .../hwtracing/coresight/coresight-tmc-core.c | 158 +++++++++++++++--- drivers/hwtracing/coresight/coresight-tmc.h | 2 + drivers/hwtracing/coresight/coresight-tpiu.c | 102 +++++++++-- include/linux/coresight.h | 7 + 14 files changed, 726 insertions(+), 161 deletions(-) Reviewed-by: James Clark