From patchwork Thu Jan 18 12:39:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang Li X-Patchwork-Id: 19148 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp308556dyb; Thu, 18 Jan 2024 04:39:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgMDYhX0N6Y8NDb4ynsrp2oOIw8KUsU+u5yCpW6SlwZPyDRy27b8RDIR4q7tSjV99x6HyA X-Received: by 2002:a05:6a00:3d12:b0:6db:b004:df2c with SMTP id lo18-20020a056a003d1200b006dbb004df2cmr285473pfb.62.1705581582363; Thu, 18 Jan 2024 04:39:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705581582; cv=pass; d=google.com; s=arc-20160816; b=qcm1AAj5Fn+jc28o7/hopgxxQCgvzVcDsxZhB52nJTQEylmP7ENUGWD1ZUEXD4R58n j6XyakqDWq3cfMQERlS/2rfZSA5rRW500UGxX4eB6rIrNoReqBa2QL16miZglQBbtHLf afz+XyHsMW1befPHGKouLY6guHJ4J6ARp8Y0nt8bWmTwCiDREZpsAs5T98ZcOwBNq2o+ l94Xkk2+yWoLkE+MW8U3h8N0PuEdAdaU8z23u3y5mG9hrx+LV6qST+E5OWBJCnvF3AyS Z5V40NQGoYafSwfoYqIc7Q43xaoSqYgNPm0/CVz58qk7nisxmfrYnFI+vF3SZjm14xvU yMGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=mt7uxPpjB752dElB/c3PRb1FTXGnRTlS8CZOndsR1VE=; fh=5n5b5+XOwLgGNDePhvfXysty56rnkWOs9jaHEODdVeE=; b=sGEbqOgYMpKzVGbaBaQ0XYvC3cJhX1OId+WiluKj3WwYhXCGi0JyZqz9xfizu2Vvmv pqcKrf/d7h6uVuUZ5aeMBLsqWQKdwCIDqolHhOLGOvJkUDXhBf4BvUwE32Gr3TnUsXsO egjJsNCx6/neop1FBguGUj/E7U23c+hfjkNJImZt6qRlDvCvTp77Dvn+xcc+eh8tzWRV ionXThqgY7/16LYJP1RSbnJ582DXUHIgek7jZLZZdG7Mg8kCFpW8YRVAwvXUk7TS3HkC EzF56VjLaAw6Zpj/i12llDjCQi9XjcknUJ/2laYe/Q4h1ti7uCSbUkx78RSoESd/xwfo uWWg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=U90JDt6u; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-30103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30103-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jo22-20020a056a00909600b006d977044e1bsi3640164pfb.194.2024.01.18.04.39.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 04:39:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=U90JDt6u; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-30103-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30103-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1B4ED2833D2 for ; Thu, 18 Jan 2024 12:39:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC6E1250E7; Thu, 18 Jan 2024 12:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="U90JDt6u" Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0857B241E2 for ; Thu, 18 Jan 2024 12:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705581564; cv=none; b=HHDrmyL0nwjXPm29buMwKIVOqtUl43lH02trjJSsjN08yVXjmBg4eBm/J3Ct/UkdBm8TOrhu3KUJLEwDQIxz5N6gp6TqMI4V8/xbbqTzujkwH0xlZe/igK3NnFh2R0hPwPn4M900Uv12wzn30SDAH3Sc+OYteKTivoelmx28x8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705581564; c=relaxed/simple; bh=R88BGQmeXi+e8/gGkWi1S7NdUauJXiQ4A5xn7fXMZF0=; h=X-Report-Abuse:DKIM-Signature:From:To:Cc:Subject:Date:Message-Id: MIME-Version:Content-Transfer-Encoding:X-Migadu-Flow; b=DF9BNaWQP8TTDUCq36VZOGgjDwirp4F/+YO1PfVNdqzBuItV4ybgkYMtLuIG/Y2CM0vTffBA4TOo5gfVk1XlYP2RuY7O28d4IqBzbDPGjwWNCUKB2F0d3/8G99IZQ2I0bTPGaqRnIVSslrJVxaTCrLrTHqH6oEc0cUpBFvWwbJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=U90JDt6u; arc=none smtp.client-ip=95.215.58.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705581560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mt7uxPpjB752dElB/c3PRb1FTXGnRTlS8CZOndsR1VE=; b=U90JDt6ucUwcrDktw242XqJWfIO/nYOyVq/b3qXuPddYIIP2Lh2AZhHzkoMomBPDQxqr0K 2ofMqd9Y0luwEz6RLuSjEs67WXf9rmwzE7wCBqMaSgpbGS9WFFWkzGCM2zdZ31uqhx0HJn vgw+XVn9ExdETDheQciWjv2wvDsWoS8= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [RESEND PATCH v4 0/7] hugetlb: parallelize hugetlb page init on boot Date: Thu, 18 Jan 2024 20:39:04 +0800 Message-Id: <20240118123911.88833-1-gang.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788431913525769202 X-GMAIL-MSGID: 1788431913525769202 Hi all, hugetlb init parallelization has now been updated to v4. This version is tested on next-20240112. Update Summary: - Make padata_do_multithreaded dispatch all jobs with a global iterator - Revise commit message - Rename some functions - Collect Tested-by and Reviewed-by # Introduction Hugetlb initialization during boot takes up a considerable amount of time. For instance, on a 2TB system, initializing 1,800 1GB huge pages takes 1-2 seconds out of 10 seconds. Initializing 11,776 1GB pages on a 12TB Intel host takes more than 1 minute[1]. This is a noteworthy figure. Inspired by [2] and [3], hugetlb initialization can also be accelerated through parallelization. Kernel already has infrastructure like padata_do_multithreaded, this patch uses it to achieve effective results by minimal modifications. [1] https://lore.kernel.org/all/783f8bac-55b8-5b95-eb6a-11a583675000@google.com/ [2] https://lore.kernel.org/all/20200527173608.2885243-1-daniel.m.jordan@oracle.com/ [3] https://lore.kernel.org/all/20230906112605.2286994-1-usama.arif@bytedance.com/ [4] https://lore.kernel.org/all/76becfc1-e609-e3e8-2966-4053143170b6@google.com/ # Test result test no patch(ms) patched(ms) saved ------------------- -------------- ------------- -------- 256c2t(4 node) 1G 4745 2024 57.34% 128c1t(2 node) 1G 3358 1712 49.02% 12t 1G 77000 18300 76.23% 256c2t(4 node) 2M 3336 1051 68.52% 128c1t(2 node) 2M 1943 716 63.15% # Change log Changes in v4: - Make padata_do_multithreaded dispatch all jobs with a global iterator - Revise commit message - Rename some functions - Collect Tested-by and Reviewed-by Changes in v3: - https://lore.kernel.org/all/20240102131249.76622-1-gang.li@linux.dev/ - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Changes in v2: - https://lore.kernel.org/all/20231208025240.4744-1-gang.li@linux.dev/ - Reduce complexity with `padata_do_multithreaded` - Support 1G hugetlb v1: - https://lore.kernel.org/all/20231123133036.68540-1-gang.li@linux.dev/ - parallelize 2M hugetlb initialization with workqueue Gang Li (7): hugetlb: code clean for hugetlb_hstate_alloc_pages hugetlb: split hugetlb_hstate_alloc_pages padata: dispatch works on different nodes hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA hugetlb: parallelize 2M hugetlb allocation and initialization hugetlb: parallelize 1G hugetlb initialization fs/Kconfig | 1 + include/linux/hugetlb.h | 2 +- include/linux/padata.h | 3 + kernel/padata.c | 14 ++- mm/hugetlb.c | 227 ++++++++++++++++++++++++++-------------- mm/mm_init.c | 1 + 6 files changed, 168 insertions(+), 80 deletions(-)