Message ID | 20240117-coreboot-mod-defconfig-v3-0-049565a27bba@collabora.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:30f:b0:101:a8e8:374 with SMTP id ia15csp120800dyb; Wed, 17 Jan 2024 11:06:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgwuRvVcXDoa04hXTljn58tWEgbYbXvqqXWoRqRxyQ7T8PiA3NlcbmbKfnjV5KGylQPgxt X-Received: by 2002:a05:6214:76f:b0:67f:161a:1ddf with SMTP id f15-20020a056214076f00b0067f161a1ddfmr1849740qvz.33.1705518378643; Wed, 17 Jan 2024 11:06:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705518378; cv=pass; d=google.com; s=arc-20160816; b=xZymUvZ3uF2z4NBnhRXYQIHUNt9ItFIBE2TJyq8oCfFiFj9nEbMxeOk3UxdSCCrEjt vSmiO4fUpIrlct1ZQm9PoL/9p0R2kBumx7OkIvbiJALZhFyPHMjrra7xzI0eq9ApyQKg KydyY6NFPSCIjlZME07vJ8OlbC6otE/3DlKxzskh3Wp6O1CFgLS8neZhqa4oShHvd/0p gC4Ysdl583yOeBKATu3InYuoT8dHjNfxj5p55rvrgBo5vc11JjziAG48LcFVr6EvesVd hjalWI6IyBSDO95qE6H7UxGWzSTLPLaHtCzww46FgXLxkeoiUJER1oIZTBzjSwkQprEy iliQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=bjlcgWqxRAEbCim49JxvWOv5SPIsQkb5a0ZlYjWytvw=; fh=/gd7Rc/EAAvVxbBCprHskp118QGvW0rBWlLNTh318QE=; b=ZCu45dYFKuR/rHc5sDvDPHEqlaGevOopuIWkaXcCwMwz23GBu6+z+dx8Mfohf6VfD2 8caCekJ6egjMnizWxBvvvmJbJG5/XodyHK/pGAC3UbjTgcXi90SshvPvjQg4ZyLr6VMT 360foCbHAtl6BS70IDdHKbYE1p/V2duNXhwiDz0IVacZEyKFJIGbtXvLifcsgGzaAz9V lGo1np6TSBsj8KLn7ze67UHTyu87L+RIyO0s1HqkJDl6b12N4dtVQYc3kXTzK48qL3Iw coxPQ3sdDhFGt1mZUVMt6IotHw63hfj4kf+/S8DOZxj6YLMqQCCVGxohz2qjBvj8H/L5 FhhA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=zwEWMCFd; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m13-20020a0cdb8d000000b006816f4917b2si3344575qvk.615.2024.01.17.11.06.18 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 11:06:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=zwEWMCFd; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29345-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 003121C24247 for <ouuuleilei@gmail.com>; Wed, 17 Jan 2024 19:06:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D244724A0E; Wed, 17 Jan 2024 19:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="zwEWMCFd" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED919241E0; Wed, 17 Jan 2024 19:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705518351; cv=none; b=BtQOJFXf/ZVfLqC3Ks/vmUqje5bQR3i1UabLkNS0Tk00EP9BHEfwdx/D2PsaGwWDdHYpAeAFxcSGVmrCbexU7jBi9Ai7xbymQxHlqJhgQcruqMlvXkyZSvRhP4rmBFhsBZm8x4pcZS+4trUX9BdgUSkh2E26wnOz9nbFNP0Cqgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705518351; c=relaxed/simple; bh=2p7PxDeWr9PiIww3WFCI2erGr5A6HQLNiCFMet8yz3w=; h=DKIM-Signature:Received:From:Subject:Date:Message-Id:MIME-Version: Content-Type:Content-Transfer-Encoding:X-B4-Tracking:To:Cc: X-Mailer; b=ZKhlHF9FT3JOGEnl1L5FxfvlyDT22w/kbWy8cPqpZYQRV8zPbpwBP9v8G4MUcXCwwKkjzSfJ1cw3rLILiqrmapCnDYRM5BvoDyqPLriu1vuJmxJ5FJI7+eXd7Gvrgl3f2J52d3pPe1iLiI81+aVkXr/bSJ+7iS+W7T3wo3VAGfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=zwEWMCFd; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705518347; bh=2p7PxDeWr9PiIww3WFCI2erGr5A6HQLNiCFMet8yz3w=; h=From:Subject:Date:To:Cc:From; b=zwEWMCFd4TnrY+iOA9adVVxxZGPSNRHRA3y3ik9rtmousM99awysSOVuMa+oglkZB 76PH+dJ6m0/7dtZLEUKVL+Gyul2auVmolGUKia6dZxHLLzmQ2gaeIqE/R9pf67FE0C JTEzCQp03C4lBo3ci9BqULZhkRg1xIxuKYjmxj88ZeCGYpDHJyfW0Loiu0f1r1xFFD kiGALPZtSLVQNDoaBCuMuNYriRuqlmjn7cs5L0JPShDdYmJw9x3LnaSrXEZO4tSFgi aqEKc1m8uBzskyfJvd8Nw8BVYbS9ujH7+y8a1r72R54ORsdrLwNhbr/rAy7sp9g8QD dC5O1//+04ZnQ== Received: from [192.168.0.47] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BD792378000E; Wed, 17 Jan 2024 19:05:41 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> Subject: [PATCH v3 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig Date: Wed, 17 Jan 2024 16:03:21 -0300 Message-Id: <20240117-coreboot-mod-defconfig-v3-0-049565a27bba@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAHkkqGUC/x3MPQvCMBCA4b9SbjaljcWvSSfnIghWHNrk0h40O b1UEUr/u8HxGd53hohCGOGQzSD4oUgcEtarDMzQhh4V2WTQha6Kstwqw4Id86Q8W2XRGQ6OerX Tm64oUVfa7iHFT0FH3//4/kh2wl5Ng2D73zVtfb2YWp9ur/dZNXKMnkbMHeUUJhxzwx6W5Qehc 0D8ngAAAA== To: Tzung-Bi Shih <tzungbi@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de>, Brian Norris <briannorris@chromium.org>, Julius Werner <jwerner@chromium.org>, Masahiro Yamada <masahiroy@kernel.org>, Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, kernel@collabora.com, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> X-Mailer: b4 0.12.4 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788365639572616878 X-GMAIL-MSGID: 1788365639572616878 |
Series |
Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig
|
|
Message
Nícolas F. R. A. Prado
Jan. 17, 2024, 7:03 p.m. UTC
This series adds the missing pieces to the coreboot bus and the module alias generation to allow coreboot modules to be automatically loaded when matching devices are detected. The configs for cbmem coreboot entries are then enabled in the arm64 defconfig, as modules, to allow reading logs from coreboot on arm64 Chromebooks, which is useful for debugging the boot process. Changes in v3: - Merged all "add to module device table" commits into a single commit which also changes the coreboot_driver struct to contain an id table and avoid unused variable warnings for the id tables. Changes in v2: - Added commits for vpd, memconsole and framebuffer drivers to add them to the module device table --- Nícolas F. R. A. Prado (4): firmware: coreboot: Generate modalias uevent for devices firmware: coreboot: Generate aliases for coreboot modules firmware: coreboot: Replace tag with id table in driver struct arm64: defconfig: Enable support for cbmem entries in the coreboot table arch/arm64/configs/defconfig | 3 +++ drivers/firmware/google/cbmem.c | 8 +++++++- drivers/firmware/google/coreboot_table.c | 20 +++++++++++++++++++- drivers/firmware/google/coreboot_table.h | 3 ++- drivers/firmware/google/framebuffer-coreboot.c | 8 +++++++- drivers/firmware/google/memconsole-coreboot.c | 8 +++++++- drivers/firmware/google/vpd.c | 8 +++++++- include/linux/mod_devicetable.h | 8 ++++++++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 10 ++++++++++ 10 files changed, 73 insertions(+), 6 deletions(-) --- base-commit: 0f067394dd3b2af3263339cf7183bdb6ee0ac1f8 change-id: 20240117-coreboot-mod-defconfig-826b01e242d9 Best regards,
Comments
On Wed, Jan 17, 2024 at 04:03:21PM -0300, Nícolas F. R. A. Prado wrote: > This series adds the missing pieces to the coreboot bus and the module > alias generation to allow coreboot modules to be automatically loaded > when matching devices are detected. > > The configs for cbmem coreboot entries are then enabled in the arm64 > defconfig, as modules, to allow reading logs from coreboot on arm64 > Chromebooks, which is useful for debugging the boot process. > > Changes in v3: > - Merged all "add to module device table" commits into a single commit > which also changes the coreboot_driver struct to contain an id table > and avoid unused variable warnings for the id tables. > > Changes in v2: > - Added commits for vpd, memconsole and framebuffer drivers to add them > to the module device table > > --- > Nícolas F. R. A. Prado (4): > firmware: coreboot: Generate modalias uevent for devices > firmware: coreboot: Generate aliases for coreboot modules > firmware: coreboot: Replace tag with id table in driver struct > arm64: defconfig: Enable support for cbmem entries in the coreboot table The series overall looks good to me. I'm happy to queue all the patches into chrome-platform-firmware for the next merge window (i.e. for v6.9-rc1). Let's wait a bit for the maintainers for the other subsystems if they are OK with that.
On Wed, Jan 17, 2024 at 04:03:21PM -0300, Nícolas F. R. A. Prado wrote: > This series adds the missing pieces to the coreboot bus and the module > alias generation to allow coreboot modules to be automatically loaded > when matching devices are detected. > > The configs for cbmem coreboot entries are then enabled in the arm64 > defconfig, as modules, to allow reading logs from coreboot on arm64 > Chromebooks, which is useful for debugging the boot process. > > Changes in v3: > - Merged all "add to module device table" commits into a single commit > which also changes the coreboot_driver struct to contain an id table > and avoid unused variable warnings for the id tables. > > Changes in v2: > - Added commits for vpd, memconsole and framebuffer drivers to add them > to the module device table For the series: Reviewed-by: Brian Norris <briannorris@chromium.org> Thanks!