Message ID | 20240109-gunyah-v16-0-634904bf4ce9@quicinc.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp341805dyi; Tue, 9 Jan 2024 11:42:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEsfBEpFyfjPZeCUtZ8PzfyPLdtf+h3FaEJnaz+TgaZpysFFAkwhhjpW155LcP/uyErgtf X-Received: by 2002:a05:6a21:150d:b0:199:81a3:847 with SMTP id nq13-20020a056a21150d00b0019981a30847mr3734695pzb.57.1704829319767; Tue, 09 Jan 2024 11:41:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704829319; cv=none; d=google.com; s=arc-20160816; b=orH8xc6mnCmHFmdXsH3WCZUB6KZC4Wcain0Cn9igpbtVSeVHB/ZKoO0EIxEwr8ZrZ1 RNtmKJvaHgN3ZYO4xoHPWDgAPXAuGvFn0dNvSmfR1on39TeP24QDVs12aBz5qmKAnmdP wzl3+Pn98pxaE3XEgYpjJrEQlI8OHWXLXuEa7Nfmxd9OgQaXn55a0RLH9CjUM8o7mG0t JvSAQLVGvlf+bQThg8XGf1oF1Lzd2iDAu0JjiuOxWKt/43Z1eCcRZYFdXY/aXf4KzIQG 0P/kf3vm92BA8Ojakffe1T2f/3BehBAXbDFJcNw3CwvVA5AzcYGk+6GTarb7gVKyGecr BTNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=7ug5TU7F82LcNwQtTVSfS75VgpnhLh5FKpuomjGLO1I=; fh=7zGUZI8o+faw/EP23+TMfHconvCe6/i99ctwc9fzJrw=; b=Rxm+sKxpSaSqnUrvLZI8XKtByeHPSzbitpDiy9ERY1lEfKeLqLcv0fWQjnyFOQUks1 EedOaD9rXKdggfS0evqUBW81R5Z1KKOb/VaezSK4rb18/9k5PYOK++k8vyijpLJ2QeHr /8mY6o5bInK0QGN6+0y/rl9IHgXqCpvC+UUTXMI0mFmqgLqD2NzxXFsLNnMJTEEeDGgM X27vZB/i65HDEaW9fgYLCYf+/X8dksWUJIcFCNUzoFQgTU2jNXdov90BwOGXo7y40pFh mZ2597ElfpTs/4k6SDpsRxbAHydRtCAJogjCpcGLZspci3hygUQsq03q0loX5gWfPtEp C0Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GOglusOe; spf=pass (google.com: domain of linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j9-20020a170902690900b001d3c228953fsi1975562plk.392.2024.01.09.11.41.59 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 11:41:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GOglusOe; spf=pass (google.com: domain of linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21330-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 75D35283F8F for <ouuuleilei@gmail.com>; Tue, 9 Jan 2024 19:41:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2476C40BF0; Tue, 9 Jan 2024 19:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="GOglusOe" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D8D53D991; Tue, 9 Jan 2024 19:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 409G7qqM002215; Tue, 9 Jan 2024 19:37:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:subject:date:message-id:mime-version:content-type :content-transfer-encoding:to:cc; s=qcppdkim1; bh=7ug5TU7F82LcNw QtTVSfS75VgpnhLh5FKpuomjGLO1I=; b=GOglusOeI3mPOuRrv22CfCC+VQtC/3 G29S7tT+fhWTLwD0ss9EaqQu8ZxBOqFvOqz/COiTuTd7VEj7lKqtsGaCCsm6qUyQ DCJ9+HsuvihQ/sVPA2Szrka51T3oUHOa/piYfXN++tSsHiAvRuLRqoXc2+hMSHij tn316Q0wGLwjlR8yrVEWSdH8hvqyxyBiXZ4FCgO33hBCfHKFU3Ozrnfx8OrQSkbl KZWb9LN39XR6n5vvRaL2W1dna5LDEzPpcIoVqfBT2fretHY82sZ1GpreEb9i3BTp zKKniBcRc+y38v1axQbgXlAB4P6mKDY9aqgcU2DUEzyyqwZFyLVAtHFw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vgwx39w7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 19:37:50 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 409JbnVw024493 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Jan 2024 19:37:49 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 9 Jan 2024 11:37:48 -0800 From: Elliot Berman <quic_eberman@quicinc.com> Subject: [PATCH v16 00/34] Drivers for Gunyah hypervisor Date: Tue, 9 Jan 2024 11:37:38 -0800 Message-ID: <20240109-gunyah-v16-0-634904bf4ce9@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIKgnWUC/zXMQQ7CIBCF4as0sxYDNFDqqvcwXUwollkICraxa bi72Ojy/Xn5dsgukctwaXZIbqVMMdQh9KkB6zHMjtFUA0guWyG5YfMSNvSsVxItdlobx6GeH8n d6H1I17FuT/kV03bAq1Df/DOE+hu1M85EL1FNppPY8uG5kKVgzzbeYSylfAC3psXloQAAAA== To: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Murali Nalajal <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Philip Derrin <quic_pderrin@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, "Fuad Tabba" <tabba@google.com>, Sean Christopherson <seanjc@google.com>, "Andrew Morton" <akpm@linux-foundation.org> CC: <linux-arm-msm@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org>, Elliot Berman <quic_eberman@quicinc.com>, Rob Herring <robh@kernel.org> X-Mailer: b4 0.13-dev X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: q_fpMI9ptxSJbAbW5sMQiF4hkF6NT7se X-Proofpoint-ORIG-GUID: q_fpMI9ptxSJbAbW5sMQiF4hkF6NT7se X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 impostorscore=0 clxscore=1011 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401090158 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787643109177258556 X-GMAIL-MSGID: 1787643109177258556 |
Series |
Drivers for Gunyah hypervisor
|
|
Message
Elliot Berman
Jan. 9, 2024, 7:37 p.m. UTC
Gunyah is a Type-1 hypervisor independent of any high-level OS kernel,
and runs in a higher CPU privilege level. It does not depend on any
lower-privileged OS kernel/code for its core functionality. This
increases its security and can support a much smaller trusted computing
base than a Type-2 hypervisor. Gunyah is designed for isolated virtual
machine use cases and to support launching trusted+isolated virtual
machines from a relatively less trusted host virtual machine.
Gunyah is an open source hypervisor. The source repo is available at
https://github.com/quic/gunyah-hypervisor.
The diagram below shows the architecture for AArch64.
::
VM A VM B
+-----+ +-----+ | +-----+ +-----+ +-----+
| | | | | | | | | | |
EL0 | APP | | APP | | | APP | | APP | | APP |
| | | | | | | | | | |
+-----+ +-----+ | +-----+ +-----+ +-----+
---------------------|-------------------------
+--------------+ | +----------------------+
| | | | |
EL1 | Linux Kernel | | |Linux kernel/Other OS | ...
| | | | |
+--------------+ | +----------------------+
--------hvc/smc------|------hvc/smc------------
+----------------------------------------+
| |
EL2 | Gunyah Hypervisor |
| |
+----------------------------------------+
Gunyah provides these following features.
- Threads and Scheduling: The scheduler schedules virtual CPUs (VCPUs)
on physical CPUs and enables time-sharing of the CPUs.
- Memory Management: Gunyah tracks memory ownership and use of all
memory under its control. It provides low level dynamic memory
management APIs on top of which higher level donation, lending and sharing
is built. Gunyah provides strong VM memory isolation for trusted VMs.
- Interrupt Virtualization: Interrupts are managed by the hypervisor
and are routed directly to the assigned VM.
- Inter-VM Communication: There are several different mechanisms
provided for communicating between VMs.
- Device Virtualization: Para-virtualization of devices is supported
using inter-VM communication and virtio primitives. Low level architecture
features and devices such as cpu timers, interrupt controllers are supported
with hardware virtualization and emulation where required.
- Resource Manager: Gunyah supports a "root" VM that initially owns all
VM memory and IO resources. The Gunyah Resource Manager is the default
bundled root VM and provides high-level services including dynamic VM
management and secure memory donation, lending and sharing.
This series adds the basic framework for detecting that Linux is running
under Gunyah as a virtual machine, communication with the Gunyah
Resource Manager, and a sample virtual machine manager capable of
launching virtual machines.
Changes in v16:
- Fleshed out memory reclaim while VM is running
- Documentation and comments
Changes in v15:
https://lore.kernel.org/r/20231215-gunyah-v15-0-192a5d872a30@quicinc.com
- First implementation of virtual machines backed by guestmemfd and
using demand paging to provide memory instead of all up front.
- Use message queue hypercalls directly instead of traversing through
mailbox framework.
Changes in v14: https://lore.kernel.org/all/20230613172054.3959700-1-quic_eberman@quicinc.com/
- Coding/cosmetic tweaks suggested by Alex
- Mark IRQs as wake-up capable
Changes in v13:
https://lore.kernel.org/all/20230509204801.2824351-1-quic_eberman@quicinc.com/
- Tweaks to message queue driver to address race condition between IRQ
and mailbox registration
- Allow removal of VM functions by function-specific comparison --
specifically to allow
removing irqfd by label only and not requiring original FD to be
provided.
Changes in v12:
https://lore.kernel.org/all/20230424231558.70911-1-quic_eberman@quicinc.com/
- Stylistic/cosmetic tweaks suggested by Alex
- Remove patch "virt: gunyah: Identify hypervisor version" and squash
the
check that we're running under a reasonable Gunyah hypervisor into RM
driver
- Refactor platform hooks into a separate module per suggestion from
Srini
- GFP_KERNEL_ACCOUNT and account_locked_vm() for page pinning
- enum-ify related constants
Changes in v11:
https://lore.kernel.org/all/20230304010632.2127470-1-quic_eberman@quicinc.com/
- Rename struct gh_vm_dtb_config:gpa -> guest_phys_addr & overflow
checks for this
- More docstrings throughout
- Make resp_buf and resp_buf_size optional
- Replace deprecated idr with xarray
- Refconting on misc device instead of RM's platform device
- Renaming variables, structs, etc. from gunyah_ -> gh_
- Drop removal of user mem regions
- Drop mem_lend functionality; to converge with restricted_memfd later
Changes in v10:
https://lore.kernel.org/all/20230214211229.3239350-1-quic_eberman@quicinc.com/
- Fix bisectability (end result of series is same, --fixups applied to
wrong commits)
- Convert GH_ERROR_* and GH_RM_ERROR_* to enums
- Correct race condition between allocating/freeing user memory
- Replace offsetof with struct_size
- Series-wide renaming of functions to be more consistent
- VM shutdown & restart support added in vCPU and VM Manager patches
- Convert VM function name (string) to type (number)
- Convert VM function argument to value (which could be a pointer) to
remove memory wastage for arguments
- Remove defensive checks of hypervisor correctness
- Clean ups to ioeventfd as suggested by Srivatsa
Changes in v9:
https://lore.kernel.org/all/20230120224627.4053418-1-quic_eberman@quicinc.com/
- Refactor Gunyah API flags to be exposed as feature flags at kernel
level
- Move mbox client cleanup into gunyah_msgq_remove()
- Simplify gh_rm_call return value and response payload
- Missing clean-up/error handling/little endian fixes as suggested by
Srivatsa and Alex in v8 series
Changes in v8:
https://lore.kernel.org/all/20221219225850.2397345-1-quic_eberman@quicinc.com/
- Treat VM manager as a library of RM
- Add patches 21-28 as RFC to support proxy-scheduled vCPUs and
necessary bits to support virtio
from Gunyah userspace
Changes in v7:
https://lore.kernel.org/all/20221121140009.2353512-1-quic_eberman@quicinc.com/
- Refactor to remove gunyah RM bus
- Refactor allow multiple RM device instances
- Bump UAPI to start at 0x0
- Refactor QCOM SCM's platform hooks to allow
CONFIG_QCOM_SCM=Y/CONFIG_GUNYAH=M combinations
Changes in v6:
https://lore.kernel.org/all/20221026185846.3983888-1-quic_eberman@quicinc.com/
- *Replace gunyah-console with gunyah VM Manager*
- Move include/asm-generic/gunyah.h into include/linux/gunyah.h
- s/gunyah_msgq/gh_msgq/
- Minor tweaks and documentation tidying based on comments from Jiri,
Greg, Arnd, Dmitry, and Bagas.
Changes in v5
https://lore.kernel.org/all/20221011000840.289033-1-quic_eberman@quicinc.com/
- Dropped sysfs nodes
- Switch from aux bus to Gunyah RM bus for the subdevices
- Cleaning up RM console
Changes in v4:
https://lore.kernel.org/all/20220928195633.2348848-1-quic_eberman@quicinc.com/
- Tidied up documentation throughout based on questions/feedback received
- Switched message queue implementation to use mailboxes
- Renamed "gunyah_device" as "gunyah_resource"
Changes in v3:
https://lore.kernel.org/all/20220811214107.1074343-1-quic_eberman@quicinc.com/
- /Maintained/Supported/ in MAINTAINERS
- Tidied up documentation throughout based on questions/feedback received
- Moved hypercalls into arch/arm64/gunyah/; following hyper-v's implementation
- Drop opaque typedefs
- Move sysfs nodes under /sys/hypervisor/gunyah/
- Moved Gunyah console driver to drivers/tty/
- Reworked gh_device design to drop the Gunyah bus.
Changes in v2: https://lore.kernel.org/all/20220801211240.597859-1-quic_eberman@quicinc.com/
- DT bindings clean up
- Switch hypercalls to follow SMCCC
v1: https://lore.kernel.org/all/20220223233729.1571114-1-quic_eberman@quicinc.com/
Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
---
Elliot Berman (34):
docs: gunyah: Introduce Gunyah Hypervisor
dt-bindings: Add binding for gunyah hypervisor
gunyah: Common types and error codes for Gunyah hypercalls
virt: gunyah: Add hypercalls to identify Gunyah
virt: gunyah: Add hypervisor driver
virt: gunyah: msgq: Add hypercalls to send and receive messages
gunyah: rsc_mgr: Add resource manager RPC core
gunyah: vm_mgr: Introduce basic VM Manager
gunyah: rsc_mgr: Add VM lifecycle RPC
gunyah: vm_mgr: Add VM start/stop
virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource
virt: gunyah: Add resource tickets
gunyah: vm_mgr: Add framework for VM Functions
virt: gunyah: Add hypercalls for running a vCPU
virt: gunyah: Add proxy-scheduled vCPUs
gunyah: Add hypercalls for demand paging
gunyah: rsc_mgr: Add memory parcel RPC
virt: gunyah: Add interfaces to map memory into guest address space
gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim
virt: gunyah: Add Qualcomm Gunyah platform ops
virt: gunyah: Implement guestmemfd
virt: gunyah: Add ioctl to bind guestmem to VMs
virt: gunyah: guestmem: Initialize RM mem parcels from guestmem
virt: gunyah: Share guest VM dtb configuration to Gunyah
gunyah: rsc_mgr: Add RPC to enable demand paging
mm/interval_tree: Export iter_first/iter_next
virt: gunyah: Enable demand paging
gunyah: rsc_mgr: Add RPC to set VM boot context
virt: gunyah: Allow userspace to initialize context of primary vCPU
virt: gunyah: Add hypercalls for sending doorbell
virt: gunyah: Add irqfd interface
virt: gunyah: Add IO handlers
virt: gunyah: Add ioeventfd
MAINTAINERS: Add Gunyah hypervisor drivers section
.../bindings/firmware/gunyah-hypervisor.yaml | 82 ++
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
Documentation/virt/gunyah/index.rst | 134 +++
Documentation/virt/gunyah/message-queue.rst | 68 ++
Documentation/virt/index.rst | 1 +
MAINTAINERS | 12 +
arch/arm64/Kbuild | 1 +
arch/arm64/gunyah/Makefile | 3 +
arch/arm64/gunyah/gunyah_hypercall.c | 279 ++++++
arch/arm64/include/asm/gunyah.h | 57 ++
drivers/virt/Kconfig | 2 +
drivers/virt/Makefile | 1 +
drivers/virt/gunyah/Kconfig | 47 +
drivers/virt/gunyah/Makefile | 9 +
drivers/virt/gunyah/guest_memfd.c | 960 ++++++++++++++++++++
drivers/virt/gunyah/gunyah.c | 52 ++
drivers/virt/gunyah/gunyah_ioeventfd.c | 139 +++
drivers/virt/gunyah/gunyah_irqfd.c | 190 ++++
drivers/virt/gunyah/gunyah_platform_hooks.c | 115 +++
drivers/virt/gunyah/gunyah_qcom.c | 218 +++++
drivers/virt/gunyah/gunyah_vcpu.c | 584 ++++++++++++
drivers/virt/gunyah/rsc_mgr.c | 948 ++++++++++++++++++++
drivers/virt/gunyah/rsc_mgr.h | 144 +++
drivers/virt/gunyah/rsc_mgr_rpc.c | 586 +++++++++++++
drivers/virt/gunyah/vm_mgr.c | 976 +++++++++++++++++++++
drivers/virt/gunyah/vm_mgr.h | 153 ++++
drivers/virt/gunyah/vm_mgr_mem.c | 321 +++++++
include/linux/gunyah.h | 482 ++++++++++
include/uapi/linux/gunyah.h | 378 ++++++++
mm/interval_tree.c | 3 +
30 files changed, 6946 insertions(+)
---
base-commit: bffdfd2e7e63175ae261131a620f809d946cf9a7
change-id: 20231208-gunyah-952aca7668e0
Best regards,