From patchwork Mon Jan 8 22:46:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonas_Dre=C3=9Fler?= X-Patchwork-Id: 18838 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1315141dyq; Mon, 8 Jan 2024 14:47:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPcvDQVwFLCgyXNfu+2R4rKb1EGFjIv/dWdf6u65xgKitbaAUJkV+Qt536sVOgzuquKtTG X-Received: by 2002:a17:902:b181:b0:1d4:2230:7f27 with SMTP id s1-20020a170902b18100b001d422307f27mr1848265plr.128.1704754024646; Mon, 08 Jan 2024 14:47:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704754024; cv=none; d=google.com; s=arc-20160816; b=MyTxRDqBzwdTKB/IVFsT8QlSrFnQBAggHoDoQQNBDfKtmRVBeaM1x59ClR6KdlSXl4 mc8DyXqU9/v66F3MBtiasYaAsmfv7IdwwatKiF2Jvvhr4OMeKMANiepIqPSTk3wfIKi4 MM5YD56icBpdXxPk79mUDRcqnL0BPHTKE+49YyMeHBDNmecDW6nYQDxI4linSIswyxi0 j52NDwZu6AVQ06lTmif9WJI7RvonNMRVgdP9fG+RqXNBq+Yj1unhI8IACiVOiYPuhnhd 3bYyoPfivBNhdTIlpYXV0fc79FSAOG7aAv8Vvs5P7UTpMk8NM6pTIQBs3RBDND1BCciH CuVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=LKV51wn+IL8CPxLsJ/0lioPThSAUvSREtRyqgEwsJ1Y=; fh=3AqDzvZy8BuFcn015+g5AB3sGQnZc/edyFwniXfpO+U=; b=X5iKDnav15VPToE67nExLXM7tzlqf7q+FAaUHI1cbu/b8X4ClI5RS+I0BrzMxBA9Sm 5frHzHVScNAhfd/1xFFfBIsPIELxlaa7NlrC6h6f9ru4ZTYNc+Fbzm/W/jOWzEy4VlZw 5F9vDi2SNzeJcyIJ2KONUc0Cak9BNBAoxt/4I6R8RC5ml4ArkW44767OvEIakJacIjTB nCD9omPxQ6O3HYFKlcVUYtdOKftwdEKYLOqKQwPkHi3N102rxalQin8QE7U9svmZjLGq 4cVOlOa9jP6n3copwVJF0J9PniGJmr5kl+SBN4YfXfGhabzQ1nAmE6YjJjMR5CFxKpeN laEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-20158-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20158-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x8-20020a170902ec8800b001d4f3c7d855si513956plg.265.2024.01.08.14.47.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 14:47:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20158-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-20158-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20158-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 70286284E30 for ; Mon, 8 Jan 2024 22:47:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 859BA56758; Mon, 8 Jan 2024 22:46:31 +0000 (UTC) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B791DDDC; Mon, 8 Jan 2024 22:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=v0yd.nl Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4T88LR4mJnz9sWf; Mon, 8 Jan 2024 23:46:23 +0100 (CET) From: =?utf-8?q?Jonas_Dre=C3=9Fler?= To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: =?utf-8?q?Jonas_Dre=C3=9Fler?= , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 0/4] Bluetooth: Improve retrying of connection attempts Date: Mon, 8 Jan 2024 23:46:05 +0100 Message-ID: <20240108224614.56900-1-verdre@v0yd.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4T88LR4mJnz9sWf X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787548625499727756 X-GMAIL-MSGID: 1787564156419364979 Since commit 4c67bc74f016 ("[Bluetooth] Support concurrent connect requests"), the kernel supports trying to connect again in case the bluetooth card is busy and fails to connect. The logic that should handle this became a bit spotty over time, and also cards these days appear to fail with more errors than just "Command Disallowed". This series refactores the handling of concurrent connection requests by serializing all "Create Connection" commands for ACL connections similar to how we do it for LE connections. --- v1: https://lore.kernel.org/linux-bluetooth/20240102185933.64179-1-verdre@v0yd.nl/ v2: https://lore.kernel.org/linux-bluetooth/20240108183938.468426-1-verdre@v0yd.nl/ v3: - Move the new sync function to hci_sync.c as requested by review - Abort connection on failure using hci_abort_conn_sync() instead of hci_abort_conn() - Make the last commit message a bit more precise regarding the meaning of BT_CONNECT2 state Jonas Dreßler (4): Bluetooth: Remove superfluous call to hci_conn_check_pending() Bluetooth: hci_event: Use HCI error defines instead of magic values Bluetooth: hci_conn: Only do ACL connections sequentially Bluetooth: Remove pending ACL connection attempts include/net/bluetooth/hci.h | 3 ++ include/net/bluetooth/hci_core.h | 1 - include/net/bluetooth/hci_sync.h | 3 ++ net/bluetooth/hci_conn.c | 83 +++----------------------------- net/bluetooth/hci_event.c | 29 +++-------- net/bluetooth/hci_sync.c | 72 +++++++++++++++++++++++++++ 6 files changed, 93 insertions(+), 98 deletions(-)