Message ID | 20240108032117.215171-1-wangrui@loongson.cn |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp810099dyq; Sun, 7 Jan 2024 19:22:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrBSPpwGxV6kAW27y4YE5v5uDom8bA98RUINnQSTuaJaDKwjyCxwjHpsgeSzt3H8k+gmHm X-Received: by 2002:a17:907:9343:b0:a26:f2da:83d5 with SMTP id bv3-20020a170907934300b00a26f2da83d5mr1349661ejc.34.1704684126307; Sun, 07 Jan 2024 19:22:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704684126; cv=none; d=google.com; s=arc-20160816; b=rZL0qFeHcS09zqq9OD0NVT/jM9GpHeeUsREcuTdKdoh3H6CC6ayq2Q0Bku9luszuVC 1+tLyeQrrZG1D93NBsEGCdRMsb1jhiDqWwmhy7wwlHb+fhUaWsHu2/czug6/XROOyOuh zu29kHVc2VmExH6Z2fYq2SSIfpsw5ZG9QDKWZ5H8eIsXmNWzCT8ZxQUVZvRXNl9x0WUX RBmpc80lcs6UhMO2szGO9GpxtWFKjRKsme9nx1HnQ+Zlbc055LT82mQUgrPWnYzUP7eU 9s8oeITUSsHy5ZewDvDLhBApmVo+sGAst349g2J8bOzDrJGTnPsQ2OaSto/Xw4qL/Lbt 0biA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=O2gTZGTZAm3hpjbcVPoYsVA/WfK1Eed/trkOTeSS/OU=; fh=RGFtQ7AhSb96yhUUo5QasDYPReqVInzjoTKXixObO6U=; b=w91GkKaCWYHE0w6LG9gVIQtL0dwDk+8h7+M1X3uWe3bv/nXBI3xwuvT6lXvNwgL0SE DOVsDyaHLQo5HWeVX1tsHhLX4e0Uy7IOZQdPydfiUkEcKrzRJCENVXHsMRgB62JQvRxE j/X4sbgYeA1t3mkLCLTgFeT1vNuC11PtYmhlYgt5nMClRSA3kU37SYoaHIwR0GzRKwPo ZRWzSEROpxbUsBHdydeDER1bef1eyqcPgyLIKkTNV2mqGl2UVpn+olTqUO3jz0LiUrG4 dgsB0JgfIw/y7ZdBK4IcF0Vmm2JZuER7844M2y4X6XnFZM6wJA6Baap/pBUQnm7dyHyY 3uVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d15-20020a1709067f0f00b00a280651f7efsi2727721ejr.794.2024.01.07.19.22.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 19:22:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19060-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C9DD61F214D0 for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 03:22:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD7898F45; Mon, 8 Jan 2024 03:21:40 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7DE9379C2; Mon, 8 Jan 2024 03:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [112.22.232.245]) by gateway (Coremail) with SMTP id _____8Bxnrs4aptljwQDAA--.1556S3; Mon, 08 Jan 2024 11:21:28 +0800 (CST) Received: from localhost.localdomain (unknown [112.22.232.245]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxO9wxaptlNuUGAA--.17925S2; Mon, 08 Jan 2024 11:21:25 +0800 (CST) From: WANG Rui <wangrui@loongson.cn> To: Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>, Huacai Chen <chenhuacai@kernel.org>, Jonathan Corbet <corbet@lwn.net> Cc: Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Benno Lossin <benno.lossin@proton.me>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, WANG Xuerui <kernel@xen0n.name>, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-doc@vger.kernel.org, loongson-kernel@lists.loongnix.cn, WANG Rui <wangrui@loongson.cn> Subject: [PATCH v1 0/2] Rust enablement for LoongArch Date: Mon, 8 Jan 2024 11:21:15 +0800 Message-ID: <20240108032117.215171-1-wangrui@loongson.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8CxO9wxaptlNuUGAA--.17925S2 X-CM-SenderInfo: pzdqw2txl6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29K BjDU0xBIdaVrnRJUUUPjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26c xKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vE j48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E 14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44 I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jw0_WrylYx0Ex4A2 jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20x vY0x0EwIxGrwCF54CYxVAaw2AFwI0_Jw0_GFyl4c8EcI0Ec7CjxVAaw2AFwI0_Jw0_GFyl 4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_Jw0_GFylx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUcCD7UUUUU X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787490862772897674 X-GMAIL-MSGID: 1787490862772897674 |
Series |
Rust enablement for LoongArch
|
|
Message
WANG Rui
Jan. 8, 2024, 3:21 a.m. UTC
Enable Rust support for the LoongArch architecture. Previous versions: v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ Changes in v1: - Address htmldocs warning. WANG Rui (2): Documentation: rust: Add a character to the first column LoongArch: Enable initial Rust support Documentation/rust/arch-support.rst | 13 +++++++------ arch/loongarch/Kconfig | 1 + arch/loongarch/Makefile | 3 +++ scripts/generate_rust_target.rs | 10 ++++++++++ 4 files changed, 21 insertions(+), 6 deletions(-)
Comments
No need to split patches. Huacai On Mon, Jan 8, 2024 at 11:21 AM WANG Rui <wangrui@loongson.cn> wrote: > > Enable Rust support for the LoongArch architecture. > > Previous versions: > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > Changes in v1: > - Address htmldocs warning. > > WANG Rui (2): > Documentation: rust: Add a character to the first column > LoongArch: Enable initial Rust support > > Documentation/rust/arch-support.rst | 13 +++++++------ > arch/loongarch/Kconfig | 1 + > arch/loongarch/Makefile | 3 +++ > scripts/generate_rust_target.rs | 10 ++++++++++ > 4 files changed, 21 insertions(+), 6 deletions(-) > > -- > 2.43.0 >
Squashed and applied, thanks. Huacai On Mon, Jan 8, 2024 at 12:23 PM Huacai Chen <chenhuacai@kernel.org> wrote: > > No need to split patches. > > Huacai > > On Mon, Jan 8, 2024 at 11:21 AM WANG Rui <wangrui@loongson.cn> wrote: > > > > Enable Rust support for the LoongArch architecture. > > > > Previous versions: > > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > > > Changes in v1: > > - Address htmldocs warning. > > > > WANG Rui (2): > > Documentation: rust: Add a character to the first column > > LoongArch: Enable initial Rust support > > > > Documentation/rust/arch-support.rst | 13 +++++++------ > > arch/loongarch/Kconfig | 1 + > > arch/loongarch/Makefile | 3 +++ > > scripts/generate_rust_target.rs | 10 ++++++++++ > > 4 files changed, 21 insertions(+), 6 deletions(-) > > > > -- > > 2.43.0 > >
Hi, Thanks for the patch. On Mon, Jan 08, 2024 at 11:21:15AM +0800, WANG Rui wrote: > Enable Rust support for the LoongArch architecture. > Could you share how you build and test? For example, I wonder the clang or gcc version you used and bindgen version you used. Thanks. Regards, Boqun > Previous versions: > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > Changes in v1: > - Address htmldocs warning. > > WANG Rui (2): > Documentation: rust: Add a character to the first column > LoongArch: Enable initial Rust support > > Documentation/rust/arch-support.rst | 13 +++++++------ > arch/loongarch/Kconfig | 1 + > arch/loongarch/Makefile | 3 +++ > scripts/generate_rust_target.rs | 10 ++++++++++ > 4 files changed, 21 insertions(+), 6 deletions(-) > > -- > 2.43.0 >
Hi Boqun, On Wed, Jan 10, 2024 at 3:35 AM Boqun Feng <boqun.feng@gmail.com> wrote: > > Hi, > > Thanks for the patch. > > On Mon, Jan 08, 2024 at 11:21:15AM +0800, WANG Rui wrote: > > Enable Rust support for the LoongArch architecture. > > > > Could you share how you build and test? For example, I wonder the clang > or gcc version you used and bindgen version you used. Thanks. You are welcome! The versions I'm using are listed in scripts/min-tool-version.sh, and I have tested Rust samples and the rnull block driver. llvm: main branch (ea3c7b3397f8de8e885ea7cd1ed5138ec4a72d50) rustc: 1.74.1 bindgen: 0.65.1 Here are the build steps: 1. Build llvm 2. Install rust, rust-src (using rustup) and bindgen 3. Build kernel For more details, refer to Documentation/rust/quick-start.rst; there is nothing special about it. Regards, Rui > > Regards, > Boqun > > > Previous versions: > > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > > > Changes in v1: > > - Address htmldocs warning. > > > > WANG Rui (2): > > Documentation: rust: Add a character to the first column > > LoongArch: Enable initial Rust support > > > > Documentation/rust/arch-support.rst | 13 +++++++------ > > arch/loongarch/Kconfig | 1 + > > arch/loongarch/Makefile | 3 +++ > > scripts/generate_rust_target.rs | 10 ++++++++++ > > 4 files changed, 21 insertions(+), 6 deletions(-) > > > > -- > > 2.43.0 > > >
On Wed, Jan 10, 2024 at 09:41:38AM +0800, WANG Rui wrote: > Hi Boqun, > > On Wed, Jan 10, 2024 at 3:35 AM Boqun Feng <boqun.feng@gmail.com> wrote: > > > > Hi, > > > > Thanks for the patch. > > > > On Mon, Jan 08, 2024 at 11:21:15AM +0800, WANG Rui wrote: > > > Enable Rust support for the LoongArch architecture. > > > > > > > Could you share how you build and test? For example, I wonder the clang > > or gcc version you used and bindgen version you used. Thanks. > > You are welcome! The versions I'm using are listed in > scripts/min-tool-version.sh, and I have tested Rust samples and the > rnull block driver. > > llvm: main branch (ea3c7b3397f8de8e885ea7cd1ed5138ec4a72d50) This means the LLVM support is yet to release? Or does LLVM 17 also work? Regards, Boqun > rustc: 1.74.1 > bindgen: 0.65.1 > > Here are the build steps: > > 1. Build llvm > 2. Install rust, rust-src (using rustup) and bindgen > 3. Build kernel > > For more details, refer to Documentation/rust/quick-start.rst; there > is nothing special about it. > > Regards, > Rui > > > > > Regards, > > Boqun > > > > > Previous versions: > > > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > > > > > Changes in v1: > > > - Address htmldocs warning. > > > > > > WANG Rui (2): > > > Documentation: rust: Add a character to the first column > > > LoongArch: Enable initial Rust support > > > > > > Documentation/rust/arch-support.rst | 13 +++++++------ > > > arch/loongarch/Kconfig | 1 + > > > arch/loongarch/Makefile | 3 +++ > > > scripts/generate_rust_target.rs | 10 ++++++++++ > > > 4 files changed, 21 insertions(+), 6 deletions(-) > > > > > > -- > > > 2.43.0 > > > > > >
On Wed, Jan 10, 2024 at 10:09 AM Boqun Feng <boqun.feng@gmail.com> wrote: > > On Wed, Jan 10, 2024 at 09:41:38AM +0800, WANG Rui wrote: > > Hi Boqun, > > > > On Wed, Jan 10, 2024 at 3:35 AM Boqun Feng <boqun.feng@gmail.com> wrote: > > > > > > Hi, > > > > > > Thanks for the patch. > > > > > > On Mon, Jan 08, 2024 at 11:21:15AM +0800, WANG Rui wrote: > > > > Enable Rust support for the LoongArch architecture. > > > > > > > > > > Could you share how you build and test? For example, I wonder the clang > > > or gcc version you used and bindgen version you used. Thanks. > > > > You are welcome! The versions I'm using are listed in > > scripts/min-tool-version.sh, and I have tested Rust samples and the > > rnull block driver. > > > > llvm: main branch (ea3c7b3397f8de8e885ea7cd1ed5138ec4a72d50) > > This means the LLVM support is yet to release? Or does LLVM 17 also > work? LLVM 17 doesn't work. The minimum LLVM version required for LoongArch is 18.0.0. This is the reason why we have updated the scripts/min-tool-version.sh. [1] [1] https://lore.kernel.org/loongarch/20240108033138.217032-1-wangrui@loongson.cn/ Regards, Rui > > Regards, > Boqun > > > rustc: 1.74.1 > > bindgen: 0.65.1 > > > > Here are the build steps: > > > > 1. Build llvm > > 2. Install rust, rust-src (using rustup) and bindgen > > 3. Build kernel > > > > For more details, refer to Documentation/rust/quick-start.rst; there > > is nothing special about it. > > > > Regards, > > Rui > > > > > > > > Regards, > > > Boqun > > > > > > > Previous versions: > > > > v0: https://lore.kernel.org/loongarch/20240106065941.180796-1-wangrui@loongson.cn/ > > > > > > > > Changes in v1: > > > > - Address htmldocs warning. > > > > > > > > WANG Rui (2): > > > > Documentation: rust: Add a character to the first column > > > > LoongArch: Enable initial Rust support > > > > > > > > Documentation/rust/arch-support.rst | 13 +++++++------ > > > > arch/loongarch/Kconfig | 1 + > > > > arch/loongarch/Makefile | 3 +++ > > > > scripts/generate_rust_target.rs | 10 ++++++++++ > > > > 4 files changed, 21 insertions(+), 6 deletions(-) > > > > > > > > -- > > > > 2.43.0 > > > > > > > > > >
On Wed, Jan 10, 2024 at 3:49 AM WANG Rui <wangrui@loongson.cn> wrote: > > LLVM 17 doesn't work. The minimum LLVM version required for LoongArch > is 18.0.0. This is the reason why we have updated the > scripts/min-tool-version.sh. [1] > > [1] https://lore.kernel.org/loongarch/20240108033138.217032-1-wangrui@loongson.cn/ Thanks! Is this targeted at 6.9? Cheers, Miguel
On Wed, Jan 10, 2024 at 6:50 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Wed, Jan 10, 2024 at 3:49 AM WANG Rui <wangrui@loongson.cn> wrote: > > > > LLVM 17 doesn't work. The minimum LLVM version required for LoongArch > > is 18.0.0. This is the reason why we have updated the > > scripts/min-tool-version.sh. [1] > > > > [1] https://lore.kernel.org/loongarch/20240108033138.217032-1-wangrui@loongson.cn/ > > Thanks! Is this targeted at 6.9? 6.8 Regards, Rui > > Cheers, > Miguel >
On Thu, Jan 11, 2024 at 4:16 AM WANG Rui <wangrui@loongson.cn> wrote: > > 6.8 Thanks, that is quite expedited... Please `rustfmt` the code to avoid failing the `rustfmtcheck` target. I see you already created the 6.8 tag but I have not seen it in linux-next yet and you did not send the PR, so it would be ideal if you could fix this before it goes to Linus. diff --git a/scripts/generate_rust_target.rs b/scripts/generate_rust_targetrs index 3edda6a10..0da52b548 100644 --- a/scripts/generate_rust_target.rs +++ b/scripts/generate_rust_target.rs @@ -163,10 +163,7 @@ fn main() { ts.push("target-pointer-width", "64"); } else if cfg.has("LOONGARCH") { ts.push("arch", "loongarch64"); - ts.push( - "data-layout", - "e-m:e-p:64:64-i64:64-i128:128-n64-S128", - ); + ts.push("data-layout", "e-m:e-p:64:64-i64:64-i128:128-n64-S128"); ts.push("features", "-f,-d"); ts.push("llvm-target", "loongarch64-linux-gnusf"); ts.push("llvm-abiname", "lp64s"); Thanks! Cheers, Miguel
Hi, Miguel, On Sun, Jan 14, 2024 at 11:44 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Thu, Jan 11, 2024 at 4:16 AM WANG Rui <wangrui@loongson.cn> wrote: > > > > 6.8 > > Thanks, that is quite expedited... > > Please `rustfmt` the code to avoid failing the `rustfmtcheck` target. > I see you already created the 6.8 tag but I have not seen it in > linux-next yet and you did not send the PR, so it would be ideal if > you could fix this before it goes to Linus. > > diff --git a/scripts/generate_rust_target.rs b/scripts/generate_rust_target.rs > index 3edda6a10..0da52b548 100644 > --- a/scripts/generate_rust_target.rs > +++ b/scripts/generate_rust_target.rs > @@ -163,10 +163,7 @@ fn main() { > ts.push("target-pointer-width", "64"); > } else if cfg.has("LOONGARCH") { > ts.push("arch", "loongarch64"); > - ts.push( > - "data-layout", > - "e-m:e-p:64:64-i64:64-i128:128-n64-S128", > - ); > + ts.push("data-layout", "e-m:e-p:64:64-i64:64-i128:128-n64-S128"); > ts.push("features", "-f,-d"); > ts.push("llvm-target", "loongarch64-linux-gnusf"); > ts.push("llvm-abiname", "lp64s"); > > Thanks! Thank you for your suggestion, but since this will be replaced by the built-in target soon, and I don't want to change the tag to make Linus unhappy. Let's leave it as is. Huacai > > Cheers, > Miguel
On Mon, Jan 15, 2024 at 4:23 AM Huacai Chen <chenhuacai@kernel.org> wrote: > > Thank you for your suggestion, but since this will be replaced by the > built-in target soon, and I don't want to change the tag to make Linus > unhappy. Let's leave it as is. The issue is not a big deal and I appreciate that you made the effort to enable Rust for your architecture. However, please note that we do our best to maintain a clean formatting state for Rust code (i.e. `rustfmt` should be run) and that people may see this in tests/CIs that use the Make target. I don't think Linus would mind too much, and you could point him to this email if you want (or you could put the fix on top); but if you really want to keep the tag as-is, then we should consider it as a fix for this cycle, i.e. we should not wait for e.g. the next cycle for the built-in target. Could you please send it through your tree as soon as possible? Cheers, Miguel
Hi, Miguel, On Tue, Jan 16, 2024 at 12:08 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Mon, Jan 15, 2024 at 4:23 AM Huacai Chen <chenhuacai@kernel.org> wrote: > > > > Thank you for your suggestion, but since this will be replaced by the > > built-in target soon, and I don't want to change the tag to make Linus > > unhappy. Let's leave it as is. > > The issue is not a big deal and I appreciate that you made the effort > to enable Rust for your architecture. However, please note that we do > our best to maintain a clean formatting state for Rust code (i.e. > `rustfmt` should be run) and that people may see this in tests/CIs > that use the Make target. > > I don't think Linus would mind too much, and you could point him to > this email if you want (or you could put the fix on top); but if you > really want to keep the tag as-is, then we should consider it as a fix > for this cycle, i.e. we should not wait for e.g. the next cycle for > the built-in target. Could you please send it through your tree as > soon as possible? OK, since Linus said the merge window is paused now, I rebase and retag my tree and the Rust commit is like this, I think this is perfect now? https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next&id=706f9e1ab7c7a58d80ef2c87d8720131253a2256 Huacai > > Cheers, > Miguel
On Tue, Jan 16, 2024 at 10:31 AM Huacai Chen <chenhuacai@kernel.org> wrote: > > OK, since Linus said the merge window is paused now, I rebase and > retag my tree and the Rust commit is like this, I think this is > perfect now? > > https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongsongit/commit/?h=loongarch-next&id=706f9e1ab7c7a58d80ef2c87d8720131253a2256 Thanks a lot! That works, yeah. I also took the chance to build LLVM and QEMU and I tested the tag -- it seems to work: I see the samples (built-in) printing in the kernel log :) So in case you end up rebasing for another reason and want to add it, even if it is a simple check I did: Tested-by: Miguel Ojeda <ojeda@kernel.org> Cheers, Miguel
Hi, Miguel, On Tue, Jan 16, 2024 at 11:16 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Tue, Jan 16, 2024 at 10:31 AM Huacai Chen <chenhuacai@kernel.org> wrote: > > > > OK, since Linus said the merge window is paused now, I rebase and > > retag my tree and the Rust commit is like this, I think this is > > perfect now? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next&id=706f9e1ab7c7a58d80ef2c87d8720131253a2256 > > Thanks a lot! That works, yeah. > > I also took the chance to build LLVM and QEMU and I tested the tag -- > it seems to work: I see the samples (built-in) printing in the kernel > log :) > > So in case you end up rebasing for another reason and want to add it, > even if it is a simple check I did: > > Tested-by: Miguel Ojeda <ojeda@kernel.org> OK, if Xuerui updates this patch, then I will rebase again. https://lore.kernel.org/loongarch/CAAhV-H7KteJvRVpj3Hz-Ui9VnmijcJq5D1Tb-KJvqTO_+jjp2Q@mail.gmail.com/T/#t Huacai > > Cheers, > Miguel