mbox series

[v3,0/9] Some random cleanups to mballoc

Message ID 20240105092102.496631-1-shikemeng@huaweicloud.com
Headers
Series Some random cleanups to mballoc |

Message

Kemeng Shi Jan. 5, 2024, 9:20 a.m. UTC 
  This series contains some random cleanups to mballoc. No function change
is intended except patch 8 may fix a potential memleak if non-used
preallocation spaces of inode could be greater than UNIT_MAX.
More details can be found in respective patches. Thanks!

v1->v2:
-Collect RVB from Jan.
-Remove 'needed' in trace_ext4_discard_preallocations.

v2->v3:
-Collect RVB from Jan and Ojaswin.
-Fix commit message in patch 2.

Kemeng Shi (9):
  ext4: remove unused return value of __mb_check_buddy
  ext4: remove unused parameter ngroup in ext4_mb_choose_next_group_*()
  ext4: remove unneeded return value of ext4_mb_release_context
  ext4: remove unused ext4_allocation_context::ac_groups_considered
  ext4: remove unused return value of ext4_mb_release
  ext4: remove unused return value of ext4_mb_release_inode_pa
  ext4: remove unused return value of ext4_mb_release_group_pa
  ext4: remove unnecessary parameter "needed" in
    ext4_discard_preallocations
  ext4: remove 'needed' in trace_ext4_discard_preallocations

 fs/ext4/ext4.h              |  4 +--
 fs/ext4/extents.c           | 10 ++++----
 fs/ext4/file.c              |  2 +-
 fs/ext4/indirect.c          |  2 +-
 fs/ext4/inode.c             |  6 ++---
 fs/ext4/ioctl.c             |  2 +-
 fs/ext4/mballoc.c           | 49 ++++++++++++++-----------------------
 fs/ext4/mballoc.h           |  1 -
 fs/ext4/move_extent.c       |  4 +--
 fs/ext4/super.c             |  2 +-
 include/trace/events/ext4.h | 11 +++------
 11 files changed, 38 insertions(+), 55 deletions(-)

Comments

Theodore Ts'o Feb. 4, 2024, 4:57 a.m. UTC | #1 
On Fri, 05 Jan 2024 17:20:53 +0800, Kemeng Shi wrote:
> This series contains some random cleanups to mballoc. No function change
> is intended except patch 8 may fix a potential memleak if non-used
> preallocation spaces of inode could be greater than UNIT_MAX.
> More details can be found in respective patches. Thanks!
> 
> v1->v2:
> -Collect RVB from Jan.
> -Remove 'needed' in trace_ext4_discard_preallocations.
> 
> [...]

Applied, thanks!

[1/9] ext4: remove unused return value of __mb_check_buddy
      commit: 133de5a0d8f8
[2/9] ext4: remove unused parameter ngroup in ext4_mb_choose_next_group_*()
      commit: 438a35e72d09
[3/9] ext4: remove unneeded return value of ext4_mb_release_context
      commit: 11fd1a5d6423
[4/9] ext4: remove unused ext4_allocation_context::ac_groups_considered
      commit: 97c32dbffce1
[5/9] ext4: remove unused return value of ext4_mb_release
      commit: 908177175a2a
[6/9] ext4: remove unused return value of ext4_mb_release_inode_pa
      commit: 820c280896ea
[7/9] ext4: remove unused return value of ext4_mb_release_group_pa
      commit: 20427949b9b5
[8/9] ext4: remove unnecessary parameter "needed" in ext4_discard_preallocations
      commit: 2ffd2a6ad1d3
[9/9] ext4: remove 'needed' in trace_ext4_discard_preallocations
      commit: f0e54b6087de

Best regards,