From patchwork Tue Jan 2 18:19:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonas_Dre=C3=9Fler?= X-Patchwork-Id: 18646 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4609453dyb; Tue, 2 Jan 2024 10:20:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnMONayrNBvO37+UAys2WbZl6XeHWNnTZkFZjy5fijJhR/OScfyjXk0kneh2O+od4fblZw X-Received: by 2002:a17:90a:43a6:b0:28c:129:fd2c with SMTP id r35-20020a17090a43a600b0028c0129fd2cmr17663794pjg.22.1704219656768; Tue, 02 Jan 2024 10:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704219656; cv=none; d=google.com; s=arc-20160816; b=vVrNpmJaD8VTohRmZXny0QwQWT9eVejl3TRvafiGCplypDF9dVBRggzpiB7J6FI9Hn MUkbjjoTL+1UyORI/yGAueJZ29L1MXOH8n4NZc0LI3bHHnhLB8zViRwp6FIQO4fmAN4K NJfZ9yegY6rmo3qBtdamGu/+k2D7WNdxO/xLj45cU/f/4BIyAfCyXnUcp1xiOyr2+FMg nOICVccYGk5JkZWAvoSXI4MQiWNVtFjeXoeXw5iphUv3jeWdaeHp5hd0wOCohwh0vgbP XXSBh73nZXXZcVrtTmYcnNSbjP/eaCE9Cv0crSYb5/Ia1kYGTR3KEB01eNCV0KtDTWDA Bh2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=af9SHIPH2XPMRWbZ8UhT3zf6Z63MV/0cktdraXUl5Qw=; fh=S5rf2bc7VLlSXYQ0EqFAIodb1qEiUfsxulvZhQKZRws=; b=uiNQHrReE29PZdpvirPN3ePWi95Fr62EHLWRgkZX9Pqlh3HriGDIDYNszOnWGlPxyT mfb9WcKPgBm/y6SPUVoSuSi2xsTFNGQlebGKGRVzdzHTXQxW4Y9y16Gvl/VM59GaNJsT Nxv1FNdawRlq98rMUDemKsVrM1bThTvz0b2+ZDGBULnouJIRGt1zscECN3tYZT23nhxo cO0pE7bXsWNh8xINPtPqBnfepQ7pcTGJVlN7VLFD0QXhl7bzx2F5nXm94o+TynzoIR1/ G1XRv+DJ6difJpnG/Udlw/zLYJrG+VFJvwpZqrsB9DhdOSEd8rYxfEoKNUiMiKJiJu8x 88dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-14700-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14700-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 42-20020a17090a09ad00b0028ca63faee6si8408813pjo.36.2024.01.02.10.20.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 10:20:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14700-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-14700-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14700-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B15BAB22867 for ; Tue, 2 Jan 2024 18:20:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C03815AFA; Tue, 2 Jan 2024 18:19:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C603C156E1; Tue, 2 Jan 2024 18:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=v0yd.nl Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4T4Ljd1DTkz9sRn; Tue, 2 Jan 2024 19:19:49 +0100 (CET) From: =?utf-8?q?Jonas_Dre=C3=9Fler?= To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: =?utf-8?q?Jonas_Dre=C3=9Fler?= , asahi@lists.linux.dev, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 0/4] Power off HCI devices before rfkilling them Date: Tue, 2 Jan 2024 19:19:16 +0100 Message-ID: <20240102181946.57288-1-verdre@v0yd.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786985792590577345 X-GMAIL-MSGID: 1787003830762381364 In theory the firmware is supposed to power off the bluetooth card when we use rfkill to block it. This doesn't work on a lot of laptops though, leading to weird issues after turning off bluetooth, like the connection timing out on the peripherals which were connected, and bluetooth not connecting properly when the adapter is turned on again quickly after rfkilling. This series hooks into the rfkill driver from the bluetooth subsystem to send a HCI_POWER_OFF command to the adapter before actually submitting the rfkill to the firmware and killing the HCI connection. --- v1 -> v2: Fixed commit message title to make CI happy Jonas Dreßler (4): Bluetooth: Remove HCI_POWER_OFF_TIMEOUT Bluetooth: mgmt: Remove leftover queuing of power_off work Bluetooth: Add new state HCI_POWERING_DOWN Bluetooth: Queue a HCI power-off command before rfkilling adapters include/net/bluetooth/hci.h | 2 +- net/bluetooth/hci_core.c | 33 ++++++++++++++++++++++++++++++--- net/bluetooth/hci_sync.c | 16 +++++++++++----- net/bluetooth/mgmt.c | 30 ++++++++++++++---------------- 4 files changed, 56 insertions(+), 25 deletions(-)