From patchwork Tue Jan 2 13:33:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonas_Dre=C3=9Fler?= X-Patchwork-Id: 18638 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4446319dyb; Tue, 2 Jan 2024 05:34:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyFiu8EPYx0QNpSlVuDNcq4AfpvNAsDriCzzjbSRJ3ibPjdXfkVbXq1AaPaZy7ZbJCr7s0 X-Received: by 2002:a05:6a21:3389:b0:196:1ee7:e08b with SMTP id yy9-20020a056a21338900b001961ee7e08bmr4775849pzb.75.1704202454225; Tue, 02 Jan 2024 05:34:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704202454; cv=none; d=google.com; s=arc-20160816; b=dqHUbI6UO1dt6/Yi3xiZ7eUmiuwUclohuWVZpLZi5fC7Ysc/rKRWkNLlxr9bkc4VxH /g22ae3kMpAkZwkleXpx9xuE0n+fotUo9oR+ZKmIV/dHL4V2Rmn1FuFqONvkFnTK1nYK VtE7BHxd10a4H3VnejkiLiX5OAqadyG7uXOuwNTUDFHvgJ1+ahsbd76VJLaTm3xjPCfS vRo3WCvB1IiCfWLRKHN/8yt5j+D4RyjtGGk41mp15ecZbFNYFSV2jvqlCL0k3AXKYkAU eGrP4zApKcrrTKbzgw9VCdEItel5izjqdkhXRhFsnhrSqXwbvhSX+lbvNq7OFsZUDkkC F0dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=pPBqHNkgVu6dG6pL5wdpEO5dOjMth2BvppLLkcDlrJU=; fh=S5rf2bc7VLlSXYQ0EqFAIodb1qEiUfsxulvZhQKZRws=; b=cfcTanuSgmxl5cQqsYZDDlLFU6QEilGMl+uinCwzUgftaFO3W6w9NJQnddlcFl+n/F 19VLF/Aay7K5ACJhRtzL0gAWNmhcB58lB4s7EHPpPBG74XY0cq4b7XyqN6Kc8XUmq/I0 //IehcSx49uDvFVW0RDweVq50dBiKdwPD0zLw0SBvCN0uxcshGHlRytG+XrnESC0X4Os glW2AtDvMsX17rmwfXXyUWZLclIUgwsiwmbkbb8yNrSZKV2iWtPUpmfhd81YWKua5dbS U/5t7a4ZVi5LfixgQitLcS6FA47S/v76DnxM9GtJ4SEHFNiPhZYziShNNXvr0nnvueWE qRCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-14405-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14405-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ob11-20020a17090b390b00b0028cde20f4f4si1441967pjb.167.2024.01.02.05.34.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 05:34:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14405-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-14405-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14405-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0B233283567 for ; Tue, 2 Jan 2024 13:34:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A33521171B; Tue, 2 Jan 2024 13:33:29 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9632AFBE7; Tue, 2 Jan 2024 13:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=v0yd.nl Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4T4DLz07j3z9t1C; Tue, 2 Jan 2024 14:33:15 +0100 (CET) From: =?utf-8?q?Jonas_Dre=C3=9Fler?= To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: =?utf-8?q?Jonas_Dre=C3=9Fler?= , asahi@lists.linux.dev, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/4] Power off HCI devices before rfkilling them Date: Tue, 2 Jan 2024 14:33:06 +0100 Message-ID: <20240102133311.6712-1-verdre@v0yd.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4T4DLz07j3z9t1C X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786985792590577345 X-GMAIL-MSGID: 1786985792590577345 In theory the firmware is supposed to power off the bluetooth card when we use rfkill to block it. This doesn't work on a lot of laptops though, leading to weird issues after turning off bluetooth, like the connection timing out on the peripherals which were connected, and bluetooth not connecting properly when the adapter is turned on again quickly after rfkilling. This series hooks into the rfkill driver from the bluetooth subsystem to send a HCI_POWER_OFF command to the adapter before actually submitting the rfkill to the firmware and killing the HCI connection. Jonas Dreßler (4): Bluetooth: HCI: Remove HCI_POWER_OFF_TIMEOUT Bluetooth: mgmt: Remove leftover queuing of power_off work Bluetooth: HCI: Add new state HCI_POWERING_DOWN hci: Queue a HCI power-off command before rfkilling adapters include/net/bluetooth/hci.h | 2 +- net/bluetooth/hci_core.c | 33 ++++++++++++++++++++++++++++++--- net/bluetooth/hci_sync.c | 16 +++++++++++----- net/bluetooth/mgmt.c | 30 ++++++++++++++---------------- 4 files changed, 56 insertions(+), 25 deletions(-)