From patchwork Tue Jan 2 13:12:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang Li X-Patchwork-Id: 18637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4435674dyb; Tue, 2 Jan 2024 05:13:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFygeY/fATpkPP1tI+si6RFHkD7vyKEl7GRd2h187sz7/BhB/c47BOLPq22VX6znlOz1Pax X-Received: by 2002:a17:903:25cf:b0:1d0:8dc3:9149 with SMTP id jc15-20020a17090325cf00b001d08dc39149mr18450092plb.72.1704201214099; Tue, 02 Jan 2024 05:13:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704201214; cv=none; d=google.com; s=arc-20160816; b=zhFvLShHvK7tVmuHQZLB+xheYbqQM3AYMoR1z/6qHh7sB6P9OqnrOpaj8bkIazehhW Zy4K8UzluLYDDqgUIeHyqQAFMZNPdwrKnJuik93Xn/BLv9zCtn1OqLzoxZHhVr7xT+yX yvngsk8QTqsfzKvo+NkoPCguVRuQXnI/6fVkLLUZ/OK6AQ+nqq52Jcy9dq0/Gg0dNOHe Lyg6ovuPgsAJL4jAWaqe8UykX8DH3QWM1FAlg62eTygelhWzORvH/Kp/1Y0BrGB/nnj9 gd3lN/mNLjURBfDnyk1hZvNkSX8aCMKRBzrTJR+n0rTTjq9sYBITLZXCAAcUNw8zkC2g c6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=daO+8Vo0jNlvzwLRDw/Wt7KlxBb2Rk5joGViCE+fZW4=; fh=5n5b5+XOwLgGNDePhvfXysty56rnkWOs9jaHEODdVeE=; b=RoMk0ZNcEFfPWc5MlDdFADY5UnFgEAO5I0w9zWtbSw8YRCiAHJ/f3s/4urIplxOhR/ bZaSPA9dCulxisUuHfM7QKOu0ihd7nRTInA3LvCqKXXkIv4Fs8AWXOCmY8qldmNPaNcA wHyoTAG2/E3f366i43ANx/iqa03RPv+bRs/+7E5GLYQWJrkrLmdjqTCxMp7mQmw7J/J+ TLRCXt/32piYycq7sm/vVnIgUm0sX5IVOJ9ap7LDMjRCwotTBIqDZF5q+LA5dEE8qUL2 Kd1uwNLF85agOYeMNLI4I/qjxiS0GHCGXvGVwPJRXSR171xKK7qtFxsb/OWCCG/9nhRi o6vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=nUUoJdqW; spf=pass (google.com: domain of linux-kernel+bounces-14381-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14381-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l2-20020a170903244200b001d3e6debb8dsi16640514pls.373.2024.01.02.05.13.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 05:13:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14381-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=nUUoJdqW; spf=pass (google.com: domain of linux-kernel+bounces-14381-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14381-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C6F502827C9 for ; Tue, 2 Jan 2024 13:13:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FA87FC02; Tue, 2 Jan 2024 13:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nUUoJdqW" X-Original-To: linux-kernel@vger.kernel.org Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3035FBE5 for ; Tue, 2 Jan 2024 13:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704201194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=daO+8Vo0jNlvzwLRDw/Wt7KlxBb2Rk5joGViCE+fZW4=; b=nUUoJdqW8b8LoXHm6jHb9AQoY7w7usMJmtiAEiG2xDm2XoFPm+hkRBm6Jl/cdjHsWd+4Nr kezQIcH7hHdzuHg5+e9JelcznloIelv+/ZeX/+J885tGp/WhFMipVKmKMQiLZVYg0eD2hM gsnUdbwcikV11Key7utkhN+Cmo9mvXs= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot Date: Tue, 2 Jan 2024 21:12:42 +0800 Message-Id: <20240102131249.76622-1-gang.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786984492420193454 X-GMAIL-MSGID: 1786984492420193454 Hi all, hugetlb init parallelization has now been updated to v3. This series is tested on next-20240102 and can not be applied to v6.7-rc8. Update Summary: - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Thanks to the testing by David Rientjes, we now know that this patch reduce hugetlb 1G initialization time from 77s to 18.3s on a 12T machine[4]. # Introduction Hugetlb initialization during boot takes up a considerable amount of time. For instance, on a 2TB system, initializing 1,800 1GB huge pages takes 1-2 seconds out of 10 seconds. Initializing 11,776 1GB pages on a 12TB Intel host takes more than 1 minute[1]. This is a noteworthy figure. Inspired by [2] and [3], hugetlb initialization can also be accelerated through parallelization. Kernel already has infrastructure like padata_do_multithreaded, this patch uses it to achieve effective results by minimal modifications. [1] https://lore.kernel.org/all/783f8bac-55b8-5b95-eb6a-11a583675000@google.com/ [2] https://lore.kernel.org/all/20200527173608.2885243-1-daniel.m.jordan@oracle.com/ [3] https://lore.kernel.org/all/20230906112605.2286994-1-usama.arif@bytedance.com/ [4] https://lore.kernel.org/all/76becfc1-e609-e3e8-2966-4053143170b6@google.com/ # Test result test no patch(ms) patched(ms) saved ------------------- -------------- ------------- -------- 256c2t(4 node) 1G 4745 2024 57.34% 128c1t(2 node) 1G 3358 1712 49.02% 12t 1G 77000 18300 76.23% 256c2t(4 node) 2M 3336 1051 68.52% 128c1t(2 node) 2M 1943 716 63.15% # Change log Changes in v3: - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Changes in v2: - https://lore.kernel.org/all/20231208025240.4744-1-gang.li@linux.dev/ - Reduce complexity with `padata_do_multithreaded` - Support 1G hugetlb v1: - https://lore.kernel.org/all/20231123133036.68540-1-gang.li@linux.dev/ - parallelize 2M hugetlb initialization with workqueue Gang Li (7): hugetlb: code clean for hugetlb_hstate_alloc_pages hugetlb: split hugetlb_hstate_alloc_pages padata: dispatch works on different nodes hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA hugetlb: parallelize 2M hugetlb allocation and initialization hugetlb: parallelize 1G hugetlb initialization fs/Kconfig | 1 + include/linux/hugetlb.h | 2 +- include/linux/padata.h | 3 + kernel/padata.c | 8 +- mm/hugetlb.c | 224 +++++++++++++++++++++++++++------------- mm/mm_init.c | 1 + 6 files changed, 163 insertions(+), 76 deletions(-)