From patchwork Sun Dec 31 05:03:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 18615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp3369903dyb; Sat, 30 Dec 2023 21:04:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4KoEfoIrD+BKLO4jk8MRW46zABxqfYMQb2SIyE/XoEa/BcpfhhlR2hS8b1+ZBF6WWEt2a X-Received: by 2002:a50:f688:0:b0:556:1152:83d3 with SMTP id d8-20020a50f688000000b00556115283d3mr438117edn.70.1703999052199; Sat, 30 Dec 2023 21:04:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703999052; cv=none; d=google.com; s=arc-20160816; b=rbd4YyzhIny/RQb94wCFvQIw9dLBd4nhIJXO4ocR5QvYTTg6fYRZ0j7hyIdlCRXVDG 6iG8NYyUCZ5Shl1rpGaY1v1cIspewd7TSfy+k/HmWfbWxliT18+oCc2cwBrRkfrVu6AA RRf+vwv20eKuWs7c+9hiXI65v5FoWpUid+uniRatcf9jigKcG8QRWyHdtb3qo4BVgRTm uonBbWA91KuBtyFbM1xIDa4Fbhtwumy7yxFJmSJgfwyIWF+DiB+5FvFDEEWrgQJtxGhU ud+IZLBNK2qUCusB1KXWwOV8r0PjjMnITzY/idNcWeGLpAhIvy6K2dP8jtA4TeGBzvT4 6Liw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:feedback-id:message-id:subject:cc :from:to:date:dkim-signature; bh=QrNUfX8Rb1OX00fG4mbQo/eO3Y707VvS2aAOdZZ/lzQ=; fh=PsnbK8gZ4eZSiF/O9d5dpgr6CuL/1pz8cu0fjhqYkzQ=; b=JVQx1gWCekFDNre1UO9+58GXg3zaGkaRI9ex3EED681xn1n1ZWnjmfkSIubLT8i84D kThQ3ZBRnoknuuuuoIJhGrCPGc4aAgPa0oAZ5s4KmLAeKmAjM1rvUvVwcG4OlhTLB6YT iB8UxuVlkUysqaCpW66xhyIIlb+DDyRTKKo51h7xIvcvPvd5gRvYpPxtGfo10IHW3r1W 5vyB2Pghyxa+Hl4nXlJhf4fEwa9ShWi/pwtWznIs6opvmN8sUnDIQkoESizsHULxOmjL cd+U06bxSQBVtq8vwSUws307lKEEmP749sI1fbrkgIiR8GJFQM1/PNCC25qA1VTaVhXU RcCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=yMOHqcuL; spf=pass (google.com: domain of linux-kernel+bounces-13631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13631-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id h26-20020a50cdda000000b00553ff0649a3si9488922edj.361.2023.12.30.21.04.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Dec 2023 21:04:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=yMOHqcuL; spf=pass (google.com: domain of linux-kernel+bounces-13631-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13631-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AA1C71F21CF7 for ; Sun, 31 Dec 2023 05:04:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD87128FD; Sun, 31 Dec 2023 05:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="yMOHqcuL" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6801391 for ; Sun, 31 Dec 2023 05:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1703999023; x=1704258223; bh=QrNUfX8Rb1OX00fG4mbQo/eO3Y707VvS2aAOdZZ/lzQ=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=yMOHqcuLGdg9TI29jGJ3y5pPcVC0kbKrn6FmEnZBmpzCoRVtwNbxkRP0iVn/U/l+U tyIVwr8r+yW1Csy2VOEfQktIfwNFDRs9rHxFCjpS37wEPSMiP6QJk/szkRPAvhCoUf Mv8D1LNUgVnrSZqO36lRNQgGcuY7kVPOggl5SIuBrYivULR7aa1MunmfWueJq/3jBe EVZ+sGA76TxJS24XjFOh7RgUbdm03OypkalkxGDqNWW5YCkBJuR36qX69dnhlDHh/9 l2vlxIKTyO45Ku+5lY9HfxT1dMTyu6u3eU7PGBKsrDs2+LltlIBk00RSHC5fc7gDcG pPZ5snfCb6jRQ== Date: Sun, 31 Dec 2023 05:03:27 +0000 To: Kalle Valo , Larry Finger , =?utf-8?q?Michael_B=C3=BCsch?= , Julian Calaby From: Rahul Rameshbabu Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Rahul Rameshbabu Subject: [PATCH wireless v2 0/4] wifi: b43: Various QoS-related fixes Message-ID: <20231231050300.122806-1-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786772509929925794 X-GMAIL-MSGID: 1786772509929925794 Recently acquired a MacBookPro8,3 (early 2011), which has a bcm4331 card. Noticed some issues with the wireless driver, specifically related to QoS, when using this device. Out of the box, applications like ssh appear to not work with the device when QoS is enabled. This series attempts to improve the out-of-box experience while cleaning up some fundamental issues in the driver when QoS is disabled, either by the related kernel parameter or the newly introduced QoS disablement function. Running FW 784.2 during testing. Log: [ 11.661972] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19) [ 11.919942] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19) [ 13.717460] [drm] amdgpu kernel modesetting enabled. [ 13.717705] amdgpu: Virtual CRAT table created for CPU [ 13.717719] amdgpu: Topology: Add CPU node [ 13.776896] NET: Registered PF_PACKET protocol family [ 15.234058] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19) [ 15.319388] wlp3s0b1: authenticate with 1c:87:2c:6f:f4:e0 [ 15.333239] wlp3s0b1: send auth to 1c:87:2c:6f:f4:e0 (try 1/3) [ 15.341672] wlp3s0b1: authenticated [ 15.341921] wlp3s0b1: associate with 1c:87:2c:6f:f4:e0 (try 1/3) [ 15.346912] wlp3s0b1: RX AssocResp from 1c:87:2c:6f:f4:e0 (capab=0x411 status=0 aid=3) [ 15.347255] wlp3s0b1: associated Link: https://lore.kernel.org/linux-wireless/20231230045105.91351-1-sergeantsagara@protonmail.com/ Rahul Rameshbabu (4): wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled wifi: b43: Stop correct queue in DMA worker when QoS is disabled wifi: b43: Disable QoS for bcm4331 drivers/net/wireless/broadcom/b43/b43.h | 16 ++++++++++++++++ drivers/net/wireless/broadcom/b43/dma.c | 4 ++-- drivers/net/wireless/broadcom/b43/main.c | 16 +++++++++------- drivers/net/wireless/broadcom/b43/pio.c | 6 +++--- 4 files changed, 30 insertions(+), 12 deletions(-) Acked-by: Michael Büsch