From patchwork Sat Dec 30 04:51:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 18610 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2930552dyb; Fri, 29 Dec 2023 20:52:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3YPbbtXBw0Q7k6QYwwyloRsp8WSrS0joouir+wzH/+ccWMe1CIhWbd3JJWAsMRipmGdJ5 X-Received: by 2002:a05:6e02:1805:b0:35f:b29c:d2ab with SMTP id a5-20020a056e02180500b0035fb29cd2abmr24387898ilv.34.1703911936843; Fri, 29 Dec 2023 20:52:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703911936; cv=none; d=google.com; s=arc-20160816; b=roFZZo78EfPV/0OLQvBTIg3gt7h29ruYYh2yCT9Rbvvu/jKS/bIea5G2d4piXcYYHd z3jGQBe2ogsFkDLI2yo8v0ILStCxnNhleHV+wOucRtlodMQFfd6Ratf+E9ABoPjpoiec 45ICK/90/0U5/pV4PujXIXskee7juT/rJFs9nw5ThvdFjV7tqYyaUQDmbZCUCbmqzQ6M lXTKLXXMUcC557vi+exhSZ3lH/uxcwi+1HKyXppXXkWLrFlvKqfUYzgCsknDPKM0x41v tKw7WXin7xFcp5g82fImNTEyQevnjCDWaDfC9SJFelHja7DrG5/S5nDRVTWwGUxWAGox s04Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:feedback-id:message-id:subject:cc :from:to:date:dkim-signature; bh=Bb2hc/iRnBAHpF2TK4kdPjCrMxFKX5qQZIMIQTkGeCc=; fh=+21FHHkXcWPzhlDv3RJju/ybCufC5jSccWkxzweibX0=; b=GjT2hBOeoeNZHagPDoJ/Vi27d4HN/U+UJxLk3LdeFNC1WA3y017poBmkvhLVfvknyk mVMwrDsSWn7/LZR7mL2ylork6l3NM2lsolWWEIUiY2upzwE5uC5oqv1t75NKkb/hD6Er ljw1gh1BYvoyMiGfCGUCCycqGPenrb10ApFZ8e8whrrAFp50dr6VndWPijfp938v7PfD FHWDdhFH7HSY1cRFeoJPtTQT+f3M3vrVyJYeEk5PdrgGeyiwkyIoB53QzLPZ4G/A5vSb tJCYbxTDPgAiEhqrXlB3HcJ9QkvS7gAOUhQR/CiNS8jl59SmzvsL3gdmgvPSjU519r8J FiBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=E8QScfN8; spf=pass (google.com: domain of linux-kernel+bounces-13328-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13328-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w16-20020a170902e89000b001d408d60139si12569973plg.10.2023.12.29.20.52.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 20:52:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13328-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=E8QScfN8; spf=pass (google.com: domain of linux-kernel+bounces-13328-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13328-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7A9EB2836D4 for ; Sat, 30 Dec 2023 04:52:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DA9663FE3; Sat, 30 Dec 2023 04:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="E8QScfN8" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DD9215B7 for ; Sat, 30 Dec 2023 04:51:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1703911895; x=1704171095; bh=Bb2hc/iRnBAHpF2TK4kdPjCrMxFKX5qQZIMIQTkGeCc=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=E8QScfN83edDrT6Vr12+bVBQzHTeJz5l9FdscK4pWbEk7slPLj12cXtVuuVtgnrlm tcrLdx/Svz7f/zqzStOCuEAEuvE0J75DVnaT42rEgjQN1Ip/iFWyM0ExSmeEF5nDwy fHgrBRQtnFa5UssysBN3jB32rL4iy9Hd4HFHd22AoPUtaLdsjoJGieEmGe/Gbz/f28 DOzlrnGSOTS1Lkyxc3lm/zDXKnwzk4WtyAwL/G5xmUO+Rbe3ACxAe9xIzoQ5iWF6Z+ z4+M87rWxOKt3tgOlzGpsXG0DKhrI0DYf8YjJ6rWxioDmPcmkEv52zPzSTZvwBkN9j rMAwc/AUA71JA== Date: Sat, 30 Dec 2023 04:51:23 +0000 To: Kalle Valo From: Rahul Rameshbabu Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Rahul Rameshbabu Subject: [PATCH wireless 0/5] wifi: b43: Various QoS-related fixes Message-ID: <20231230045105.91351-1-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786681162880725747 X-GMAIL-MSGID: 1786681162880725747 Recently acquired a MacBookPro8,3, which has a bcm4331 card. Noticed some issues with the wireless driver, specifically related to QoS, when using this device. Out of the box, applications like ssh appear to not work with the device when QoS is enabled. This series attempts to improve the out-of-box experience while cleaning up some fundamental issues in the driver when QoS is disabled, either by the related kernel parameter or the newly introduced QoS disablement function. Running FW 666.2 during testing. Log: [ +0.169771] b43-phy7: Loading firmware version 666.2 (2011-02-23 01:15:07) [ +0.249032] b43-phy7: Loading firmware version 666.2 (2011-02-23 01:15:07) [ +1.394130] b43-phy7: Loading firmware version 666.2 (2011-02-23 01:15:07) Rahul Rameshbabu (5): wifi: b43: Correct OpenFW QoS capability warning conditional wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled wifi: b43: Stop correct queue in DMA worker when QoS is disabled wifi: b43: Support advertising lack of QoS capability drivers/net/wireless/broadcom/b43/dma.c | 10 ++++++-- drivers/net/wireless/broadcom/b43/main.c | 32 +++++++++++++++++++----- drivers/net/wireless/broadcom/b43/pio.c | 17 ++++++++++--- 3 files changed, 48 insertions(+), 11 deletions(-)