From patchwork Thu Dec 28 16:57:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 18591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2110884dyb; Thu, 28 Dec 2023 08:57:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFPoSbWYG7wuZU2lw32Rg+L51qGS+1dd9dm+f+lwXvVJwmxswy8OyEaDDZThMjeTMw+YcE X-Received: by 2002:a05:6a20:7fa9:b0:195:105d:f40f with SMTP id d41-20020a056a207fa900b00195105df40fmr12030485pzj.81.1703782660013; Thu, 28 Dec 2023 08:57:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703782659; cv=none; d=google.com; s=arc-20160816; b=T/H63Q4EHHjFXxRfTjhHKXNTvf1E7/2uSz5hCuFYK1B5ltbuAFOh6Pp+V5p1LFbVyW gKdsc6ATT5SW2sqbFfeqkoGYLn7eL5qSjIK/koISMeWbFoLb8vQs91j8CgMFZ1W6yzgo wmUkZRobvSrWJNgLGIfaRhyxVNM+Zv5V0QnvoO1XY4FiTC6gtFXFX6+CXY0r1KG0gwuC r+JqUHO1MtFfp8hLHzQqCcULUtIfnWDCVfsrb+dheiGHvLcLkTlFzHNvySUDPff79P5W OGwM0Efb3dpMlZxoqcGu7SNu8EOWOZT+ewbVMfhpgwSBtPHgog8EF9MCNyAsgPntfznV FgYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=IkTaivMqSbwkQx6tdRK8iRmTpoPzk2TgRqpFAR1zSL0=; fh=4e2qFjS66mGpWyHKr9N8kXPPYMKbttPvTgPubxtup3s=; b=EX+9LUkjv3Sh7i6CBA//fQRtTeruefQ+7Hh8R7LTNCYfAm8rVYBZc3yo5sLWY1+tvY RWSXiUkx+7sDovLVJai4N5VEBXTlTQaUHAYPdaeJo/4hoHsZtreYYNxpAwui3wIjXgzZ 9sHQfhpbwHT/dIRZgurnpuJYh+3vhPsp+7Nxhjm5oD/3WOeHpH54KkPJGGSKbZqNfS/M cQXL7NpLDn+4dDl1SaHWRBi/TvvL+QzxK+kFMOT94OR+UqC/JpH3rNYm7LbV4Sv2oJGl D4R+FNs7QCIRlq2jYdftFC4VmMGTbbg6TCvIfnTz+2cBiOtcfzDKlJHlSm+61PvVwAhJ g36A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="aXrQswo/"; spf=pass (google.com: domain of linux-kernel+bounces-12787-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12787-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z30-20020a62d11e000000b006da34404b67si300507pfg.254.2023.12.28.08.57.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 08:57:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12787-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="aXrQswo/"; spf=pass (google.com: domain of linux-kernel+bounces-12787-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12787-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C7EA4285C69 for ; Thu, 28 Dec 2023 16:57:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD4B6F9E9; Thu, 28 Dec 2023 16:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aXrQswo/" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7348CF508; Thu, 28 Dec 2023 16:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703782643; x=1735318643; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6BZEQD+BPdQPPiPwf+9/1GG6o7RjVGwpGa0Ba6OSvC8=; b=aXrQswo/UAG1u3QtnMSk6q68a5HAvpgF0pZUwC1KN0zvGRDM9k0fPBjI tk4kQDSHjDrbd4WC5vztZ7AtDnvcGxDoDHZnYLQ8BctUi8SdS8a4IxwhT nRLnHp9wCY4UjXj4jHhGkKdY0voxUJ3GasCK2/lHb4L5st88qSto/vz7o ya9U5N3+xxFaKsM0dKoW3c2IJkkyrInK3W6q3Qu48aEzK2M6zFqFONoVk rmJ/eFCsI76YALAKO2+twLsNU1XO5WcIm9GY7a8ADFqHMq+NlngC3RieK TwAYN+FtZGwbIJp6700+nLuTLftU36jkiflfJmVs25F3vHsfEbKTonDc1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="381536537" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="381536537" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:57:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="844488429" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="844488429" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.94.250.171]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:57:15 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Igor Mammedov , Lukas Wunner , Mika Westerberg , Andy Shevchenko , "Rafael J . Wysocki" Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v2 0/7] PCI: Solve two bridge window sizing issues Date: Thu, 28 Dec 2023 18:57:00 +0200 Message-Id: <20231228165707.3447-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786545606141875843 X-GMAIL-MSGID: 1786545606141875843 Hi all, Here's a series that contains two fixes to PCI bridge window sizing algorithm. Together, they should enable remove & rescan cycle to work for a PCI bus that has PCI devices with optional resources and/or disparity in BAR sizes. For the second fix, I chose to expose find_empty_resource_slot() from kernel/resource.c because it should increase accuracy of the cannot-fit decision (currently that function is called find_resource()). In order to do that sensibly, a few improvements seemed in order to make its interface and name of the function sane before exposing it. Thus, the few extra patches on resource side. Unfortunately I don't have a reason to suspect these would help with the issues related to the currently ongoing resource regression thread [1]. [1] https://lore.kernel.org/linux-pci/ZXpaNCLiDM+Kv38H@marvin.atrad.com.au/ v2: - Add "typedef" to kerneldoc to get correct formatting - Use RESOURCE_SIZE_MAX instead of literal - Remove unnecessary checks for io{port/mem}_resource - Apply a few style tweaks from Andy Ilpo Järvinen (7): PCI: Fix resource double counting on remove & rescan resource: Rename find_resource() to find_empty_resource_slot() resource: Document find_empty_resource_slot() and resource_constraint resource: Use typedef for alignf callback resource: Handle simple alignment inside __find_empty_resource_slot() resource: Export find_empty_resource_slot() PCI: Relax bridge window tail sizing rules drivers/pci/bus.c | 10 ++---- drivers/pci/setup-bus.c | 80 +++++++++++++++++++++++++++++++++++++---- include/linux/ioport.h | 44 ++++++++++++++++++++--- include/linux/pci.h | 5 +-- kernel/resource.c | 68 ++++++++++++++++------------------- 5 files changed, 148 insertions(+), 59 deletions(-) Reviewed-by: Mika Westerberg