Message ID | 20231220-fp5-pmic-glink-v1-0-2a1f8e3c661c@fairphone.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2531814dyi; Wed, 20 Dec 2023 02:04:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhxnMPCIVzEGd+mgnErVHwyVrY3W6OjbQ+1Ml2sS72eXiIl51D+f0Ncf5MbGaXaX4cI9Sg X-Received: by 2002:a17:90a:d147:b0:28a:b494:ae80 with SMTP id t7-20020a17090ad14700b0028ab494ae80mr6458768pjw.85.1703066665438; Wed, 20 Dec 2023 02:04:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703066665; cv=none; d=google.com; s=arc-20160816; b=h0I26P6Bn7460LerinF7uRfqYg2LKIFGOjj/NRMBjCH9aax1yYzerVL5OgdipZWolO +bXNPqrwyJs2WYlntU9/wD7tYiJYHjmAEbFKDyafRUIk1LKLHOiFofXoh3LGJo5gDuRg zCnmZnjRiZSWy6InpTensSqgdOmmHoT0cKA7wLmCtWPwzzmq1FbkSl07UK3RqY4kqkvX J/AdspAHq1LH+rLPb8HYvAAvlCCE6NV3bPszIyiA8bRJnX+AHSYRVUwSRTki+92xekkr xlUfldoxWxd3h4PJ2Iq//5F99uoPm9elpaQiGTjSsgX/ATrjoH6fPv/CQAuG0valba+y CLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=LhB2sxNkKBiagF0783M3sqDgGJEaCC2xOC1nqq1YmjY=; fh=sNiqPwxztyFmc19Qw4Is5eaDyHKJicOHiyRj4BS1sgU=; b=NRaVXpQQSogvDqn8EqxoHoc/8GtT3fKBNJ5kUHbjN8GgOswh+fa0+Kq2xU8z+AWfXe urgN05CsCxVBw345O1pK92pyEafZnmJS8booa6NhOkEkjrbbOAqCrqj+tBAVxU1Td5Gd LF2iQNkZ34QhNIq4+Wr2jmKDPfPz40BxEOIQOiQHNeebXvAq1K9aqs8JqU+/DnhI3TLx pnUZONQmP2XmnZ5RvEKPUec/IU+P7ckxG08mmc/JpaonLXYESVJwXF8zjCvDOiqHp1bN Gxq+DqIuyXBuczLEZUYNHwKGBeGH7/Jk1MSqSdrl3JDze8cC17K2LtqlBDZXPEpAW2oD mB1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=2ga6A6By; spf=pass (google.com: domain of linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q41-20020a17090a17ac00b0028b22156219si2692077pja.15.2023.12.20.02.04.25 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 02:04:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=2ga6A6By; spf=pass (google.com: domain of linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6678-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3B7F72829F9 for <ouuuleilei@gmail.com>; Wed, 20 Dec 2023 10:04:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D3DA20DF0; Wed, 20 Dec 2023 10:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="2ga6A6By" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FF9208BC for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 10:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a234dc0984fso406561866b.0 for <linux-kernel@vger.kernel.org>; Wed, 20 Dec 2023 02:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1703066579; x=1703671379; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=LhB2sxNkKBiagF0783M3sqDgGJEaCC2xOC1nqq1YmjY=; b=2ga6A6ByhDbCY2zzftNgm6xE0y+Uwgt16L+0VgFjPjV4ycTP3uZOadOK46/3mNz9fb +RV6/HQ8QvbzfkplF5pHNw81X7Qoonqb09dGOqYICQTegElLRM99FF5eMOafTelLROJK Svsec8q+mmjGI3hS2JGiIWX43jfpt3ipiwbYoQAbyyLB/Ogp7YFulbVSTWWN6XDPHj9S 8Nr0AxZf6Vc7VK+rusc0j+45vpZUdddYFGykNvu6rm0QD9gN4DWSJtTsD3kJahtTZD4b KYmFmF4zT7kOkQsbcwsYUREIdjLrvWIzq3XTIxPhG3E90dI/HSh9KN0jOv1hIKnY3A+W nINQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703066579; x=1703671379; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LhB2sxNkKBiagF0783M3sqDgGJEaCC2xOC1nqq1YmjY=; b=n84YBpXCP7KLAOiWSXdORm1Zmg2ZAZmdp67iX6vByy7/JNaShPqj2Nq5UuutaJodIO I1mgU7PM/HNA+Z5WCazG8GogI2adl1qIn0BvvWWz76c3KpIhBgHm5mqKSOkTXCPPam+s +qgmDODGeCM+WbZ5BsilleVzoOqq2a1CdRt4S0QzCfHOLoM6NRe5Uzy6rtgjqz4Uq+f1 7YePE6Hs9lRz2u+D5/IckAc+y9AZwv4h5ukCJJ2j5Komvs0f/qDCa6TVialDyyqqMSH5 +rITq/mdvfweVu0OcrJ7IPPpwqgkUjVxV/eyqcEKRsCWw8ioL9JKYoXQalJkQf7AUzTA XZ9w== X-Gm-Message-State: AOJu0Yx5DMbSE8WdFmvavbRk3pzsv/7DwX2LfjR9HYUOkt46tksmA1hW IlPUe1sH8YqnOynDKA0ZJkaehQ== X-Received: by 2002:a17:906:26c6:b0:a1f:7298:aa25 with SMTP id u6-20020a17090626c600b00a1f7298aa25mr10590034ejc.45.1703066579067; Wed, 20 Dec 2023 02:02:59 -0800 (PST) Received: from otso.luca.vpn.lucaweiss.eu (2a02-8388-6584-6400-d322-7350-96d2-429d.cable.dynamic.v6.surfer.at. [2a02:8388:6584:6400:d322:7350:96d2:429d]) by smtp.gmail.com with ESMTPSA id f18-20020a170906561200b00a2356a7eafasm3718681ejq.199.2023.12.20.02.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 02:02:58 -0800 (PST) From: Luca Weiss <luca.weiss@fairphone.com> Subject: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge) Date: Wed, 20 Dec 2023 11:02:55 +0100 Message-Id: <20231220-fp5-pmic-glink-v1-0-2a1f8e3c661c@fairphone.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAM+7gmUC/x3MQQqAIBBA0avErBtQK4KuEi3MRhsqE4UIxLsnL d/i/wyJIlOCqckQ6eHEt6+QbQNm194R8lYNSqhOKiXQhgHDxQbdyf7AVcitt1qakTTUKESy/P7 DeSnlAw9veBRgAAAA To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, cros-qcom-dts-watchers@chromium.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Luca Weiss <luca.weiss@fairphone.com> X-Mailer: b4 0.12.4 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785794831472200187 X-GMAIL-MSGID: 1785794831472200187 |
Series |
Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)
|
|
Message
Luca Weiss
Dec. 20, 2023, 10:02 a.m. UTC
This series adds all the necessary bits to enable USB-C role switching,
charger and fuel gauge (all via pmic-glink) on Fairphone 5.
One thing that could be made different is the pmic-glink compatible.
I've chosen to use qcm6490 compatible for it and not sc7280 since
there's plenty of firmware variety on sc7280-based platforms and they
might require different quirks in the future, so limit this PDOS quirk
to just qcm6490 for now.
If someone thinks it should be qcom,sc7280-pmic-glink, please let me
know :)
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (3):
dt-bindings: soc: qcom: qcom,pmic-glink: document QCM6490 compatible
usb: typec: ucsi: Add qcm6490-pmic-glink as needing PDOS quirk
arm64: dts: qcom: qcm6490-fairphone-fp5: Add PMIC GLINK
.../bindings/soc/qcom/qcom,pmic-glink.yaml | 1 +
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 46 +++++++++++++++++++++-
arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 +++++++++
drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
4 files changed, 66 insertions(+), 1 deletion(-)
---
base-commit: 76fbb7732259f4c970998d6978d72177658a783a
change-id: 20231220-fp5-pmic-glink-b01d4fa1c7ea
Best regards,
Comments
On 20.12.2023 11:02, Luca Weiss wrote: > This series adds all the necessary bits to enable USB-C role switching, > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > One thing that could be made different is the pmic-glink compatible. > I've chosen to use qcm6490 compatible for it and not sc7280 since > there's plenty of firmware variety on sc7280-based platforms and they > might require different quirks in the future, so limit this PDOS quirk > to just qcm6490 for now. > > If someone thinks it should be qcom,sc7280-pmic-glink, please let me > know :) IMO it's best to continue using the "base soc" (which just so happened to fall onto sc7280 this time around) for all compatibles, unless the derivatives actually had changes as far as firmware goes, I *think* CrOS doesn't even have PMIC_GLINK? There are however WoA 7280 laptops which totally should have it.. Would be nice to hunt some down and see if they report different stuff to what's there on android firmware Konrad
On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > On 20.12.2023 11:02, Luca Weiss wrote: > > This series adds all the necessary bits to enable USB-C role switching, > > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > One thing that could be made different is the pmic-glink compatible. > > I've chosen to use qcm6490 compatible for it and not sc7280 since > > there's plenty of firmware variety on sc7280-based platforms and they > > might require different quirks in the future, so limit this PDOS quirk > > to just qcm6490 for now. > > > > If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > know :) > IMO it's best to continue using the "base soc" (which just so happened > to fall onto sc7280 this time around) for all compatibles, unless the > derivatives actually had changes Hi Konrad, I think at some point I asked Dmitry what he thought and he mentioned qcm6490. Even found the message again: > well, since it is a firmware thing, you might want to emphasise that. > So from my POV qcm6490 makes more sense But yeah since it's likely that sc7280 firmware behaves the same as qcm6490 firmware it's probably okay to use sc7280 compatible, worst case we change it later :) I'll send a v2 with those changes. Regards Luca > > as far as firmware goes, I *think* CrOS doesn't even have PMIC_GLINK? > There are however WoA 7280 laptops which totally should have it.. Would > be nice to hunt some down and see if they report different stuff to > what's there on android firmware > > Konrad
On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > On 20.12.2023 11:02, Luca Weiss wrote: > > > This series adds all the necessary bits to enable USB-C role switching, > > > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > > > One thing that could be made different is the pmic-glink compatible. > > > I've chosen to use qcm6490 compatible for it and not sc7280 since > > > there's plenty of firmware variety on sc7280-based platforms and they > > > might require different quirks in the future, so limit this PDOS quirk > > > to just qcm6490 for now. > > > > > > If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > > know :) > > IMO it's best to continue using the "base soc" (which just so happened > > to fall onto sc7280 this time around) for all compatibles, unless the > > derivatives actually had changes > > Hi Konrad, > > I think at some point I asked Dmitry what he thought and he mentioned > qcm6490. Even found the message again: > > > well, since it is a firmware thing, you might want to emphasise that. > > So from my POV qcm6490 makes more sense > > But yeah since it's likely that sc7280 firmware behaves the same as > qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > we change it later :) I'll send a v2 with those changes. Worst case we end up with sc7280 which has yet another slightly different UCSI / PMIC GLINK implementation, but the compatible string is already taken. I still suppose that this should be a qcm6490-related string. > > Regards > Luca > > > > > as far as firmware goes, I *think* CrOS doesn't even have PMIC_GLINK? > > There are however WoA 7280 laptops which totally should have it.. Would > > be nice to hunt some down and see if they report different stuff to > > what's there on android firmware > > > > Konrad >
On 21.12.2023 11:34, Dmitry Baryshkov wrote: > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: >> >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: >>> On 20.12.2023 11:02, Luca Weiss wrote: >>>> This series adds all the necessary bits to enable USB-C role switching, >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. >>>> >>>> One thing that could be made different is the pmic-glink compatible. >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since >>>> there's plenty of firmware variety on sc7280-based platforms and they >>>> might require different quirks in the future, so limit this PDOS quirk >>>> to just qcm6490 for now. >>>> >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me >>>> know :) >>> IMO it's best to continue using the "base soc" (which just so happened >>> to fall onto sc7280 this time around) for all compatibles, unless the >>> derivatives actually had changes >> >> Hi Konrad, >> >> I think at some point I asked Dmitry what he thought and he mentioned >> qcm6490. Even found the message again: >> >>> well, since it is a firmware thing, you might want to emphasise that. >>> So from my POV qcm6490 makes more sense >> >> But yeah since it's likely that sc7280 firmware behaves the same as >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case >> we change it later :) I'll send a v2 with those changes. > > Worst case we end up with sc7280 which has yet another slightly > different UCSI / PMIC GLINK implementation, but the compatible string > is already taken. > I still suppose that this should be a qcm6490-related string. Right, let's keep qcm then Konrad
On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > >> > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > >>> On 20.12.2023 11:02, Luca Weiss wrote: > >>>> This series adds all the necessary bits to enable USB-C role switching, > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > >>>> > >>>> One thing that could be made different is the pmic-glink compatible. > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > >>>> there's plenty of firmware variety on sc7280-based platforms and they > >>>> might require different quirks in the future, so limit this PDOS quirk > >>>> to just qcm6490 for now. > >>>> > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > >>>> know :) > >>> IMO it's best to continue using the "base soc" (which just so happened > >>> to fall onto sc7280 this time around) for all compatibles, unless the > >>> derivatives actually had changes > >> > >> Hi Konrad, > >> > >> I think at some point I asked Dmitry what he thought and he mentioned > >> qcm6490. Even found the message again: > >> > >>> well, since it is a firmware thing, you might want to emphasise that. > >>> So from my POV qcm6490 makes more sense > >> > >> But yeah since it's likely that sc7280 firmware behaves the same as > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > >> we change it later :) I'll send a v2 with those changes. > > > > Worst case we end up with sc7280 which has yet another slightly > > different UCSI / PMIC GLINK implementation, but the compatible string > > is already taken. > > I still suppose that this should be a qcm6490-related string. > Right, let's keep qcm then Ack from my side also. Thanks for the feedback! > > Konrad
On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > >> > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > >>> On 20.12.2023 11:02, Luca Weiss wrote: > > >>>> This series adds all the necessary bits to enable USB-C role switching, > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > >>>> > > >>>> One thing that could be made different is the pmic-glink compatible. > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > > >>>> there's plenty of firmware variety on sc7280-based platforms and they > > >>>> might require different quirks in the future, so limit this PDOS quirk > > >>>> to just qcm6490 for now. > > >>>> > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > >>>> know :) > > >>> IMO it's best to continue using the "base soc" (which just so happened > > >>> to fall onto sc7280 this time around) for all compatibles, unless the > > >>> derivatives actually had changes > > >> > > >> Hi Konrad, > > >> > > >> I think at some point I asked Dmitry what he thought and he mentioned > > >> qcm6490. Even found the message again: > > >> > > >>> well, since it is a firmware thing, you might want to emphasise that. > > >>> So from my POV qcm6490 makes more sense > > >> > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > >> we change it later :) I'll send a v2 with those changes. > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > is already taken. > > > I still suppose that this should be a qcm6490-related string. > > Right, let's keep qcm then > > Ack from my side also. Thanks for the feedback! This doesn't apply to my tree, where should it be going through? thanks, greg k-h
On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > > >> > > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > > >>> On 20.12.2023 11:02, Luca Weiss wrote: > > > >>>> This series adds all the necessary bits to enable USB-C role switching, > > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > >>>> > > > >>>> One thing that could be made different is the pmic-glink compatible. > > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > > > >>>> there's plenty of firmware variety on sc7280-based platforms and they > > > >>>> might require different quirks in the future, so limit this PDOS quirk > > > >>>> to just qcm6490 for now. > > > >>>> > > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > > >>>> know :) > > > >>> IMO it's best to continue using the "base soc" (which just so happened > > > >>> to fall onto sc7280 this time around) for all compatibles, unless the > > > >>> derivatives actually had changes > > > >> > > > >> Hi Konrad, > > > >> > > > >> I think at some point I asked Dmitry what he thought and he mentioned > > > >> qcm6490. Even found the message again: > > > >> > > > >>> well, since it is a firmware thing, you might want to emphasise that. > > > >>> So from my POV qcm6490 makes more sense > > > >> > > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > > >> we change it later :) I'll send a v2 with those changes. > > > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > > is already taken. > > > > I still suppose that this should be a qcm6490-related string. > > > Right, let's keep qcm then > > > > Ack from my side also. Thanks for the feedback! > > This doesn't apply to my tree, where should it be going through? As far as I can see the dependency for the driver commit 1d103d6af241 ("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices") was applied to Bjorn's qcom tree, so 2/3 should also go there then. Patch 3/3 (arm64 dts) definitely also Bjorn's qcom tree. So that leaves patch 1/3 which Bjorn can probably pick up as well but looking at git log you also picked up some for that file in the past, dunno. Regards Luca > > thanks, > greg k-h
On Tue, Jan 02, 2024 at 02:43:24PM +0100, Luca Weiss wrote: > On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > > On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > > > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > > > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > > > >> > > > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > > > >>> On 20.12.2023 11:02, Luca Weiss wrote: > > > > >>>> This series adds all the necessary bits to enable USB-C role switching, > > > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > >>>> > > > > >>>> One thing that could be made different is the pmic-glink compatible. > > > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > > > > >>>> there's plenty of firmware variety on sc7280-based platforms and they > > > > >>>> might require different quirks in the future, so limit this PDOS quirk > > > > >>>> to just qcm6490 for now. > > > > >>>> > > > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > > > >>>> know :) > > > > >>> IMO it's best to continue using the "base soc" (which just so happened > > > > >>> to fall onto sc7280 this time around) for all compatibles, unless the > > > > >>> derivatives actually had changes > > > > >> > > > > >> Hi Konrad, > > > > >> > > > > >> I think at some point I asked Dmitry what he thought and he mentioned > > > > >> qcm6490. Even found the message again: > > > > >> > > > > >>> well, since it is a firmware thing, you might want to emphasise that. > > > > >>> So from my POV qcm6490 makes more sense > > > > >> > > > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > > > >> we change it later :) I'll send a v2 with those changes. > > > > > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > > > is already taken. > > > > > I still suppose that this should be a qcm6490-related string. > > > > Right, let's keep qcm then > > > > > > Ack from my side also. Thanks for the feedback! > > > > This doesn't apply to my tree, where should it be going through? > > As far as I can see the dependency for the driver commit 1d103d6af241 > ("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices") was applied to > Bjorn's qcom tree, so 2/3 should also go there then. > > Patch 3/3 (arm64 dts) definitely also Bjorn's qcom tree. > > So that leaves patch 1/3 which Bjorn can probably pick up as well but > looking at git log you also picked up some for that file in the past, > dunno. Ok, for any remaining ones that want to be merged before 6.8-rc1 is out, feel free to add my: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> If they don't get picked up by 6.8-rc1, feel free to rebase and send it for me to take through my tree. thanks, greg k-h
On Wed, 20 Dec 2023 11:02:55 +0100, Luca Weiss wrote: > This series adds all the necessary bits to enable USB-C role switching, > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > One thing that could be made different is the pmic-glink compatible. > I've chosen to use qcm6490 compatible for it and not sc7280 since > there's plenty of firmware variety on sc7280-based platforms and they > might require different quirks in the future, so limit this PDOS quirk > to just qcm6490 for now. > > [...] Applied, thanks! [3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Add PMIC GLINK commit: 4cc920ed7899de91ea39b6c9bdb0ebb6860e8b47 Best regards,
On Tue Jan 2, 2024 at 2:53 PM CET, Greg Kroah-Hartman wrote: > On Tue, Jan 02, 2024 at 02:43:24PM +0100, Luca Weiss wrote: > > On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > > > On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > > > > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > > > > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > > > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > > > > >> > > > > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > > > > >>> On 20.12.2023 11:02, Luca Weiss wrote: > > > > > >>>> This series adds all the necessary bits to enable USB-C role switching, > > > > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > > >>>> > > > > > >>>> One thing that could be made different is the pmic-glink compatible. > > > > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > > > > > >>>> there's plenty of firmware variety on sc7280-based platforms and they > > > > > >>>> might require different quirks in the future, so limit this PDOS quirk > > > > > >>>> to just qcm6490 for now. > > > > > >>>> > > > > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > > > > >>>> know :) > > > > > >>> IMO it's best to continue using the "base soc" (which just so happened > > > > > >>> to fall onto sc7280 this time around) for all compatibles, unless the > > > > > >>> derivatives actually had changes > > > > > >> > > > > > >> Hi Konrad, > > > > > >> > > > > > >> I think at some point I asked Dmitry what he thought and he mentioned > > > > > >> qcm6490. Even found the message again: > > > > > >> > > > > > >>> well, since it is a firmware thing, you might want to emphasise that. > > > > > >>> So from my POV qcm6490 makes more sense > > > > > >> > > > > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > > > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > > > > >> we change it later :) I'll send a v2 with those changes. > > > > > > > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > > > > is already taken. > > > > > > I still suppose that this should be a qcm6490-related string. > > > > > Right, let's keep qcm then > > > > > > > > Ack from my side also. Thanks for the feedback! > > > > > > This doesn't apply to my tree, where should it be going through? > > > > As far as I can see the dependency for the driver commit 1d103d6af241 > > ("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices") was applied to > > Bjorn's qcom tree, so 2/3 should also go there then. > > > > Patch 3/3 (arm64 dts) definitely also Bjorn's qcom tree. > > > > So that leaves patch 1/3 which Bjorn can probably pick up as well but > > looking at git log you also picked up some for that file in the past, > > dunno. > > Ok, for any remaining ones that want to be merged before 6.8-rc1 is out, > feel free to add my: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > If they don't get picked up by 6.8-rc1, feel free to rebase and send it > for me to take through my tree. Hi Greg, This applies cleanly on -next as of next-20240206 still. Could you please pick it up for v6.9? I can also send a v2 with only the two remaining patches (dts was applied to qcom by Bjorn already). Regards Luca > > thanks, > > greg k-h
On Wed, Feb 07, 2024 at 12:20:00AM +0100, Luca Weiss wrote: > On Tue Jan 2, 2024 at 2:53 PM CET, Greg Kroah-Hartman wrote: > > On Tue, Jan 02, 2024 at 02:43:24PM +0100, Luca Weiss wrote: > > > On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > > > > On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > > > > > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > > > > > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > > > > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com> wrote: > > > > > > >> > > > > > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > > > > > > >>> On 20.12.2023 11:02, Luca Weiss wrote: > > > > > > >>>> This series adds all the necessary bits to enable USB-C role switching, > > > > > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > > > >>>> > > > > > > >>>> One thing that could be made different is the pmic-glink compatible. > > > > > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > > > > > > >>>> there's plenty of firmware variety on sc7280-based platforms and they > > > > > > >>>> might require different quirks in the future, so limit this PDOS quirk > > > > > > >>>> to just qcm6490 for now. > > > > > > >>>> > > > > > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > > > > > > >>>> know :) > > > > > > >>> IMO it's best to continue using the "base soc" (which just so happened > > > > > > >>> to fall onto sc7280 this time around) for all compatibles, unless the > > > > > > >>> derivatives actually had changes > > > > > > >> > > > > > > >> Hi Konrad, > > > > > > >> > > > > > > >> I think at some point I asked Dmitry what he thought and he mentioned > > > > > > >> qcm6490. Even found the message again: > > > > > > >> > > > > > > >>> well, since it is a firmware thing, you might want to emphasise that. > > > > > > >>> So from my POV qcm6490 makes more sense > > > > > > >> > > > > > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > > > > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > > > > > >> we change it later :) I'll send a v2 with those changes. > > > > > > > > > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > > > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > > > > > is already taken. > > > > > > > I still suppose that this should be a qcm6490-related string. > > > > > > Right, let's keep qcm then > > > > > > > > > > Ack from my side also. Thanks for the feedback! > > > > > > > > This doesn't apply to my tree, where should it be going through? > > > > > > As far as I can see the dependency for the driver commit 1d103d6af241 > > > ("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices") was applied to > > > Bjorn's qcom tree, so 2/3 should also go there then. > > > > > > Patch 3/3 (arm64 dts) definitely also Bjorn's qcom tree. > > > > > > So that leaves patch 1/3 which Bjorn can probably pick up as well but > > > looking at git log you also picked up some for that file in the past, > > > dunno. > > > > Ok, for any remaining ones that want to be merged before 6.8-rc1 is out, > > feel free to add my: > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > If they don't get picked up by 6.8-rc1, feel free to rebase and send it > > for me to take through my tree. > > Hi Greg, > > This applies cleanly on -next as of next-20240206 still. > > Could you please pick it up for v6.9? I can also send a v2 with only > the two remaining patches (dts was applied to qcom by Bjorn already). v2 with just the remaining patches would be great, thanks. greg k-h