mbox series

[0/1] StarFive DWMAC support for JH7100

Message ID 20231219231040.2459358-1-cristian.ciocaltea@collabora.com
Headers
Series StarFive DWMAC support for JH7100 |

Message

Cristian Ciocaltea Dec. 19, 2023, 11:10 p.m. UTC 
  This is just a subset of the initial patch series [1] adding networking
support for StarFive JH7100 SoC.

[1]: https://lore.kernel.org/lkml/20231218214451.2345691-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (1):
  net: stmmac: dwmac-starfive: Add support for JH7100 SoC

 drivers/net/ethernet/stmicro/stmmac/Kconfig   |  6 ++--
 .../ethernet/stmicro/stmmac/dwmac-starfive.c  | 32 ++++++++++++++++---
 2 files changed, 31 insertions(+), 7 deletions(-)

Comments

Conor Dooley Dec. 19, 2023, 11:48 p.m. UTC | #1 
On Wed, Dec 20, 2023 at 01:10:38AM +0200, Cristian Ciocaltea wrote:
> This is just a subset of the initial patch series [1] adding networking
> support for StarFive JH7100 SoC.
> 
> [1]: https://lore.kernel.org/lkml/20231218214451.2345691-1-cristian.ciocaltea@collabora.com/

You need to send the binding patch alongside the driver, unless that has
been applied already.

Cheers,
Conor.
Cristian Ciocaltea Dec. 19, 2023, 11:58 p.m. UTC | #2 
On 12/20/23 01:48, Conor Dooley wrote:
> On Wed, Dec 20, 2023 at 01:10:38AM +0200, Cristian Ciocaltea wrote:
>> This is just a subset of the initial patch series [1] adding networking
>> support for StarFive JH7100 SoC.
>>
>> [1]: https://lore.kernel.org/lkml/20231218214451.2345691-1-cristian.ciocaltea@collabora.com/
> 
> You need to send the binding patch alongside the driver, unless that has
> been applied already.

Yeah, I wasn't sure about that, that's why I initially asked in [1] for
a confirmation regarding the split.  I chose to keep the binding in the
same set with the dts patches because the driver is just a glue layer
and doesn't really depend on bindings changes.

Should I still provide it here?  I was about to submit the remaining
patch set, so it would be great if we could clarify this beforehand.

Thanks for noticing the potential issue,
Cristian

[1]:
https://lore.kernel.org/lkml/0451e5a9-0cfb-42a5-b74b-2012e2c0d326@collabora.com/
Cristian Ciocaltea Dec. 20, 2023, 12:11 a.m. UTC | #3 
On 12/20/23 01:58, Cristian Ciocaltea wrote:
> On 12/20/23 01:48, Conor Dooley wrote:
>> On Wed, Dec 20, 2023 at 01:10:38AM +0200, Cristian Ciocaltea wrote:
>>> This is just a subset of the initial patch series [1] adding networking
>>> support for StarFive JH7100 SoC.
>>>
>>> [1]: https://lore.kernel.org/lkml/20231218214451.2345691-1-cristian.ciocaltea@collabora.com/
>>
>> You need to send the binding patch alongside the driver, unless that has
>> been applied already.

You are right, the binding should stay with the driver as it provides
the top-level compatibles.  I was wrongly thinking on the base
snps,dwmac only.

> Yeah, I wasn't sure about that, that's why I initially asked in [1] for
> a confirmation regarding the split.  I chose to keep the binding in the
> same set with the dts patches because the driver is just a glue layer
> and doesn't really depend on bindings changes.
> 
> Should I still provide it here?  I was about to submit the remaining
> patch set, so it would be great if we could clarify this beforehand.
> 
> Thanks for noticing the potential issue,
> Cristian
> 
> [1]:
> https://lore.kernel.org/lkml/0451e5a9-0cfb-42a5-b74b-2012e2c0d326@collabora.com/
> 
>