From patchwork Tue Dec 19 14:08:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 18301 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1963325dyi; Tue, 19 Dec 2023 06:10:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFO0EF/Ns81Uel53eU2s1UOIZqkwZZMLBm0DnGwoV5SLZNy+RC0SAqBLjwHx/5V9mrhSxhH X-Received: by 2002:a17:903:28c:b0:1d3:7636:4731 with SMTP id j12-20020a170903028c00b001d376364731mr4618006plr.40.1702995056199; Tue, 19 Dec 2023 06:10:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702995056; cv=none; d=google.com; s=arc-20160816; b=MkuMSv/SbSq5wlVwZ/w4CwVByfhvfSMoaDkr3b+f1AP0W4jzjJQSm6cxuCcdvlGb8T rzmfW6Tf/Tbxb7c4dL//hLfP18NOX3NZ1lK4HwpqKl9t4KGDabxdYu6LVVIjLtWVa1Ha jo2iBtXEjuOYreNzoWCy/CXo0qve4EnxzBeMX/0bXD3jdPLhd0IDkpNpmn9WRHUZjgPR os+I4l33i40EY17kAuNvQmSBQeNaxZTFY68wat2G88xvCbNPfYNXXfVDnIOKCkECK0U2 c9zXAzx4YdEKNGgpuAb6tFphpcE3FzZvHrxpDEcEoZZshnCX1wBRkDBYci10hRgVplv8 NFqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=r4vrgIV1IAz0B4tX9ddcdRcM6G+TkA3BBQHjEZ3JY1A=; fh=psqeIqQxfZek0424cL9SkYvl38GCXL3eEwRdFqkhas0=; b=I/3GmOApBxu2X9XRhhr4C960oheXMlUtOKqPGIO4vtQM0ujumVpZXMUOjj5QyksFDO 1ZLq1UBIbzczR1s/dnezShBrOgtJxd1ftxju0EAKbsfByyjmEaWJyQ3k2Kae3otPjLiW 2XJqKXiQsgWvdManA/eoEWpRClNkVUFdqC/ToVl3Axf7Upx+ZZyX5UWo7D8SuOHnJt5G hoRoBslZUtOohh3mrBCuzxPmPa5UOEyEfk4ZAKgIxgkuBYt+GAf977rVJAFynUTgVBbp 4wx3ofceOgPGL4x3Ae8G9CRqp44RZRjg2nHWBRxzOE0HLuc/e5UZEY9UHcakN9rcE6OI f+zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ro8s2e6B; spf=pass (google.com: domain of linux-kernel+bounces-5319-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5319-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q7-20020a17090311c700b001d0c783e5a3si20329747plh.244.2023.12.19.06.10.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:10:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5319-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ro8s2e6B; spf=pass (google.com: domain of linux-kernel+bounces-5319-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5319-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 846C02843DA for ; Tue, 19 Dec 2023 14:09:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DABEC1BDC3; Tue, 19 Dec 2023 14:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ro8s2e6B" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 237001B270; Tue, 19 Dec 2023 14:08:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A433C433C7; Tue, 19 Dec 2023 14:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702994931; bh=qermIcNndRs4NNt6coSsX2HdKHOBXCJ/SRIJwiNKWz0=; h=From:To:Cc:Subject:Date:From; b=Ro8s2e6Bi41rJCJ73+OxheKUaJ9Ka2c4+x4aHuUOcNIqvuz9Ptsle/b2SZpMfbsEt 9t52BIGw7VOAoP5qGLZQJ+IulFPkPzn0LLtbebVTt2L1unO50JZVL0gqXnADVXN+Jw kKNJKsRgzY6rXo4a0pJsN5otKSaNexllAp0hesu2idRXgwHujmXmnVjf8V+JgEbPhk F28dx8qj9Y74xHS18ltSRfwm7BNxUTMJ4XQxlw7PFZW1g442X6MKg9eHFB3ASO2br/ yldfX81y49zGnb8hlFShvqtcojfaI2cO3cY5H8/blH9cTKcQBAilargprTVLYqUxzf IT5HZTe3tLwMg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Boqun Feng , Joel Fernandes , Neeraj Upadhyay , "Paul E . McKenney" , Uladzislau Rezki , Zqiang , rcu , Hillf Danton Subject: [PATCH 0/8 v2] rcu: Fix expedited GP deadlock (and cleanup some nocb stuff) Date: Tue, 19 Dec 2023 15:08:35 +0100 Message-Id: <20231219140843.939329-1-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785719744165601419 X-GMAIL-MSGID: 1785719744165601419 TREE04 can trigger a writer stall if run with memory pressure. This is due to a circular dependency between waiting for expedited grace period and polling on expedited grace period when workqueues go back to mayday serialization. Here is a proposal fix. Changes since v1: * Add __maybe_unused to __call_rcu_nocb_wake() declaration (reported by Paul) * Add reviewed-by tags * Fix nocb changelog (reported by Neeraj) * Fixed comment (reported by Hillf) Frederic Weisbecker (8): rcu/nocb: Make IRQs disablement symmetric rcu/nocb: Re-arrange call_rcu() NOCB specific code rcu/exp: Fix RCU expedited parallel grace period kworker allocation failure recovery rcu/exp: Handle RCU expedited grace period kworker allocation failure rcu: s/boost_kthread_mutex/kthread_mutex rcu/exp: Make parallel exp gp kworker per rcu node rcu/exp: Handle parallel exp gp kworkers affinity rcu/exp: Remove rcu_par_gp_wq kernel/rcu/rcu.h | 5 - kernel/rcu/tree.c | 222 +++++++++++++++++++++++++-------------- kernel/rcu/tree.h | 18 ++-- kernel/rcu/tree_exp.h | 81 +++----------- kernel/rcu/tree_nocb.h | 38 ++++--- kernel/rcu/tree_plugin.h | 52 ++------- 6 files changed, 194 insertions(+), 222 deletions(-)