From patchwork Tue Dec 19 08:45:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Gu X-Patchwork-Id: 18285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1797570dyi; Tue, 19 Dec 2023 00:46:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEv6pUJ3qu8iDFSB09sUJhjfhbxC5zMHns15C7ho87UkOOh3vxuXnA7TPvDwPSXi9sY2Ak3 X-Received: by 2002:a05:6808:4443:b0:3ba:59aa:5d57 with SMTP id ep3-20020a056808444300b003ba59aa5d57mr4209129oib.108.1702975569368; Tue, 19 Dec 2023 00:46:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702975569; cv=none; d=google.com; s=arc-20160816; b=yCIX6hhLqL5PM+muwrVIdSFfXw+EsYtnFlkXWm2FZKHiF1LfZZfIONz1IE6M9nQU3c kRuU9KNkP9H6UmV4TnzWwPIiG2kzCqxvkZYkPC+E4eJIiDfbESEzhDJyxMK8/rKoDySy lqPPCjSf5IQnUmEZCp+kY1KkEskTJLlnb6ZmNkFRon6QGcP1Lu3ic6DiYU8i8STTEWCG PcNbqRs4lNDvx00UDe6o0YCnDiopjT9YAPGCa/moVpsgEqA1MSWHkAtl937u5rgi7wdc 7hzHtxWGsjs40KIf2tR3dsO6OT1mETs0Mf2e0id6pLa8flZEBWbqsTMnLYo8HSAefXxD +Cfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=e7WjFEwKTtVDsr2Fph7c6uw7hE0lWrzSFp7AiqNq32w=; fh=uTJ0crBczByYIhxgrQpYUSGkMqtgvc9XI1pgPEVZjxY=; b=D51f7v2h6v31P5kyYxzefgzt9HXLmB8FQMBH1MHR1qoBE02NsHk6arpLxo02yJfGTr wNubugACjz66V/h63dg8gbidWPwB+SLj06LRZLvQMcdXT6WHd9TMnx3ON8AuSjxTszL9 fknMIiizswaVteGmt/8ZZLqMHsA3jZ7aZ+ef0TWGeU4n5eRFbtoAbMe7r7cgshuEGWhK drmDS1nPAhveYw/s30CzEcFAI0FI0YuEQBnl+wbEUSraW4Zu3mRZNjwZTEw6ZhVUf9G8 RGiSs6Re1YHIo+ffDffTZijK5u8pXUKnvFGM0FeyPYtI4YzLvvP7IZwxob2EWFaWyI87 sKrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4907-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4907-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id o2-20020a634e42000000b005c662c8da7fsi19434405pgl.730.2023.12.19.00.46.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:46:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4907-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4907-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4907-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 75592B214D5 for ; Tue, 19 Dec 2023 08:46:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47C0112B71; Tue, 19 Dec 2023 08:45:47 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B0A12B69; Tue, 19 Dec 2023 08:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R371e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=guwen@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0VyqKZpy_1702975536; Received: from localhost(mailfrom:guwen@linux.alibaba.com fp:SMTPD_---0VyqKZpy_1702975536) by smtp.aliyun-inc.com; Tue, 19 Dec 2023 16:45:38 +0800 From: Wen Gu To: wintera@linux.ibm.com, wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com, jaka@linux.ibm.com Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, guwen@linux.alibaba.com, raspl@linux.ibm.com, schnelle@linux.ibm.com, guangguan.wang@linux.alibaba.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v7 00/10] net/smc: implement SMCv2.1 virtual ISM device support Date: Tue, 19 Dec 2023 16:45:26 +0800 Message-Id: <20231219084536.8158-1-guwen@linux.alibaba.com> X-Mailer: git-send-email 2.32.0.3.g01195cf9f Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785699310409276589 X-GMAIL-MSGID: 1785699310409276589 The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by OS or hypervisor software, comparable to IBM ISM which is based on platform firmware or hardware. With the introduction of virtual ISM, SMCv2.1 makes some updates: - Introduce feature bitmask to indicate supplemental features. - Reserve a range of CHIDs for virtual ISM. - Support extended GIDs (128 bits) in CLC handshake. So this patch set aims to implement these updates in Linux kernel. And it acts as the first part of SMC-D virtual ISM extension & loopback-ism [1]. [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/ v7->v6: - Collect the Reviewed-by tag in v6; - Patch #3: redefine the struct smc_clc_msg_accept_confirm; - Patch #7: Because that the Patch #3 already adds '__packed' to smc_clc_msg_accept_confirm, so Patch #7 doesn't need to do the same thing. But this is a minor change, so I kept the 'Reviewed-by' tag. Other changes in previous versions but not yet acked: - Patch #1: Some minor changes in subject and fix the format issue (length exceeds 80 columns) compared to v3. - Patch #5: removes useless ini->feature_mask assignment in __smc_connect() and smc_listen_v2_check() compared to v4. - Patch #8: new added, compared to v3. v6->v5: - Add 'Reviewed-by' label given in the previous versions: * Patch #4, #6, #9, #10 have nothing changed since v3; - Patch #2: * fix the format issue (Alignment should match open parenthesis) compared to v5; * remove useless clc->hdr.length assignment in smcr_clc_prep_confirm_accept() compared to v5; - Patch #3: new added compared to v5. - Patch #7: some minor changes like aclc_v2->aclc or clc_v2->clc compared to v5 due to the introduction of Patch #3. Since there were no major changes, I kept the 'Reviewed-by' label. Other changes in previous versions but not yet acked: - Patch #1: Some minor changes in subject and fix the format issue (length exceeds 80 columns) compared to v3. - Patch #5: removes useless ini->feature_mask assignment in __smc_connect() and smc_listen_v2_check() compared to v4. - Patch #8: new added, compared to v3. v5->v4: - Patch #6: improve the comment of SMCD_CLC_MAX_V2_GID_ENTRIES; - Patch #4: remove useless ini->feature_mask assignment; v4->v3: - Patch #6: use SMCD_CLC_MAX_V2_GID_ENTRIES to indicate the max gid entries in CLC proposal and using SMC_MAX_V2_ISM_DEVS to indicate the max devices to propose; - Patch #6: use i and i+1 in smc_find_ism_v2_device_serv(); - Patch #2: replace the large if-else block in smc_clc_send_confirm_accept() with 2 subfunctions; - Fix missing byte order conversion of GID and token in CLC handshake, which is in a separate patch sending to net: https://lore.kernel.org/netdev/1701882157-87956-1-git-send-email-guwen@linux.alibaba.com/ - Patch #7: add extended GID in SMC-D lgr netlink attribute; v3->v2: - Rename smc_clc_fill_fce as smc_clc_fill_fce_v2x; - Remove ISM_IDENT_MASK from drivers/s390/net/ism.h; - Add explicitly assigning 'false' to ism_v2_capable in ism_dev_init(); - Remove smc_ism_set_v2_capable() helper for now, and introduce it in later loopback-ism implementation; v2->v1: - Fix sparse complaint; - Rebase to the latest net-next; Wen Gu (10): net/smc: rename some 'fce' to 'fce_v2x' for clarity net/smc: introduce sub-functions for smc_clc_send_confirm_accept() net/smc: unify the structs of accept or confirm message for v1 and v2 net/smc: support SMCv2.x supplemental features negotiation net/smc: introduce virtual ISM device support feature net/smc: define a reserved CHID range for virtual ISM devices net/smc: compatible with 128-bits extended GID of virtual ISM device net/smc: support extended GID in SMC-D lgr netlink attribute net/smc: disable SEID on non-s390 archs where virtual ISM may be used net/smc: manage system EID in SMC stack instead of ISM driver drivers/s390/net/ism.h | 7 - drivers/s390/net/ism_drv.c | 57 ++---- include/linux/ism.h | 1 - include/net/smc.h | 16 +- include/uapi/linux/smc.h | 2 + include/uapi/linux/smc_diag.h | 2 + net/smc/af_smc.c | 118 ++++++++----- net/smc/smc.h | 10 +- net/smc/smc_clc.c | 318 +++++++++++++++++++++------------- net/smc/smc_clc.h | 64 +++---- net/smc/smc_core.c | 37 ++-- net/smc/smc_core.h | 18 +- net/smc/smc_diag.c | 9 +- net/smc/smc_ism.c | 50 ++++-- net/smc/smc_ism.h | 30 +++- net/smc/smc_pnet.c | 4 +- 16 files changed, 448 insertions(+), 295 deletions(-)