From patchwork Tue Dec 19 03:07:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 18275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1684939dyi; Mon, 18 Dec 2023 19:08:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGq0KxUd9yGX4szZNuNjlC5Y4sEAP9ZJC1y15GqRL8VHDZ6VKr4bLqyXDhmHpjM6Dqabme X-Received: by 2002:a92:c244:0:b0:35f:97ca:14e6 with SMTP id k4-20020a92c244000000b0035f97ca14e6mr10143535ilo.49.1702955297303; Mon, 18 Dec 2023 19:08:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702955297; cv=none; d=google.com; s=arc-20160816; b=JOzqCtg+msCU11bqNXWAM2O3/nX3Qe6Atu+H66w+Nxsz/aoZ+ul6CvlsVsQPVrnvml cqWBNgdf9XcAnDfdnqBH+p3NG6LJe3Wk42P+ocutR9nTKqGStjYuJDF2YSvkpSd4aUPC ysvFqXPplQngNA9D1kcaidNfqkBzK+iFXyUV0JXvZBQRcA/UdaE5XxghhvQ4ay5Db2OA OK0Yo99STuI3PC1YD2vhowlnX9MeAECesNqy73IBYAp2Q7Swh9kqSlU21NoFitdp069s KXsGgytBbDOYKDM6y9YvrZWaCXYufFfkv5e8+ZMXXd+AqqrOsCTNDBNdnJ5A/KXxY2X6 NoMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ugqBaRJe8h/X1YmsvS5WQ5BEFMbUJepwKjqnP3aRxTw=; fh=h70dJO8c/kQzBx5G08DNBGLpC0OGfeXZuzZObLFqbr4=; b=fGnYIRxqYGhRX7JxjzP6hxSHeiyyiV5cMe0IniU16Dm6HJ6dBHP5lC0PCNC94CdKtf kesD4kst/MQqZ6euCZIYnAiDG/H5KtXJRvCilhtVND8z8lxtNAaT5xC2q1AjRkLBnEqw uz7xglZbF86T7HSH/R0c1U4IZvvi8iIQFxDL7Q+qug28/zF6YMTxIN6UyfaEI68+PRuL PeqggeW65wzzZsr/Ni8OeQYeFz9W+pXHFh69zI+efSlrLA0pXNBc5Dl4TI5jKwezkLwu geUwa+e55f0m8hxJh/f6aGrFNy8cVxvE/fqBz5NVjm2TDV9jMZHdc2yQwVBzsuLrWFkI M1QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e+EXejdf; spf=pass (google.com: domain of linux-kernel+bounces-4622-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4622-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cl5-20020a056a02098500b005cd87069a84si4633010pgb.764.2023.12.18.19.08.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 19:08:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4622-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e+EXejdf; spf=pass (google.com: domain of linux-kernel+bounces-4622-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4622-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 13AF3285DAE for ; Tue, 19 Dec 2023 03:08:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68EA88475; Tue, 19 Dec 2023 03:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="e+EXejdf" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1179E8460; Tue, 19 Dec 2023 03:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702955261; bh=eAOckwuowQJQnjs/A4Z6ZYNvsznDRiqHV8PeUEbxstI=; h=From:To:Cc:Subject:Date:From; b=e+EXejdfIbiDQRJ9/4gMcQL9y2Jg7RG9sYINKaUOpQfe5J6IK1/cXV8dBdhBQRsFw yvDfgvCmgRj42+d/YZTqkP1pBu1lyRoortu93onrevbTBL9xsF7ft0DGvSoPcp/AlY UR3AHz7G4uivyo1zGKIY77B1U1zuNRNvEJ9/tQg2A4W02n1k3frsLdfwfbezvwJUaq wGZNxGXt2XqgsRjcPhIKc/C64VKHuWSIfbzJzvbkJwcf0bxKgHL6R2fZ4vfkwyBZTR tE7JIoqmRqQS4iCoZVqdlwwnzbc5k7s14dZpdXNFBkXBEuqlxVSWN0sJtjuZyvPiaN FPgpYxZhXH/8w== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id CD1793781476; Tue, 19 Dec 2023 03:07:40 +0000 (UTC) From: Cristian Ciocaltea To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Venkata Prasad Potturu , Emil Velikov , Syed Saba Kareem , Kuninori Morimoto , Alper Nebi Yasak , Vijendar Mukunda , V sujith kumar Reddy , Mastan Katragadda , Ajit Kumar Pandey Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org, kernel@collabora.com Subject: [PATCH v2 0/8] Improve SOF support for Steam Deck OLED Date: Tue, 19 Dec 2023 05:07:18 +0200 Message-ID: <20231219030728.2431640-1-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785678053337755302 X-GMAIL-MSGID: 1785678053337755302 This patch series is a continuation of [1] to provide several fixes and improvements to the SOF drivers targeting the Vangogh platform, as found on Valve's Steam Deck OLED. The previous series only handled the legacy ACP drivers. Also note that, since v2, this patch series requires an updated SOF topology to provide a correct DAI link ID for the BT codec. The binary file should be located under: /usr/lib/firmware/amd/sof-tplg/sof-vangogh-nau8821-max.tplg Alternatively, as a temporary workaround, patch [2] can be used to adapt the driver to the broken topology. Another requirement to get this functional is patch [3] from v1, which has been dropped from the series to be upstreamed via the SOF development workflow. [1]: https://lore.kernel.org/all/20231209203229.878730-1-cristian.ciocaltea@collabora.com/ [2]: https://lore.kernel.org/all/20231209205351.880797-11-cristian.ciocaltea@collabora.com/ [3]: https://lore.kernel.org/all/20231209205351.880797-12-cristian.ciocaltea@collabora.com/ Changes in v2: - Updated commit message in PATCH 3 according to Emil's review - Reworked PATCH 7 according to Péter's suggestion and dropped PATCH 8 which is obsolete now - Dropped incorrect PATCH 10/11, according to Venkata the fw is broken and requires update - Dropped PATCH 11/11 which is handled via the SOF workflow - Added R-b from Emil too all remaining patches, except the reworked one - Rebased series onto next-20231218 - v1: https://lore.kernel.org/all/20231209205351.880797-1-cristian.ciocaltea@collabora.com/ Cristian Ciocaltea (8): ASoC: amd: acp: Drop redundant initialization of machine driver data ASoC: amd: acp: Make use of existing *_CODEC_DAI macros ASoC: amd: acp: Add missing error handling in sof-mach ASoC: amd: acp: Update MODULE_DESCRIPTION for sof-mach ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe() ASoC: SOF: amd: Optimize quirk for Valve Galileo ASoC: SOF: core: Skip firmware test for custom loaders ASoC: SOF: amd: Compute file paths on firmware load sound/soc/amd/acp/acp-mach-common.c | 6 +++--- sound/soc/amd/acp/acp-sof-mach.c | 26 +++++++---------------- sound/soc/sof/amd/acp-loader.c | 32 +++++++++++++++++++++++------ sound/soc/sof/amd/acp.c | 30 ++++++++++++++++----------- sound/soc/sof/fw-file-profile.c | 18 +++++++++++++--- 5 files changed, 69 insertions(+), 43 deletions(-)