From patchwork Sun Dec 17 10:30:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 18188 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp639852dyi; Sun, 17 Dec 2023 02:31:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKJ1VjoBHl78Tj/i3sbQPb9oI6skCadLovbx41+QH1/BlfQNN4iOcS7QucpGaSUAtZ9AZt X-Received: by 2002:a05:6602:3a11:b0:79f:ca2f:9198 with SMTP id by17-20020a0566023a1100b0079fca2f9198mr21608892iob.2.1702809088246; Sun, 17 Dec 2023 02:31:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702809088; cv=none; d=google.com; s=arc-20160816; b=OLfKMIwjy+df6twK5xZAiU2k01Hh4m0RhRDDddoyQrFQE7yhoehWckEzy3YxdRxxg+ 0yOYk+9siBle0V5nqW/wPly1F4YTssVgx7IXh6j4BoK0y/oofkNvuvGuPpauLZGoZa6E doTf3HNOZFZ/HwX+ivNOyy76SISW70+pCBsSX29HuQzr86Qb0+0hON5aixYUxnFk182d t1kZcvbWS4w4LemMEq/ZP3UqRZfYoaw7zcCUV42/ojBSrGPW0LurBbcX/K5vkePkNQVr ScpxUqxvgkUd/RXkjzy6ucHVB3EcGc6gpxhocBXz+hhZiFJLeivA28nB6UTkLG//8BC2 tUBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:feedback-id:dkim-signature:dkim-signature; bh=fyXh74lQgevKNGlAlWNEOwwiFaBctJceP26p4zqGrh4=; fh=29+NP+Avo3KW5WAFiPrv+jdOjQZBDMQJMXZlHI+I9m4=; b=06XZtiGQoKeiHrn2GgWuwdZ2aFQ2ogdmm1NjeMDwfydOiNDJzTTi+rfDYbXHm1BpZf WibvtXCkLrueCtVEzb+8yrG35jKE/QzCIhir5omyZcSBnNkwABphPp3nOTJdXnnyqEWS j1dG2IsDPPPD/4RNoeabRfP3w9xhhynl/Ya1m09P6BeRVE1+cqlsvfm4AfmiKDS985Kf GNO58HO0J8o6kD9jFdAy72l5FcqTYUeyzjllD915DG097ATJCki2PWKxkxLC5NeDV/tO RecL1b8R3VaWFjripv3KodgNHymBv+frrFGY34KoMILmH4r5DPmjtDlYTKE73d+GlDHZ uBhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=LAOz02sw; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=vZEd7Jir; spf=pass (google.com: domain of linux-kernel+bounces-2525-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2525-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j3-20020a056a00130300b006ce70be4c40si16098696pfu.349.2023.12.17.02.31.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 02:31:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2525-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=LAOz02sw; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=vZEd7Jir; spf=pass (google.com: domain of linux-kernel+bounces-2525-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2525-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F0774B2215D for ; Sun, 17 Dec 2023 10:31:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0BB5FE57C; Sun, 17 Dec 2023 10:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="LAOz02sw"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vZEd7Jir" X-Original-To: linux-kernel@vger.kernel.org Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB1A63B6 for ; Sun, 17 Dec 2023 10:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5A5295C00AF; Sun, 17 Dec 2023 05:30:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 17 Dec 2023 05:30:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm2; t=1702809017; x=1702895417; bh=fyXh74lQge vKNGlAlWNEOwwiFaBctJceP26p4zqGrh4=; b=LAOz02swTOwpxlka4++GTNrEs/ fK20h/G62v7uyyNLXgKe9owyZwFb90T7IcFW5szLAIH8N3fFFpLGcFP1vsQlbJzX 1C2ZHKTi9w2d9wFFA0hKL7Qb++QADCHgCtaxd6lGShDvr3Vb6UrIXz7W1U56VWfP UqJQk4hcLOJ+P53PbdDcsupzioFFP8LOz7Pd+MUAE1612sbf4nIfeWT4X9Cm1VjC mXsPYOtrpvCeVmbFz5A7VpeiBRZtfbJbbYEuAqpzYu4lUUEeqgKSyL/XptTZPnI8 QPuxI8qePv1LM0HHrqVpeA6RqOK1lzb2ItWYu3B60QyLDYeUg79a+iNOUaOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702809017; x=1702895417; bh=fyXh74lQgevKNGlAlWNEOwwiFaBc tJceP26p4zqGrh4=; b=vZEd7JiryxXG/GrZcsNf7s32q7XtWdT/ewhB4wsuHJnX SCQem2g64t1SxBsqqX3bMndI0jKnKLMew6XbsOGuwuzXGvJ3jnF4Gl9D3auaOedk 3MT03PBe3u6TamPrxd6EaUQXbNTO5n13l1951R7oaJn/HX6aSC556V1rwSXNIsVV ilk7SCvt+l3vr+4zeMMWXtxb90hzXEJ/LfApBQiBZpBx4b6HFioH+Q8TPMaIyguI csiIsNjxZFPqQZVexmJDlNklwkl5voutkG7DH2+1u0Jl0D/j1S8e+oEvL5Uumf2P CLGk0oX0S3vHln1piKvsP3zL9EVu6BmdemxnGrkMsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtiedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgoufhushhpvggtthffohhmrghinhculdegledmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepvfgrkhgrshhh ihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhirdhjph eqnecuggftrfgrthhtvghrnhepvdevveefvddtteeiffetheehjeelkeffudejieevhedv leelkeejkeekieethedtnecuffhomhgrihhnpegrrhgthhhivhgvrdhorhhgpddufeelge htrgdrohhrghdpshhouhhrtggvfhhorhhgvgdrnhgvthenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrghkrghmoh gttghhihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Dec 2023 05:30:15 -0500 (EST) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: adamg@pobox.com Subject: [RFC PATCH 0/8] firewire: core: support legacy layout of configuration ROM for AV/C device Date: Sun, 17 Dec 2023 19:30:03 +0900 Message-Id: <20231217103012.41273-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785524742679233884 X-GMAIL-MSGID: 1785524742679233884 Hi, Current core function of Linux FireWire subsystem partly supports legacy layout of configuration ROM, described in annex of 1394TA document[1]. It appears that some users have the demand of full support[2]. The series of change is to satisfy the demand. The change relates to driver matching procedure and notification to user space, thus could easily bring functional regression. For safe, the series includes KUnit application to test the change. However, backward incompatibility is inevitable due to change of modalias for unit device. As long as I investigated, any unit drivers in kernel are not affected by the change. Additionally, less applications in user space are not as well. I think we can be optimistic to the regression. Anyway, I'm pleased if receiving your comment or test report about the change. [1] Configuration ROM for AV/C Devices 1.0 (December 12, 2000, 1394 Trading Association, TA Document 1999027) https://web.archive.org/web/20210216003030/http://1394ta.org/wp-content/uploads/2015/07/1999027.pdf [2] [PATCH] Fix missing sysfs vendor/model entries for some devices https://sourceforge.net/p/linux1394/mailman/message/55802731/ Regards Takashi Sakamoto (8): firewire: core: adds constant qualifier for local helper functions firewire: core: replace magic number with macro firewire: test: add KUnit test for internal CSR API firewire: test: add test of CSR API for simple AV/C device firewire: test: add test of CSR API for legacy AV/C device firewire: core: detect numeric model identifier for legacy layout of configuration ROM firewire: core: detect model name for legacy layout of configuration ROM firewire: core: change modalias of unit device with backward incompatibility drivers/firewire/.kunitconfig | 1 + drivers/firewire/Kconfig | 16 ++ drivers/firewire/core-device.c | 117 +++++++++++---- drivers/firewire/csr-api-test.c | 251 ++++++++++++++++++++++++++++++++ 4 files changed, 358 insertions(+), 27 deletions(-) create mode 100644 drivers/firewire/csr-api-test.c