From patchwork Wed Dec 13 02:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 17959 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp8133502vqy; Tue, 12 Dec 2023 18:19:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaOXYqlm7N3LQLmCfmBADb6IhENjP0PS9gVkHt3wDWJgWHiXExQTeOESmse5mWUm/0GYKJ X-Received: by 2002:a05:6358:d598:b0:170:2abc:6e34 with SMTP id ms24-20020a056358d59800b001702abc6e34mr7799192rwb.19.1702433973286; Tue, 12 Dec 2023 18:19:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702433973; cv=none; d=google.com; s=arc-20160816; b=bTxqfSTzr0k8iZyHFG/uQ0AiFqjWqDe6jEDYRetMuYafmXwZe7vSGKkm71grNY+2ak PP4tYg1yChwFVSgT+zfrZ4I3Fqy9LZDPACFxRrvhWXpSVwj4+IzI1eK7/CPvfDULL4qU xvQaIpwQfqWNxQmmjqD3EzIX7McBf3ArnPwQ0EQOC5XlRCOBEZvGCql3pfY4XHYixEz5 OfiVlSduCToftk3jDaIrHgvOmAh+yBahql3t5STbOTISWZDcHzlJjs/QFKov/39AwDcV rXM6ZipAtiuSVxw9s1rh2mrdV3ndgw35ertSi0kfBXkftYSl0GUJcqV9kELBpsTdetdm N8HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=lkhYyX2J17ZoYIsLMAMUoZbbQPnHh89+aA4mNHbQC5I=; fh=e3UoLP0GGIVG/JuDivUt2G6X10h9sIOfzt1IJTPiLuw=; b=KK20rPcwWQvTmhrZ7CuhZz3Ou4mVWBsiJEuhS/zLyacotJ0hfGnF57b6Zspo3cU1fb qvc72ozuS1NO/s6i7fhP9+Zhf1uRK8lgrvVfdemzRCP39tHmURokYBpCCn7g2urA0q3I mEpy/82uJbobgE0ed9Jkt3HzA9KRTTLhiusGiaQKgWv2R4tXpK3lGZ05YFArQP4/8bO7 P7Pp8ihshdMO12w23i+twBYhXUD0SdfLPyR3VAgNuFCovORR1I4krAAqg39rgQrPCH3B Hdi482h+Ypy5xzl7kXUzOlnFHwu0lWteKI4KpxjtIoV1HVzfFjMqCyJoILfFuv8C/Vcx Nodg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id er8-20020a17090af6c800b0028ae729ce2dsi111652pjb.178.2023.12.12.18.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 18:19:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 132F480408C7; Tue, 12 Dec 2023 18:19:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378306AbjLMCTV (ORCPT + 99 others); Tue, 12 Dec 2023 21:19:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378298AbjLMCTU (ORCPT ); Tue, 12 Dec 2023 21:19:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEC6CBE for ; Tue, 12 Dec 2023 18:19:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0772C433C7; Wed, 13 Dec 2023 02:19:24 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rDEr2-00000002Tkj-0vcQ; Tue, 12 Dec 2023 21:20:08 -0500 Message-ID: <20231213021914.361709558@goodmis.org> User-Agent: quilt/0.67 Date: Tue, 12 Dec 2023 21:19:14 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tzvetomir Stoyanov , Vincent Donnefort , Kent Overstreet Subject: [PATCH v2 00/15] ring-buffer/tracing: Allow ring buffer to have bigger sub buffers X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 12 Dec 2023 18:19:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785131405961590184 X-GMAIL-MSGID: 1785131405961590184 Note, this has been on my todo list since the ring buffer was created back in 2008. Tzvetomir last worked on this in 2021 and I need to finally get it in. His last series was: https://lore.kernel.org/linux-trace-devel/20211213094825.61876-1-tz.stoyanov@gmail.com/ With the description of: Currently the size of one sub buffer page is global for all buffers and it is hard coded to one system page. The patch set introduces configurable ring buffer sub page size, per ring buffer. A new user space interface is introduced, which allows to change the sub page size of the ftrace buffer, per ftrace instance. I'm pulling in his patches mostly untouched, except that I had to tweak a few things to forward port them. The issues I found I added as the last 7 patches to the series, and then I added documentation and a selftest. Basically, events to the tracing subsystem are limited to just under a PAGE_SIZE, as the ring buffer is split into "sub buffers" of one page size, and an event can not be bigger than a sub buffer. This allows users to change the size of a sub buffer by the order: echo 3 > /sys/kernel/tracing/buffer_subbuf_order Will make each sub buffer a size of 8 pages, allowing events to be almost as big as 8 pages in size (sub buffers do have meta data on them as well, keeping an event from reaching the same size as a sub buffer). Changes since v1: https://lore.kernel.org/all/20231210040448.569462486@goodmis.org/ - Add the last patch that changes the ABI from a file called: buffer_subbuf_order to buffer_subbuf_size_kb That is, I kept the old interface the same, but then added the last patch that converts the interface into the one that makes more sense. I like keeping this in the git history, especially because of the way the implemantion is. - I rebased on top of trace/core in the: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git - I made the tests a bit more advanced. Still a smoke test, but it now checks if the string written is the same as the string read. Steven Rostedt (Google) (10): ring-buffer: Clear pages on error in ring_buffer_subbuf_order_set() failure ring-buffer: Do no swap cpu buffers if order is different ring-buffer: Make sure the spare sub buffer used for reads has same size tracing: Update snapshot order along with main buffer order tracing: Stop the tracing while changing the ring buffer subbuf size ring-buffer: Keep the same size when updating the order ring-buffer: Just update the subbuffers when changing their allocation order ring-buffer: Add documentation on the buffer_subbuf_order file ringbuffer/selftest: Add basic selftest to test changing subbuf order tracing: Update subbuffer with kilobytes not page order Tzvetomir Stoyanov (VMware) (5): ring-buffer: Refactor ring buffer implementation ring-buffer: Page size per ring buffer ring-buffer: Add interface for configuring trace sub buffer size ring-buffer: Set new size of the ring buffer sub page ring-buffer: Read and write to ring buffers with custom sub buffer size ---- Documentation/trace/ftrace.rst | 21 ++ include/linux/ring_buffer.h | 17 +- kernel/trace/ring_buffer.c | 409 ++++++++++++++++----- kernel/trace/ring_buffer_benchmark.c | 10 +- kernel/trace/trace.c | 155 +++++++- kernel/trace/trace.h | 1 + kernel/trace/trace_events.c | 59 ++- .../test.d/00basic/ringbuffer_subbuf_size.tc | 95 +++++ 8 files changed, 647 insertions(+), 120 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/00basic/ringbuffer_subbuf_size.tc