From patchwork Mon Dec 11 06:54:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayush Singh X-Patchwork-Id: 17821 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp6869605vqy; Sun, 10 Dec 2023 22:54:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1u8wcDdGHZqxOKliW7HTe8bPu2do3kQsGCw0E8/30JaMJTGxbiO2JMZZaHfiCN6g1Pjbe X-Received: by 2002:a05:6359:639d:b0:170:1e24:b827 with SMTP id sg29-20020a056359639d00b001701e24b827mr4676945rwb.40.1702277675659; Sun, 10 Dec 2023 22:54:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702277675; cv=none; d=google.com; s=arc-20160816; b=ikBGiFaQrFol4Lxkyb7wiq93oka6Qci1OieyKQ7WHa8n1HDjAZxeZXOCQu2ohbr8w3 HOY7oAKqhvGCIoy70ajS+zq97mksWJwrzdH6PJmatTv1VxT1DzFR8L5t10pn4qGEQMuZ DvZ38+ghqtUthyqTrvE08KbCnT7qRVWBQbhlaJgbFtVNllj/LpmRsEp1pCUxwgQpej4k IzOMgBMR1Cy+DpI9Ew1tA2pi30Y6Bd/CLkFGYXzIXGSu9ZYPjpKQ67zaqMaZyHjDUr7O j6ieBIpPJFmiqSFlmym8yCTFzwGmom2iGf7v0WclPzfO42JxZPvRXom6wxnDpb7GQkl1 8sPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K0+jiNBabf5mDupvKR2mxyLiAA9W8b3A/GEvdc87WBA=; fh=co/de1SGAKZAvSvhfX0xdd1CBSxdr3nV/NugAYVDMAE=; b=ZaYRN73HfszctC0+sMToVG3nZF39MV7HPMIChZRPaEQd5qDfaOya/8pzJ2Zrpj9wKD /AOONUwVfj1NOckbg1obgDtQQisGMX9mVksnU0guuc86theIarbgXFkRKUIT2RWPMaG3 uxgSTnEyeKVsq3ekPWK5ZY7Ux6l6m1N7fySyn+5ar+mucLrYYQjTido2Xqvg3xp/d6sA AMLLwRk8r5SU/Jd6QOpn3R12ezxSV5KzRtH9eA/HL7cXKe6BcgeBJKt23fp4PQ+0e11w tt2iKFGZn8ey4xOmQzTGNR1UeQDs3DeDkxzKQDa34cMw0mZ5ytp2YS7lvdmP2UR+xF/I 42gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QZfNGXT1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id h5-20020a170902f7c500b001d0725baa37si5529606plw.169.2023.12.10.22.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 22:54:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QZfNGXT1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id AE908807860C; Sun, 10 Dec 2023 22:54:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233148AbjLKGyX (ORCPT + 99 others); Mon, 11 Dec 2023 01:54:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjLKGyW (ORCPT ); Mon, 11 Dec 2023 01:54:22 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C9E4D6 for ; Sun, 10 Dec 2023 22:54:28 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6cef5220d07so498000b3a.2 for ; Sun, 10 Dec 2023 22:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702277668; x=1702882468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K0+jiNBabf5mDupvKR2mxyLiAA9W8b3A/GEvdc87WBA=; b=QZfNGXT1YylcttanzDAQro8DIpxp/D/f5fAX2Nke6MxZwFYvj+BNyuolOESab19G20 IHbJ/tF4xFhdHTpDOTMLPyzsujGooQPsCIsPdb6Y76CL7pHilvu1/ySAVHfESbxfqNM6 6kfOVZrTFgNA8rkqfE8qwvY044BjaUsomacyA7OwA/eNgCRpoqrOivY1bZ93WrhJ9Zyp GAzW91M4JL5KDL0QFit8cayv2K3kgfLosvtwhnoKveYvlMezfLpKa6qGholzbUqoB2Fw FCNUc+ZBM7PYSP/I7IA6fK19cpkXGg6BKRkHVHHEqzZOy4kxhHAqb9QkNmECfmoVChwG eYsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702277668; x=1702882468; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K0+jiNBabf5mDupvKR2mxyLiAA9W8b3A/GEvdc87WBA=; b=rHdGu/1QYqiKMFo/uCgiQ77eGUuWd0ZCMrQO30FFjDRj1BH3BjWgKomiKuZRCOKxG9 Z8YmTyc0VGzNDgcfXmvZJZeZahgdoT73s+HUkXr4gSHbnFlMEbIGeVKXYk6qAHAVuZVt mqi/mh7Yul1RbCf3piEleKNlRW228Dpw/a3DXJS9ci/Oezq7UjDhptVw7K6Znl8OJCay F8tr6JxAe3jBnsVAGlHOzKBbndsOHHXwDe97TNhTS0AqqjdexeOqXeL/arDo1Y/1bCHV UjIYKcmXKwHUO2B12rtYBwnDU0ezObzSJ9BfkfmousHkN9sgiAx6wux1+QruhM0bDJK0 gixQ== X-Gm-Message-State: AOJu0YzxZQkrwUSmDdOkhhAbXFTLXRv2hu5g9GGvHoN9U9lKkelPraAD DjfJ8MqbrCoBBpdFnYD0F3w= X-Received: by 2002:a05:6a00:1749:b0:6ce:2732:1e07 with SMTP id j9-20020a056a00174900b006ce27321e07mr1556995pfc.65.1702277667738; Sun, 10 Dec 2023 22:54:27 -0800 (PST) Received: from toolbox.. ([103.46.201.248]) by smtp.gmail.com with ESMTPSA id r1-20020a62e401000000b006ce91d27c72sm5751054pfh.175.2023.12.10.22.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 22:54:27 -0800 (PST) From: Ayush Singh To: greybus-dev@lists.linaro.org Cc: Ayush Singh , johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jkridner@beagleboard.org, nm@ti.com Subject: [PATCH V2 0/1] Make gb-beagleplay driver Greybus compliant Date: Mon, 11 Dec 2023 12:24:17 +0530 Message-ID: <20231211065420.213664-1-ayushdevel1325@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 10 Dec 2023 22:54:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784967516213427396 X-GMAIL-MSGID: 1784967516213427396 In beagleplay beagleconnect setup, the AP is not directly connected to greybus nodes. The SVC and APBridge tasks are moved to cc1352 coprocessor. This means that there is a need to send cport information between linux host and cc1352. In the initial version of the driver (and the reference implementation gbridge I was using), the greybus header pad bytes were being used. However, this was a violation of greybus spec. The following patchset creates a wrapper around greybus message to send the cport information without using the pad bytes. --- V2: - Add more comments explaining the new greybus hdlc frame payload - Remove msg len warnings. These checks are also performed by `greybus_data_rcvd` and thus no need for it here. V1: https://lists.linaro.org/archives/list/greybus-dev@lists.linaro.org/thread/Y3ELHKLKTP5TQZ5LYKCE6GHWMA3PUOTV/ Ayush Singh (1): greybus: gb-beagleplay: Remove use of pad bytes drivers/greybus/gb-beagleplay.c | 55 ++++++++++++++++++++++++--------- 1 file changed, 41 insertions(+), 14 deletions(-)