mbox series

[v4,0/4] arm64: dts: qcom: Fix the warnings from coresight bindings

Message ID 20231210072633.4243-1-quic_jinlmao@quicinc.com
Headers
Series arm64: dts: qcom: Fix the warnings from coresight bindings |

Message

Mao Jinlong Dec. 10, 2023, 7:26 a.m. UTC 
  Fix all warnings in Qualcomm boards coming from Coresight bindings.

There are warnings below after running dtbs_check. The patches are
to fix them for Qcom boards.

funnel@3023000: 'in-ports' is a required property

etm@7c40000: 'out-ports' is a required property

etf@6047000: in-ports: '#address-cells', '#size-cells', 'port@1'
do not match any of the regexes: 'pinctrl-[0-9]+'

replicator@604a000: in-ports: '#address-cells', '#size-cells',
'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'

funnel@6c2d000: out-ports: '#address-cells', '#size-cells' do not
match any of the regexes: 'pinctrl-[0-9]+'

Warning (graph_child_address): /soc@0/tpda@6004000/out-ports:
graph node has single child node 'port@0', #address-cells/#size-cells
are not necessary

Warning (graph_child_address): /soc@0/funnel@6005000/in-ports: graph
node has single child node 'port@0', #address-cells/#size-cells are
not necessary

Warning (graph_child_address): /soc@0/etf@6b05000/in-ports: graph node
has single child node 'port@0', #address-cells/#size-cells are not
necessary

Warning (graph_child_address): /soc@0/funnel@7810000/in-ports: graph
node has single child node 'port@0', #address-cells/#size-cells are
not necessary

Changes since V3:
1. Modify the indentation of dt binding smaple.

Changes since V2:
1. Remove qcom,inst-id for remote etm.
2. Modify the node name of remote etm dt node.
3. Add space between 'endpoint' and the opening brace.

Changes since V1:
1. Add new dt binding for remote etm.
2. Add new dt node modem-etm in msm8996.dtsi

Mao Jinlong (4):
  dt-bindings: arm: Add remote etm dt-binding
  arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property
  arm64: dts: qcom: msm8998: Fix 'out-ports' is a required property
  arm64: dts: qcom: Fix coresight warnings in in-ports and out-ports

 .../arm/qcom,coresight-remote-etm.yaml        | 51 +++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8996.dtsi         | 21 ++++++++
 arch/arm64/boot/dts/qcom/msm8998.dtsi         | 32 +++++++-----
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |  5 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi          |  5 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          | 24 ++-------
 6 files changed, 98 insertions(+), 40 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml

Comments

Bjorn Andersson Dec. 17, 2023, 5:21 p.m. UTC | #1 
On Sat, 09 Dec 2023 23:26:27 -0800, Mao Jinlong wrote:
> Fix all warnings in Qualcomm boards coming from Coresight bindings.
> 
> There are warnings below after running dtbs_check. The patches are
> to fix them for Qcom boards.
> 
> funnel@3023000: 'in-ports' is a required property
> 
> [...]

Applied, thanks!

[2/4] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property
      commit: 9a6fc510a6a3ec150cb7450aec1e5f257e6fc77b
[3/4] arm64: dts: qcom: msm8998: Fix 'out-ports' is a required property
      commit: ae5ee3562a2519214b12228545e88a203dd68bbd
[4/4] arm64: dts: qcom: Fix coresight warnings in in-ports and out-ports
      commit: bdb6339fd46b8702ea7411b0b414587b86a40562

Best regards,