From patchwork Fri Dec 8 03:27:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 17728 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5220050vqy; Thu, 7 Dec 2023 19:31:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuoW8RP4DAdNssRhg1D22O04SprBg64Cq7Gvo75rvpr2QnyvuK7hTzJGPmA+teMxcwtNOo X-Received: by 2002:a17:90b:3e85:b0:286:2e71:1392 with SMTP id rj5-20020a17090b3e8500b002862e711392mr2965069pjb.9.1702006261942; Thu, 07 Dec 2023 19:31:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702006261; cv=none; d=google.com; s=arc-20160816; b=Op5LCuzn/AiXGb0EQ5CX5eqA0KI0KG8oWWCtZUndzvoAE31d4nf7csypEfX+BpRzzA aQBBRZVS7dyLsmjuq/MhtXdFmPgA6D4c/jJwiakj3Ame199Bet38CTiBosLc8qgOEBQE MgmudEtXyxnR1mDTDMws9sUmnz363GMUyJ2r4oHvj6ybFTPMVEpEUj5l7OPUFPrwCwO2 gHahXs03VYVCP71+QNSbl8/RdHRK9KZ7shUjWNnI7dSql9jVWYoHSEjmeFIeUm7nTGx6 UZjrqkKCaf/tIhsowzIbEbd8YVIDhYIC8EIY7fEQnCKQCIKViXVrqi8CKKI6yyjZl9ir nAzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=G65Y4qEgiFs5r1auMT4tyTQhiN2SiYTb+GC96Qccm+g=; fh=I45k8M33HW2Wqj1OlgncPyvUt41clxPTDAFs+9Wisus=; b=BT8wLtd561fdvpOHTP3A7SqEGAI8z1a6agvRDTeUJ7XkhVDWbn+C0hrcsNvJpJSvvn 12w5heJ+5wE+n06t0IG8Dpgc3on1wj2NBhhufGSm7p6wx5sxeOu4LjbxAqopJYtKbEeG wJMThZeP/snvt3/hNF/SpppFAYOk3iNAxEPEwnDb4flayCoitlpcegARwmhNVM33OnDQ Ba+MNWQ10boF/8lnwP9WHE3Gu4NRmussTTvJ/4QI44+EUFu6PZFZuq/OdxKpe9YCRlXM 0+66LtZgyiDAy5Z67OM6HTZwe9fYwKbylozYS5sf10IW/fqEh5IkVmmfBpfdW3GYlTny LfuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QqJJjPVi; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QqJJjPVi; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id mp6-20020a17090b190600b00286d6caba8esi853494pjb.95.2023.12.07.19.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 19:31:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QqJJjPVi; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QqJJjPVi; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 7171B81F364F; Thu, 7 Dec 2023 19:30:56 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573082AbjLHDa0 (ORCPT + 99 others); Thu, 7 Dec 2023 22:30:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235639AbjLHDaZ (ORCPT ); Thu, 7 Dec 2023 22:30:25 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FD7E1716; Thu, 7 Dec 2023 19:30:30 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6FD241FD97; Fri, 8 Dec 2023 03:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702006229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G65Y4qEgiFs5r1auMT4tyTQhiN2SiYTb+GC96Qccm+g=; b=QqJJjPVi8L132GZQCf9Mjg4qHmcrXYlzYlU0DUuZ/CNjEeG/g/4jCnoDTq0VPA4h42/djF WA4ez4vqERGV49PtRqCLw1ob0Oc4JoAyuOgA6mvx/jTIRRvE6VQGb7blpiovuLYSRRVbRM /dXYFTepmmr13rL3so9HLP/GCV/557s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702006229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G65Y4qEgiFs5r1auMT4tyTQhiN2SiYTb+GC96Qccm+g=; b=NuiDxDxaPzIHywKsjWJ7egknyJgVFHbzTDAMaKPhLbLzE0V4XEebt5Rn6wlcw/fDbhoW4M UZVCk9lYJgtoGBBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702006229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G65Y4qEgiFs5r1auMT4tyTQhiN2SiYTb+GC96Qccm+g=; b=QqJJjPVi8L132GZQCf9Mjg4qHmcrXYlzYlU0DUuZ/CNjEeG/g/4jCnoDTq0VPA4h42/djF WA4ez4vqERGV49PtRqCLw1ob0Oc4JoAyuOgA6mvx/jTIRRvE6VQGb7blpiovuLYSRRVbRM /dXYFTepmmr13rL3so9HLP/GCV/557s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702006229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G65Y4qEgiFs5r1auMT4tyTQhiN2SiYTb+GC96Qccm+g=; b=NuiDxDxaPzIHywKsjWJ7egknyJgVFHbzTDAMaKPhLbLzE0V4XEebt5Rn6wlcw/fDbhoW4M UZVCk9lYJgtoGBBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A88E13725; Fri, 8 Dec 2023 03:30:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9ogpN9CNcmXwMAAAD6G6ig (envelope-from ); Fri, 08 Dec 2023 03:30:24 +0000 From: NeilBrown To: Al Viro , Christian Brauner , Jens Axboe , Oleg Nesterov , Chuck Lever , Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH 0/3] nfsd: fully close all files in the nfsd threads Date: Fri, 8 Dec 2023 14:27:25 +1100 Message-ID: <20231208033006.5546-1-neilb@suse.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Score: 3.70 Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 3.70 X-Spamd-Result: default: False [3.70 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.983]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[40.26%] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 07 Dec 2023 19:30:57 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784682918190075580 X-GMAIL-MSGID: 1784682918190075580 This is a new version of my patches to address a rare problem with nfsd closing files faster than __fput() can complete the close in a different thread. This time I'm simply switching to __fput_sync(). I cannot see any reason that this would be a problem, but if any else does and can show me what I'm missing, I'd appreciate it. Thanks, NeilBrown [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of [PATCH 2/3] nfsd: Don't leave work of closing files to a work queue. [PATCH 3/3] VFS: don't export flush_delayed_fput(). Reviewed-by: Jeff Layton Reviewed-by: Jens Axboe