From patchwork Thu Dec 7 22:26:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 17717 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5100963vqy; Thu, 7 Dec 2023 14:27:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCAD8Pf5JdeIOUvMOvomwBbHpeounykGFBtKW2tgZnXAD8B5dMqzhEW7U5T5ZOi0Y+iBU0 X-Received: by 2002:a05:6a00:80a:b0:6cd:e063:3646 with SMTP id m10-20020a056a00080a00b006cde0633646mr3858681pfk.28.1701988043690; Thu, 07 Dec 2023 14:27:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701988043; cv=none; d=google.com; s=arc-20160816; b=BfvANGhUHBCTh7E4H/K+W0DLJ7B8jJboqVE+uOo2uABcq8S/WMO/1kpu137nhb04GN nN5PpOojThiSy7dSHjmJkcpSBw4djCMKkH1qChy0eTv20tP4tBX9eN9LTYZiInQz/SK1 3cwJCNUDjGbL5OkFgXoH6N+IiqV+aZHB9jmjKoco3+OXw/qCEohxxRQKLDX5lwbi8Th0 jjxj5OfmIMx5tk5idWmOPYdCAUgcEBHzGbU+kBig0HTi2ypJwMG7ODJRIoc5nYFevhwv G8YHD92Upr48cd/1zn9JdsftDbrOjTPiqZ7EXkhVGR8QZYEzca/yRyTIqsBZxxRZNewl 9nCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=IgDSjPHujq0pfKC4CYKly/X/QO3tg5CB3pNcvggpNoY=; fh=li8yxIESWfZR7lmBO8wCmgOg4WdXsWPyQvEuWPhaOvo=; b=Idt1MtBgJrZXAHSi7J4yC45tuObi+ymP5JObw/0xlhkySnoV26tjuCGoFRKInmXxRP VOks8kc1xC9WVR4Oa+83XoiZ1qXAbGGJUjzdrmNL5bt4+nyssDTnlHi2yiRT352uA7BU TZzrL15/04WcWFAWrsx5Kg18V6j3hdcQRm0lDHgELzOInIRtnb7XYS7hMmVlGGctztwP ai/Z2m5UgPNaNkK8mtqp3rcWmVo+Akd3+RomPEAZlKHf3SYOyjTAek3dBNaqT/UfcmjW mtvTkML/2wWHUe5lVWJtL+28wJ1vI+SdMs6h9IAVgrdLTSva7RKgyQU+AtU2deSsiiPX rK+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=pC5qFLaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id kp12-20020a056a00464c00b006ce45456a0esi404090pfb.46.2023.12.07.14.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 14:27:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=pC5qFLaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9F12B833AB07; Thu, 7 Dec 2023 14:27:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235372AbjLGW1D (ORCPT + 99 others); Thu, 7 Dec 2023 17:27:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232365AbjLGW0z (ORCPT ); Thu, 7 Dec 2023 17:26:55 -0500 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3030170F; Thu, 7 Dec 2023 14:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1701987996; x=1702592796; i=w_armin@gmx.de; bh=MgzcGVPKoqfJELwV3CzTRBVexp97HcHn6k8nAs0yc08=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=pC5qFLaOiFTDVxkVktFEMNHu+evSRL9sPTF3IEPpoyTtssn2e/mUf/YVmiuAQW05 2+WtvdT1CUnYm8Hs3Kv9zh+qGHJDfZ0LnNXTFrOVTGuXJQ3z86wjPLrIbFO0bALMa 2UiHBY0g0+nRnxqZ9EstRuXddP79WlUEq0eX9V0kTzT4GPpz8Ca4IOJiwy0r4YVhx Gi7vgPydqztRWI1f6EvFUUqK3PdR/rWDBxGy5zX8z9FVGijXMHxPNhgblJx6fHASg AUBtO0GRafpQtU0RYmwDoWhBAN+xuUVP+A2Iv/MrFcOekjJQkrYgZOaIZ/r2C4Ay6 fKEWKejoaNKwLRjomA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDEm-1rbw9U2DMe-00iB3d; Thu, 07 Dec 2023 23:26:36 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, corbet@lwn.net Cc: Dell.Client.Kernel@dell.com, linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] platform/x86: wmi: Cleanup obsolete features Date: Thu, 7 Dec 2023 23:26:18 +0100 Message-Id: <20231207222623.232074-1-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:+V6s3WudzRkc/3U5Azxmw82Gi8PIOKICgFml6vaMiONzNt8X8D8 RdOQHPqXh6/Hpe7zxdER4A8Pa9R3U6NuTYzY8E1c1jeS+EULdbuOHnBLZ1rXBfPPBCRui2d WRW13bHWUnXgiKnrn4Xo8/NBZfs0P77LeidQZNV4DYz3o1xK1hDDLBKtPTsXfILhSI9cXRB 5e9YyjXV/HEr1K6QTnfNA== UI-OutboundReport: notjunk:1;M01:P0:Dhn/0EMwgHQ=;bxz3HihOqtq6cwc3l0KTYBCsPSW wf72mfYMm7eX55hx+eeTQJGxrhz1ktttzeesaMkMgV0Fc7T30HOXyDr8gD7tbbYRdpNpIAOI9 ZgfbTkxdeQ2awZWbNxUPy1SDJWs6NPARPJr32iYLVRCeqIbBVDoAXl/Ob2XI3zuKywkTRIrMZ YLkt+A6zaSRuT/4ovnGGF2b0aPMJRPN3yCJpMOjjKOfS3/BQYlhJ+eKmfdZnfSVaBAXwODct7 FkMV2oK2Agc4A0VyAaua6NxL+kvXAwqiFYIFtmvfKpWWvbK7Gb7uGMSzfUmVyjdUyxiGRGie5 GXxnYFXViir9LdXZcITCRZxNO0py8VeSxjKiCGBiFBiLUZhDlvb0sHo0hTwEMLEtSW8Co36ja n9o53ZSeo8g0QW0X6sWzEIhKlp6tSJloKfe0rK4ZSscUczneUW3UvXhMlOYwYjFkTircH2FoJ W0QUIeRdNFeEQ1qjNrakaTrlafdJVbwR8+J5lXgg1q9wkOvpM+YVdvnWOdoH4zFJUX7ycFPgA apQx9uHk2oi0rRmJsynYYxk5NTQhHObLfUvvLVbwNtzbAe32R0U4v4dEzFyhx8/3MBmzGRGtZ NIlJCTY6VgkzTb8BtoKPltgVk8Tpqzlm7KQ4ejViik3UKOqA1zkUZmw6h+VPmZtiR58/MmCED mw6QWohWpbSenwDpPLPnKp+BCQxEKNddZZQRELDj0W9afSZiLSuk33XfKZIbTL3Blrj6jlhFc fcKjCg1fFO986Y38KL0mD3cH2OyBYrVsFr+MaY6kvA/2r/+FDWCgOznQqtiDh6xlPQ+J0KweS HZM6UBSLda5ghrGgtaMJG6hrt2a42HlhMaHc73PXRGSxR6xTcOAqcTc45nb1O+T9/hMlvXa5m GOsWU0T6aMwWchxlp3dOsTxmk0N+de8VJKw6zdjjk5aO3nFAyMqGPOySPjPTAn0GbX4dnTZ3W qVPJWbHzNN9AGpGcSochRoZ6H9k= X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 07 Dec 2023 14:27:19 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784663814747222174 X-GMAIL-MSGID: 1784663814747222174 This patch series removes three features deemed obsolete: - the debug_dump_wdg module param: - suffers from garbled output due to pr_cont() - functionality is better provided by "fwts wmi" - the debug_event module param: - pr_cont() usage - uses the deprecated GUID-based API - largely replaced by the ACPI netlink interface - ioctl interface - used only by a single driver, no adoption otherwise - numerous design issues Since the ioctl interface is actually used by userspace programs, the only user (the dell-smbios-wmi driver) was modified to implement the necessary pieces itself so that no regressions are expected. The last patch in contrast adds a short WMI driver development guide to the WMI subsystem documentation, so that driver developers stop submitting WMI drivers using the deprecated GUID-based interface. The series depends on commit cbf54f37600e ("platform/x86: wmi: Skip blocks with zero instances"), which is currently in the "fixes" tree. All patches where tested on a Dell Inspiron 3505 and work without issues. Armin Wolf (5): platform/x86: wmi: Remove debug_dump_wdg module param platform/x86: wmi: Remove debug_wmi module param platform/x86: dell-smbios-wmi: Stop using WMI chardev platform/x86: wmi: Remove chardev interface platform/x86: wmi: Add driver development guide .../wmi/driver-development-guide.rst | 126 ++++++++ Documentation/wmi/index.rst | 1 + drivers/platform/x86/dell/dell-smbios-wmi.c | 163 +++++++--- drivers/platform/x86/wmi.c | 285 +----------------- include/linux/wmi.h | 8 - 5 files changed, 256 insertions(+), 327 deletions(-) create mode 100644 Documentation/wmi/driver-development-guide.rst --- 2.39.2