mbox series

[v2,0/4] media: rkisp1: Fix IRQ related issues

Message ID 20231206-rkisp-irq-fix-v2-0-6ba4185eeb1f@ideasonboard.com
Headers
Series media: rkisp1: Fix IRQ related issues |

Message

Tomi Valkeinen Dec. 6, 2023, 10:12 a.m. UTC 
  These fix a few IRQ related issues I noticed when testing i.MX8MP. These
are based on Paul's recently sent "[PATCH v4 00/11] media: rkisp1: Add
support for i.MX8MP" series, but could also be rebased on top of
mainline if needed.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Changes in v2:
- New patch: "media: rkisp1: Drop IRQF_SHARED"
- Update "media: rkisp1: Fix IRQ handler return values" according to
  Laurent's comment.
- Drop "media: rkisp1: Fix IRQ handling due to shared interrupts"
- Update description for "media: rkisp1: Fix IRQ disable race issue"
- Link to v1: https://lore.kernel.org/r/20231205-rkisp-irq-fix-v1-0-f4045c74ba45@ideasonboard.com

---
Tomi Valkeinen (4):
      media: rkisp1: Drop IRQF_SHARED
      media: rkisp1: Fix IRQ handler return values
      media: rkisp1: Store IRQ lines
      media: rkisp1: Fix IRQ disable race issue

 .../media/platform/rockchip/rkisp1/rkisp1-common.h | 11 ++++++-
 .../media/platform/rockchip/rkisp1/rkisp1-csi.c    | 14 +++++++-
 .../media/platform/rockchip/rkisp1/rkisp1-dev.c    | 37 ++++++++++++++++------
 .../media/platform/rockchip/rkisp1/rkisp1-isp.c    | 20 ++++++++++--
 4 files changed, 67 insertions(+), 15 deletions(-)
---
base-commit: dd19f89b915c203d49e3b23ca02446d4fb05d955
change-id: 20231205-rkisp-irq-fix-e123a8a6732f

Best regards,

Comments

Adam Ford Dec. 6, 2023, 11:43 a.m. UTC | #1 
On Wed, Dec 6, 2023 at 4:12 AM Tomi Valkeinen
<tomi.valkeinen@ideasonboard.com> wrote:
>
> These fix a few IRQ related issues I noticed when testing i.MX8MP. These
> are based on Paul's recently sent "[PATCH v4 00/11] media: rkisp1: Add
> support for i.MX8MP" series, but could also be rebased on top of
> mainline if needed.
>
I applied the whole series on top of your DMA patch and the series
from Paul porting the rkisp1 to the imx8mp and ran the camera for 15
minutes streaming to my monitor.  I didn't see any glitches or video
distortion at 640x480.

For the series...

Tested-by: Adam Ford <aford173@gmail.com>  #imx8mp-beacon

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> Changes in v2:
> - New patch: "media: rkisp1: Drop IRQF_SHARED"
> - Update "media: rkisp1: Fix IRQ handler return values" according to
>   Laurent's comment.
> - Drop "media: rkisp1: Fix IRQ handling due to shared interrupts"
> - Update description for "media: rkisp1: Fix IRQ disable race issue"
> - Link to v1: https://lore.kernel.org/r/20231205-rkisp-irq-fix-v1-0-f4045c74ba45@ideasonboard.com
>
> ---
> Tomi Valkeinen (4):
>       media: rkisp1: Drop IRQF_SHARED
>       media: rkisp1: Fix IRQ handler return values
>       media: rkisp1: Store IRQ lines
>       media: rkisp1: Fix IRQ disable race issue
>
>  .../media/platform/rockchip/rkisp1/rkisp1-common.h | 11 ++++++-
>  .../media/platform/rockchip/rkisp1/rkisp1-csi.c    | 14 +++++++-
>  .../media/platform/rockchip/rkisp1/rkisp1-dev.c    | 37 ++++++++++++++++------
>  .../media/platform/rockchip/rkisp1/rkisp1-isp.c    | 20 ++++++++++--
>  4 files changed, 67 insertions(+), 15 deletions(-)
> ---
> base-commit: dd19f89b915c203d49e3b23ca02446d4fb05d955
> change-id: 20231205-rkisp-irq-fix-e123a8a6732f
>
> Best regards,
> --
> Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>