From patchwork Mon Dec 4 14:43:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 17502 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2809633vqy; Mon, 4 Dec 2023 06:45:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8lN6JVaYGIM4Q/HigiG0iAd2pkmdxIMKk6nlrYJhdBi1tQLgm87OE/tpibh4yoiFZQhP8 X-Received: by 2002:a05:6358:33a4:b0:16b:f950:3d83 with SMTP id i36-20020a05635833a400b0016bf9503d83mr3636652rwd.31.1701701130141; Mon, 04 Dec 2023 06:45:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701701130; cv=none; d=google.com; s=arc-20160816; b=BWWhNKGQW+E5pvBjmooloytttcFQBmCh8f3Kqfm4uwtwTUE+kXEE3AIQTxEAxJHYn5 JjKQBwAZaIRBCyqzgU5D0xIsRYglgZBwOycoDromDToZRmbRzkLG0IXkE37BVLqd85KK QUadG4WRd9gteoXgZvtJG5T+FS8k2bxRK0g+/CxDVMEDZK9jjosm5w/Ea3wXYnK4hu6i LaoFNx7kWkn601cVcY0MbgTMqIzTRyIOdoexUMO9cg9j8UOqtzXsSDAEpVSKOwWSRcv8 +VUb2H2zMxetSP1DJFqif68l2qiI+jVX69p0fQt337AbiAcjJf3Up4r7O1HTjEpPbKmv jpOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=EhQi3onL9GpEqJYUYdTVsT5Q2f0NwXP08T0ndFJ/c7M=; fh=aAPqvXm40pY9772UiBOljEePwtz/3Q0zIOpw238tj3M=; b=p91gd5nnMTGovrEch7QI9IcipEib0+CbPtS2rsGFcJdRnjFlg3IDqZP+YX/vEUC/+5 1VRkIXYOByAOYE3bKnGkOjW1Z+yCErbcyjTa+IZbGwfhF+nEUMuq/bnbdkR5V+0Va/cE E2NHwyTNVKubLBlOFS60MMw9XU2v22jYKTsepgLz7kpwI4lHAUNOXXFwYSYV1ruD4O7G szMJVCIKteQ2bjFIFkylr2SnvnfsLbW5HBfRcIUKrtGScP77pOr6IwTl7YEh7c2lUxdh CZ253MoQ1DbxwIjgG8R5sNzgjc8F40i3YMheqM4kEImFOEBzlDqzt2qjErCES7LZ4Bnp SnZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=aTxlUtH0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q5-20020a632a05000000b005c66130e967si3679311pgq.264.2023.12.04.06.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:45:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=aTxlUtH0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 58C7B8059DB7; Mon, 4 Dec 2023 06:45:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345957AbjLDOoZ (ORCPT + 99 others); Mon, 4 Dec 2023 09:44:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235874AbjLDOoP (ORCPT ); Mon, 4 Dec 2023 09:44:15 -0500 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA8EFD; Mon, 4 Dec 2023 06:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:To:From; bh=EhQi3onL9GpEqJYUYdTVsT5Q2f0NwXP08T0ndFJ/c7M=; b=aTxlUtH06 VlLvCE9ceDi8kZAqPwZofP2Wp9wkcSYAWChi0ExMNgvIzt+1sbkygWUSu/qkm5fD6fdnFAwM0tiy6 Nr9uCHWMmqY3npFk8DCYOgKus5MJ22786Ii2KZJghUQN9Jea+POrOkaDZiYFt0gn/n9Xw28R3fI49 28d9t3Xs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rAAAs-0003d8-1y; Mon, 04 Dec 2023 14:43:54 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=REM-PW02S00X.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAAAr-00088g-Ng; Mon, 04 Dec 2023 14:43:53 +0000 From: Paul Durrant To: Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Woodhouse , Paul Durrant , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v10 00/19] KVM: xen: update shared_info and vcpu_info handling Date: Mon, 4 Dec 2023 14:43:15 +0000 Message-Id: <20231204144334.910-1-paul@xen.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:45:25 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784362964264353643 X-GMAIL-MSGID: 1784362964264353643 From: Paul Durrant There are four new patches in the series over what was in version 9 [1]: * KVM: xen: separate initialization of shared_info cache and content * KVM: xen: (re-)initialize shared_info if guest (32/64-bit) mode is set These deal with a missing re-initialization of shared_info if either the guest or VMM changes the 'long_mode' flag. This was discovred in testing when the guest wallclock reverted to the Unix epoch because the pvclock information in the shared_info page was not in the correct place, and so the guest read zeroes instead. * KVM: xen: don't block on pfncache locks in kvm_xen_set_evtchn_fast() * KVM: pfncache: check the need for invalidation under read lock first The first of these fixes a bug discovered when compiling the kernel with CONFIG_PROVE_RAW_LOCK_NESTING: kvm_xen_set_evtchn_fast() can be called from the callback of a HRTIMER_MODE_ABS_HARD timer and hence be executed in IRQ context. It should therefore not block on any lock. Thus two occurrences of a read_lock() are converted to a read_trylock() which kick the code down a slow-path if they fail. The second patch removes a 'false' contention on the pfncache lock that could result in taking that slow-path: the MMU notifier callback need only take a pfncache read lock; it only need take a write lock if a match is found. Apart from these new patches... * KVM: xen: split up kvm_xen_set_evtchn_fast() ... has been re-worked to (hopefully) improve readability and also validate the 'correct' vcpu_info structure depending on whether the guest is in long mode or not. [1] https://lore.kernel.org/kvm/20231122121822.1042-1-paul@xen.org/ Paul Durrant (19): KVM: pfncache: Add a map helper function KVM: pfncache: remove unnecessary exports KVM: xen: mark guest pages dirty with the pfncache lock held KVM: pfncache: add a mark-dirty helper KVM: pfncache: remove KVM_GUEST_USES_PFN usage KVM: pfncache: stop open-coding offset_in_page() KVM: pfncache: include page offset in uhva and use it consistently KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA KVM: xen: separate initialization of shared_info cache and content KVM: xen: (re-)initialize shared_info if guest (32/64-bit) mode is set KVM: xen: allow shared_info to be mapped by fixed HVA KVM: xen: allow vcpu_info to be mapped by fixed HVA KVM: selftests / xen: map shared_info using HVA rather than GFN KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability KVM: xen: split up kvm_xen_set_evtchn_fast() KVM: xen: don't block on pfncache locks in kvm_xen_set_evtchn_fast() KVM: pfncache: check the need for invalidation under read lock first KVM: xen: allow vcpu_info content to be 'safely' copied Documentation/virt/kvm/api.rst | 53 ++- arch/x86/kvm/x86.c | 7 +- arch/x86/kvm/xen.c | 358 +++++++++++------- include/linux/kvm_host.h | 40 +- include/linux/kvm_types.h | 8 - include/uapi/linux/kvm.h | 9 +- .../selftests/kvm/x86_64/xen_shinfo_test.c | 59 ++- virt/kvm/pfncache.c | 185 ++++----- 8 files changed, 461 insertions(+), 258 deletions(-) base-commit: 1ab097653e4dd8d23272d028a61352c23486fd4a