mbox series

[v5,0/3] Fix the failure of adding phy with zero-address to port

Message ID 20231204122932.55741-1-yangxingui@huawei.com
Headers
Series Fix the failure of adding phy with zero-address to port |

Message

yangxingui Dec. 4, 2023, 12:29 p.m. UTC 
  This series is to solve the problem of a BUG() when adding phy with zero
address to a new port.

v4 -> v5
1. Add new helper sas_port_add_ex_phy() based on John's suggestion.
2. Move sas_add_parent_port() to sas_expander.c based on John's suggestion.
3. Update the comments.

v3 -> v4:
1. Update patch title and comments based on John's suggestion.

v2 -> v3:
1. Set ex_dev->parent_port to NULL when the number of PHYs of the parent
   port becomes 0.
2. Update the comments.

v1 -> v2:
1. Set ex_phy->port with parent_port when ex_phy is added to the parent
   port.
2. Set ex_phy to NULL when free expander.
3. Update the comments.

Xingui Yang (3):
  scsi: libsas: Add helper for port add ex_phy
  scsi: libsas: Move sas_add_parent_port() to sas_expander.c
  scsi: libsas: Fix the failure of adding phy with zero-address to port

 drivers/scsi/libsas/sas_expander.c | 34 ++++++++++++++++++++++++------
 drivers/scsi/libsas/sas_internal.h | 15 -------------
 2 files changed, 28 insertions(+), 21 deletions(-)

Comments

John Garry Dec. 4, 2023, 1:08 p.m. UTC | #1 
On 04/12/2023 12:29, Xingui Yang wrote:
> This moves the process of adding ex_phy to a port into a new helper.
> 
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>
> ---

Reviewed-by: John Garry <john.g.garry@oracle.com>