mbox series

[v1,0/2] hwmon: Driver for Nuvoton NCT736X

Message ID 20231204055650.788388-1-kcfeng0@nuvoton.com
Headers
Series hwmon: Driver for Nuvoton NCT736X |

Message

Ban Feng Dec. 4, 2023, 5:56 a.m. UTC 
  From: Ban Feng <baneric926@gmail.com>

NCT736X is an I2C based hardware monitoring chip from Nuvoton.

Ban Feng (2):
  dt-bindings: hwmon: Add nct736x bindings
  hwmon: Driver for Nuvoton NCT736X

 .../bindings/hwmon/nuvoton,nct736x.yaml       |  80 +++
 Documentation/hwmon/index.rst                 |   1 +
 Documentation/hwmon/nct736x.rst               |  35 ++
 MAINTAINERS                                   |   8 +
 drivers/hwmon/Kconfig                         |  10 +
 drivers/hwmon/Makefile                        |   1 +
 drivers/hwmon/nct736x.c                       | 479 ++++++++++++++++++
 7 files changed, 614 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml
 create mode 100644 Documentation/hwmon/nct736x.rst
 create mode 100644 drivers/hwmon/nct736x.c

Comments

Guenter Roeck Dec. 4, 2023, 7:04 a.m. UTC | #1 
On 12/3/23 21:56, baneric926@gmail.com wrote:
> From: Ban Feng <baneric926@gmail.com>
> 
> NCT736X is an I2C based hardware monitoring chip from Nuvoton.
> 

No, it isn't. Such a chip does not exist. The chips are apparently
NCT7362Y and NCT7363Y. No wildcards in filenames, variables, etc.,
please. Pick one name (nct7362y) instead and reference both chips
where appropriate.

Guenter
Ban Feng Dec. 5, 2023, 7 a.m. UTC | #2 
On Mon, Dec 4, 2023 at 3:04 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 12/3/23 21:56, baneric926@gmail.com wrote:
> > From: Ban Feng <baneric926@gmail.com>
> >
> > NCT736X is an I2C based hardware monitoring chip from Nuvoton.
> >
>
> No, it isn't. Such a chip does not exist. The chips are apparently
> NCT7362Y and NCT7363Y. No wildcards in filenames, variables, etc.,
> please. Pick one name (nct7362y) instead and reference both chips
> where appropriate.
>

This driver is based on nct7363y, so I'll rename all to NCT7363Y in v2.

Thanks,
Ban