Message ID | 20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2921718vqy; Mon, 4 Dec 2023 09:35:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+THZKEHt94dPPzw6g5XUQNanIfDrLeplTifKtm5Vx450ExWhtMPixCmDwwPPrbpHWpkas X-Received: by 2002:a92:ab01:0:b0:35d:72c7:8306 with SMTP id v1-20020a92ab01000000b0035d72c78306mr1374771ilh.65.1701711344690; Mon, 04 Dec 2023 09:35:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701711344; cv=none; d=google.com; s=arc-20160816; b=VTgbfMHyprnOeauWAZxGo1bdnY6vz2klcOXoaD8xL+rA4iL2E/eranocUROtkW3pj9 nWLQqjum+B2F6DSjRsYB/HmdfCe5m8Bnd0NAWos4zOsrTnuhdjl1007n2rj4vEg56GDl lHCHZuSaHsidlNIPu52NC7j0GCWiRWuw2cNOeJCroryhpiHG+BAh+TOf+4skxwda0KLE XR08HkuHaXTJK6jbJMyPD1wRFg4Lv2vNT6K8ltpglTwQBcQ2XrZLjUlsT49gS6oTddkS /kQDMgT1s/1aEoaKV8Q/vaRVo1WteBwWntnLAnyCKL+MUHYu2d33cewXVAFCnDYlDRBa b5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uSgbctHdB3nT3F64Pa0svm72epawKOhkGz5KAA6x7XU=; fh=GRROeNtucQPE8Xh4DNmNbCVm0YdyVGd8Gl7IJ84MALg=; b=oOhV97ZC5FC8jYl3D5Z4oR8U/anXUGXlPpEwM4yQi4Mt+ngdJ2xzw3n5auPs+L77jh qM92GeYiaySgmQUJdDoXGDzoNUwsQ97Mw95aStook7X+TDGln2MzT6Iu0zBsUJYlK3od p3mhsTzGXiM1XD1eK2xCbUZywHviGzZKZaocZU02xllkd/t02pXA0jBvQOH2NvPQoXXp NK2ScooXYqo8xj52dq7ko6DUtUtua2HnUWe98HdXsODnCg4MqotInLp0Fq2Ir51nN8fZ kB3IJDWHGCOoD/VwpGhAOn5/NwZTD3bltw5vXEgW0qE/HOvFaWOyjztBXHuE+EfNe2sf 58Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=yNxFS4yZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id s26-20020a65691a000000b005c66b0c9dd7si3611394pgq.786.2023.12.04.09.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 09:35:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=yNxFS4yZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D634C8083ABB; Mon, 4 Dec 2023 09:35:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229488AbjLDRfM (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Mon, 4 Dec 2023 12:35:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234888AbjLDRfD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 4 Dec 2023 12:35:03 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5033A129 for <linux-kernel@vger.kernel.org>; Mon, 4 Dec 2023 09:35:09 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6d858670630so2500476a34.0 for <linux-kernel@vger.kernel.org>; Mon, 04 Dec 2023 09:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1701711308; x=1702316108; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uSgbctHdB3nT3F64Pa0svm72epawKOhkGz5KAA6x7XU=; b=yNxFS4yZHpi2urwGRYlxv3gMUuSd/nEIq6nqv/B2NaxzsqTIUBAWBcJo0xBVVN8Ojo GATMjxQtA2VMfCyKsLDkijbYy4NjiPqgxbtKsWn2ms/P7npV0ZhqcICMvMhf4y3NXXus +1cJAyhHJb95UYN70CnDPG9AwQh+hfMpO5a7Y1wRpBeFy7tV/s8vku40Kr3OsseoAPit 26NlrOJmbE8g2YNrZHvbJfXNqWQe8SptvrqissbAIT7H0pcSIAG/FzC6pp6KIuBR3sga YsDI6MIRpYRn0MfBKidNb0zo/YicQ8C0Bi+6mDnq0d/8dvW+G7z56zbmU71h6YEQ62wM k5Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701711308; x=1702316108; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uSgbctHdB3nT3F64Pa0svm72epawKOhkGz5KAA6x7XU=; b=TlVZCc6E9Jlh1ZV/EXEAJhBhxhqaY2eE1/Fid4ur4BKlJa6jsAAYuQq3qj2P379AEd KreqvjOBOMwl2rBtxItFg6gCbJiV7Ah6PsLMcV4FLkownvCtwqc+ZYLu6CPPWVIXNQQH udS3rVSD72fWqOlOdoBv9VF4yYYwAn2GFqiNS5+IAzwzJFGQ9xpOSsmyx05RQvdRi5Hw 6saj4AllPSxYkqQ0dORislrT3O8DzXgV9uj5jq2mFnxS7YzZOdY38JOAbcH79IbCKbFW +eW/zqNIEKr4u1JX+Iva0Vcz0xwD87z7A7zKbr9mzN8LSXXmKEIQ8WwL+EKL5fBighee nfKg== X-Gm-Message-State: AOJu0YxL9555BF338OFVpLH0Os/MnVtzpTtNEPqxbkTDD7tFaMOa9/WB KPLaOLeE+9u248bNt+65dXvy4XmZbvlihfyL4bs= X-Received: by 2002:a05:6830:2a8a:b0:6d8:74e2:b009 with SMTP id s10-20020a0568302a8a00b006d874e2b009mr7388038otu.71.1701711308682; Mon, 04 Dec 2023 09:35:08 -0800 (PST) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id b16-20020a9d5d10000000b006ce2fce83cbsm1956563oti.25.2023.12.04.09.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 09:35:08 -0800 (PST) From: David Lechner <dlechner@baylibre.com> To: linux-spi@vger.kernel.org Cc: David Lechner <dlechner@baylibre.com>, Mark Brown <broonie@kernel.org>, Michael Hennerich <michael.hennerich@analog.com>, =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de> Subject: [PATCH 0/9] spi: axi-spi-engine: improvements round 2 Date: Mon, 4 Dec 2023 11:33:26 -0600 Message-ID: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 09:35:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784373675146226234 X-GMAIL-MSGID: 1784373675146226234 |
Series |
spi: axi-spi-engine: improvements round 2
|
|
Message
David Lechner
Dec. 4, 2023, 5:33 p.m. UTC
We are working towards adding support for the offload feature [1] of the AXI SPI Engine IP core. Before we can do that, we want to make some general fixes and improvements to the driver. In order to avoid a giant series with 35+ patches, we are splitting this up into a few smaller series. This is a continuation of the work started in [2] which has been applied to spi/for-6.8 [3]. This series must be applied on top of that series to apply cleanly. Once this series is applied, we will follow up with the 3rd series that implements the offload support. The offload support will also involve the IIO subsystem (a new IIO driver will depend on the new SPI offload feature), so I'm mentioning this now in case we want to do anything ahead of time to prepare for that (e.g. putting all of these changes on a separate branch). [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload [2]: https://lore.kernel.org/linux-spi/20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/ [3]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-6.8 --- David Lechner (9): spi: axi-spi-engine: return void from spi_engine_compile_message() spi: axi-spi-engine: populate xfer->effective_speed_hz spi: axi-spi-engine: remove spi_engine_get_clk_div() spi: axi-spi-engine: fix sleep ticks calculation spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() spi: axi-spi-engine: implement xfer->cs_change_delay spi: axi-spi-engine: restore clkdiv at end of message spi: axi-spi-engine: remove delay from CS assertion spi: axi-spi-engine: add watchdog timer drivers/spi/spi-axi-spi-engine.c | 116 ++++++++++++++++++++++++++------------- 1 file changed, 77 insertions(+), 39 deletions(-) --- base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0
Comments
On Mon, 2023-12-04 at 11:33 -0600, David Lechner wrote: > We are working towards adding support for the offload feature [1] of the > AXI SPI Engine IP core. Before we can do that, we want to make some > general fixes and improvements to the driver. In order to avoid a giant > series with 35+ patches, we are splitting this up into a few smaller > series. > > This is a continuation of the work started in [2] which has been applied > to spi/for-6.8 [3]. This series must be applied on top of that series to > apply cleanly. > > Once this series is applied, we will follow up with the 3rd series that > implements the offload support. The offload support will also involve > the IIO subsystem (a new IIO driver will depend on the new SPI offload > feature), so I'm mentioning this now in case we want to do anything > ahead of time to prepare for that (e.g. putting all of these changes on > a separate branch). > > [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload > [2]: > https://lore.kernel.org/linux-spi/20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/ > [3]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-6.8 > > --- Acked-by: Nuno Sa <nuno.sa@analog.com> > David Lechner (9): > spi: axi-spi-engine: return void from spi_engine_compile_message() > spi: axi-spi-engine: populate xfer->effective_speed_hz > spi: axi-spi-engine: remove spi_engine_get_clk_div() > spi: axi-spi-engine: fix sleep ticks calculation > spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() > spi: axi-spi-engine: implement xfer->cs_change_delay > spi: axi-spi-engine: restore clkdiv at end of message > spi: axi-spi-engine: remove delay from CS assertion > spi: axi-spi-engine: add watchdog timer > > drivers/spi/spi-axi-spi-engine.c | 116 ++++++++++++++++++++++++++------------- > 1 file changed, 77 insertions(+), 39 deletions(-) > --- > base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 > change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0
> -----Original Message----- > From: Nuno Sá <noname.nuno@gmail.com> > Sent: Dienstag, 5. Dezember 2023 16:12 > To: David Lechner <dlechner@baylibre.com>; linux-spi@vger.kernel.org > Cc: Mark Brown <broonie@kernel.org>; Hennerich, Michael > <Michael.Hennerich@analog.com>; Sa, Nuno <Nuno.Sa@analog.com>; linux- > kernel@vger.kernel.org; Lars-Peter Clausen <lars@metafoo.de> > Subject: Re: [PATCH 0/9] spi: axi-spi-engine: improvements round 2 > > > On Mon, 2023-12-04 at 11:33 -0600, David Lechner wrote: > > We are working towards adding support for the offload feature [1] of > > the AXI SPI Engine IP core. Before we can do that, we want to make > > some general fixes and improvements to the driver. In order to avoid a > > giant series with 35+ patches, we are splitting this up into a few > > smaller series. > > > > This is a continuation of the work started in [2] which has been > > applied to spi/for-6.8 [3]. This series must be applied on top of that > > series to apply cleanly. > > > > Once this series is applied, we will follow up with the 3rd series > > that implements the offload support. The offload support will also > > involve the IIO subsystem (a new IIO driver will depend on the new SPI > > offload feature), so I'm mentioning this now in case we want to do > > anything ahead of time to prepare for that (e.g. putting all of these > > changes on a separate branch). > > > > [1]: > > https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload > > [2]: > > https://urldefense.com/v3/__https://lore.kernel.org/linux-spi/20231117 > > -axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/__;!!A3Ni8CS0y > > > 2Y!4P8x0PlUachyveotKnjDl76l9lcBm5HvGgZVXAfsa26fHvTXZ7Cvmq2lt_ZPP58 > nPhJ > > K_sGO56g48deUWlcDSsY8qg$ > > [3]: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kerne > > l/git/broonie/spi.git/log/?h=for-6.8__;!!A3Ni8CS0y2Y!4P8x0PlUachyveotK > > > njDl76l9lcBm5HvGgZVXAfsa26fHvTXZ7Cvmq2lt_ZPP58nPhJK_sGO56g48deU > Wlfwzsn > > PJw$ > > > > --- > > Acked-by: Nuno Sa <nuno.sa@analog.com> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > > > David Lechner (9): > > spi: axi-spi-engine: return void from > > spi_engine_compile_message() > > spi: axi-spi-engine: populate xfer->effective_speed_hz > > spi: axi-spi-engine: remove spi_engine_get_clk_div() > > spi: axi-spi-engine: fix sleep ticks calculation > > spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() > > spi: axi-spi-engine: implement xfer->cs_change_delay > > spi: axi-spi-engine: restore clkdiv at end of message > > spi: axi-spi-engine: remove delay from CS assertion > > spi: axi-spi-engine: add watchdog timer > > > > drivers/spi/spi-axi-spi-engine.c | 116 > > ++++++++++++++++++++++++++------------- > > 1 file changed, 77 insertions(+), 39 deletions(-) > > --- > > base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 > > change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0
On Mon, 04 Dec 2023 11:33:26 -0600, David Lechner wrote: > We are working towards adding support for the offload feature [1] of the > AXI SPI Engine IP core. Before we can do that, we want to make some > general fixes and improvements to the driver. In order to avoid a giant > series with 35+ patches, we are splitting this up into a few smaller > series. > > This is a continuation of the work started in [2] which has been applied > to spi/for-6.8 [3]. This series must be applied on top of that series to > apply cleanly. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/9] spi: axi-spi-engine: return void from spi_engine_compile_message() commit: 2e0d75f8dd9e31b3fb175f780494dd7dd988ceae [2/9] spi: axi-spi-engine: populate xfer->effective_speed_hz commit: 9d023ecc31859c7f7c8ca27b5fec52b2dbb8086f [3/9] spi: axi-spi-engine: remove spi_engine_get_clk_div() commit: 1fc8dc5721bbc7a21cb4cc60c35eb8031942542b [4/9] spi: axi-spi-engine: fix sleep ticks calculation commit: be9070bcf67057b7b03c5acc1980d3897448ad20 [5/9] spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() commit: e006c181dd9ab006d7b0982d35ef7951fbffe825 [6/9] spi: axi-spi-engine: implement xfer->cs_change_delay commit: 125a8390995df1a350e9e16e6da11d010e1e7f76 [7/9] spi: axi-spi-engine: restore clkdiv at end of message commit: 3106edac599f59e1298b034a19a43e7da002fccc [8/9] spi: axi-spi-engine: remove delay from CS assertion commit: 0db60d821e485a1c9b8080dbec1ba9871efb6a65 [9/9] spi: axi-spi-engine: add watchdog timer commit: 07d33c2810bb5fe67747d11f76980ed68602e287 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark