Message ID | 20231202153353.635-1-jszhang@kernel.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1826980vqy; Sat, 2 Dec 2023 07:46:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQkaQpQrFoZExrQh+DjQSaITssw2eMz/cs5DsVV0G9G7a2kxd30vwauinnwvatncLZV0tL X-Received: by 2002:a05:6870:ed95:b0:1fb:75a:de75 with SMTP id fz21-20020a056870ed9500b001fb075ade75mr2146742oab.99.1701532015334; Sat, 02 Dec 2023 07:46:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701532015; cv=none; d=google.com; s=arc-20160816; b=bU4HvUjr3diEFJDnyRqae7eHZcgYY/mKzO8z06VuPwrpZdw7xjK71A9g1FqqSicRJ5 VBvIOHnhxnTIu62m7kF+gNaAdGJv2hwMm8qqVkNfZ5VZA2NXLXL/sqM3Cw8x85Rjg/bR WmxLhaFVQStgtUzVPG8WgXV3Slo4+uVkjF9gFmwNQIj5ByRgsqBU8uRfoOpt9l9G3UQ3 ZBLNSEsQTLkTx3S1h9CpwADRg1xqs2J2sdZh0gjPiokWHSx5/HdmlGl2NPNRkmEJM96b 8FQFgBmSLhEzWV0ol6A87prhj7gb1vvoojqDYw8raF8amJ5bRoZ5nyMuzpL+GU8QuX0t R/1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=l6ur+PtDFcxM2iQUredLr8XLIQH2ttoxZowBQugn2zE=; fh=J1TgOvAm83LXD8UeshJD/6XzuvofiXJfoBNhRIDO8r4=; b=i9lTGVehYlTtIl19HtmAglwr/5dm+pmOzi8Bh8G1URezsQIkOHjy9XZMOmmMsFDL+n 75ofaOebhGEo8F488wBMtP2FNeumV4co5eZNrplNNptaiKpd5256b+sniF+ddopnt7Y8 SD6R5CLxKLsEhEBy6FnV67TPM0dV5wCmEJHU1BdL1VTZrdqkfbuYUcAWaOFjZx+Bvubr ptfE4sYYNhhRrMi21mLiqNz1wPeQ3/W+aSChiu6sCTOUlbGmS/pSgJiJUWjB/MevpShG sTbISSGmp9ARniUuhbyMK1hCKI5gb0aWRKnvX2YzVZcWjb5L6OZXf66vEB6UxJBkWTuB /0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lkH1vk7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id r9-20020a63d909000000b005b95ee3edc6si5107185pgg.628.2023.12.02.07.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 07:46:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lkH1vk7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id BAFFE806AFD0; Sat, 2 Dec 2023 07:46:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230181AbjLBPqR (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Sat, 2 Dec 2023 10:46:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjLBPqQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 2 Dec 2023 10:46:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E521FB for <linux-kernel@vger.kernel.org>; Sat, 2 Dec 2023 07:46:21 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7A5C433C8; Sat, 2 Dec 2023 15:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701531981; bh=1EqA9rvqYVRln0P1uLXrqlcy9RJ9TXHPL4bOBzuuWnI=; h=From:To:Cc:Subject:Date:From; b=lkH1vk7xmSD9/+2gTsQUPCBnMNa+96XkPFIFGUts5ED3+qCbcIyalDundPG5UbapV jRS7/DujAccErlR6gcF+GDlD5uxELE30r4byHdmWtWdGqC0UzmOnWKB9nMfEux5AAb 7Pt62tcvmjvhdUiLRWzSW13QTQqkgCKgxBOSGe3o98OiOVmeVWo5Kahqpj2GPoibEM mnMQ/uCvgn4AtF64DRLyzvoSo79Ahm+NEbRMKTFeBz6QqLnQ1Y9qvVrl+MCp9s9OWY 6RHCilnCQKbGrYAd0LuLHxhw8itRrC4mCh2eUmS0+ruggIEyZ/dAoSl4SZnnr+UBzm HXPz806s9oMRg== From: Jisheng Zhang <jszhang@kernel.org> To: Conor Dooley <conor@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <kernel@esmil.dk>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 0/3] riscv: dts: starfive: add Milkv Mars board device tree Date: Sat, 2 Dec 2023 23:33:50 +0800 Message-Id: <20231202153353.635-1-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sat, 02 Dec 2023 07:46:26 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784185634452434871 X-GMAIL-MSGID: 1784185634452434871 |
Series |
riscv: dts: starfive: add Milkv Mars board device tree
|
|
Message
Jisheng Zhang
Dec. 2, 2023, 3:33 p.m. UTC
The Milkv Mars is a development board based on the Starfive JH7110 SoC. The board features: - JH7110 SoC - 1/2/4/8 GiB LPDDR4 DRAM - AXP15060 PMIC - 40 pin GPIO header - 3x USB 3.0 host port - 1x USB 2.0 host port - 1x M.2 E-Key - 1x eMMC slot - 1x MicroSD slot - 1x QSPI Flash - 1x 1Gbps Ethernet port - 1x HDMI port - 1x 2-lane DSI and 1x 4-lane DSI - 1x 2-lane CSI patch1 adds 'cpus' label patch2 adds "milkv,mars" board dt-binding patch3 adds the devicetree file describing the currently supported features: Namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. Since v1: - add two new patches which add "cpus" label and board dt-binding - adopt Krzysztof's suggestions, thanks Hi Conor, I see you have sent a patch which moves the timebase-frequency property to soc dtsi, but this series doesn't rebase on that. I can update it once your patch is merged. Thanks Jisheng Zhang (3): riscv: dts: starfive: add 'cpus' label to jh7110 and jh7100 soc dtsi dt-bindings: riscv: starfive: add Milkv Mars board riscv: dts: starfive: add Milkv Mars board device tree .../devicetree/bindings/riscv/starfive.yaml | 1 + arch/riscv/boot/dts/starfive/Makefile | 1 + arch/riscv/boot/dts/starfive/jh7100.dtsi | 2 +- .../boot/dts/starfive/jh7110-milkv-mars.dts | 637 ++++++++++++++++++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 2 +- 5 files changed, 641 insertions(+), 2 deletions(-) create mode 100644 arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
Comments
Jisheng Zhang wrote: > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > The board features: > > - JH7110 SoC > - 1/2/4/8 GiB LPDDR4 DRAM > - AXP15060 PMIC > - 40 pin GPIO header > - 3x USB 3.0 host port > - 1x USB 2.0 host port > - 1x M.2 E-Key > - 1x eMMC slot > - 1x MicroSD slot > - 1x QSPI Flash > - 1x 1Gbps Ethernet port > - 1x HDMI port > - 1x 2-lane DSI and 1x 4-lane DSI > - 1x 2-lane CSI > > patch1 adds 'cpus' label > patch2 adds "milkv,mars" board dt-binding > patch3 adds the devicetree file describing the currently supported > features: > Namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > Since v1: > - add two new patches which add "cpus" label and board dt-binding > - adopt Krzysztof's suggestions, thanks > > Hi Conor, > > I see you have sent a patch which moves the timebase-frequency property > to soc dtsi, but this series doesn't rebase on that. I can update it > once your patch is merged. Hi Jisheng, Thanks for working on this! On the JH7110 the mtime derives almost directly from the external oscillator like this: osc (24MHz) -> rtc_toggle (div 6) -> mtime (4MHz) So to me it makes sense to define the timebase-frequency in the same file as the frequency of the external oscillator. In general it looks good, but if you do diff -Naur jh7110-{starfive-visionfive-2.dtsi,milkv-mars.dts} you'll see that those two files are almost identical. Even external clock speeds and all the pin configuration are the same. I'd strongly prefer to have all that factored out in a common .dtsi so fixes don't get out of sync. /Emil
On Sat, Dec 02, 2023 at 02:07:50PM -0800, Emil Renner Berthing wrote: > Jisheng Zhang wrote: > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > The board features: > > > > - JH7110 SoC > > - 1/2/4/8 GiB LPDDR4 DRAM > > - AXP15060 PMIC > > - 40 pin GPIO header > > - 3x USB 3.0 host port > > - 1x USB 2.0 host port > > - 1x M.2 E-Key > > - 1x eMMC slot > > - 1x MicroSD slot > > - 1x QSPI Flash > > - 1x 1Gbps Ethernet port > > - 1x HDMI port > > - 1x 2-lane DSI and 1x 4-lane DSI > > - 1x 2-lane CSI > > > > patch1 adds 'cpus' label > > patch2 adds "milkv,mars" board dt-binding > > patch3 adds the devicetree file describing the currently supported > > features: > > Namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > Since v1: > > - add two new patches which add "cpus" label and board dt-binding > > - adopt Krzysztof's suggestions, thanks > > > > Hi Conor, > > > > I see you have sent a patch which moves the timebase-frequency property > > to soc dtsi, but this series doesn't rebase on that. I can update it > > once your patch is merged. > > Hi Jisheng, > > Thanks for working on this! On the JH7110 the mtime derives almost directly > from the external oscillator like this: > > osc (24MHz) -> rtc_toggle (div 6) -> mtime (4MHz) > > So to me it makes sense to define the timebase-frequency in the same file as > the frequency of the external oscillator. > > In general it looks good, but if you do > > diff -Naur jh7110-{starfive-visionfive-2.dtsi,milkv-mars.dts} > > you'll see that those two files are almost identical. Even external clock > speeds and all the pin configuration are the same. I'd strongly prefer to have > all that factored out in a common .dtsi so fixes don't get out of sync. I'm gonna mark this as changes requested on patchwork because of this comment. LMK if you don't think this is worth another version Emil. Cheers, Conor.
On Wed, Jan 10, 2024 at 01:53:11PM +0000, Conor Dooley wrote: > On Sat, Dec 02, 2023 at 02:07:50PM -0800, Emil Renner Berthing wrote: > > Jisheng Zhang wrote: > > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > > The board features: > > > > > > - JH7110 SoC > > > - 1/2/4/8 GiB LPDDR4 DRAM > > > - AXP15060 PMIC > > > - 40 pin GPIO header > > > - 3x USB 3.0 host port > > > - 1x USB 2.0 host port > > > - 1x M.2 E-Key > > > - 1x eMMC slot > > > - 1x MicroSD slot > > > - 1x QSPI Flash > > > - 1x 1Gbps Ethernet port > > > - 1x HDMI port > > > - 1x 2-lane DSI and 1x 4-lane DSI > > > - 1x 2-lane CSI > > > > > > patch1 adds 'cpus' label > > > patch2 adds "milkv,mars" board dt-binding > > > patch3 adds the devicetree file describing the currently supported > > > features: > > > Namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > > > Since v1: > > > - add two new patches which add "cpus" label and board dt-binding > > > - adopt Krzysztof's suggestions, thanks > > > > > > Hi Conor, > > > > > > I see you have sent a patch which moves the timebase-frequency property > > > to soc dtsi, but this series doesn't rebase on that. I can update it > > > once your patch is merged. > > > > Hi Jisheng, > > > > Thanks for working on this! On the JH7110 the mtime derives almost directly > > from the external oscillator like this: > > > > osc (24MHz) -> rtc_toggle (div 6) -> mtime (4MHz) > > > > So to me it makes sense to define the timebase-frequency in the same file as > > the frequency of the external oscillator. > > > > In general it looks good, but if you do > > > > diff -Naur jh7110-{starfive-visionfive-2.dtsi,milkv-mars.dts} > > > > you'll see that those two files are almost identical. Even external clock > > speeds and all the pin configuration are the same. I'd strongly prefer to have > > all that factored out in a common .dtsi so fixes don't get out of sync. > > I'm gonna mark this as changes requested on patchwork because of this > comment. LMK if you don't think this is worth another version Emil. Yeah a new version is needed. And I think it's a bit late for this window, so the new version will be out once v6.8-rc1 is out. Thanks