Message ID | 20231130134630.18198-1-brgl@bgdev.pl |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp396663vqy; Thu, 30 Nov 2023 05:47:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0zjyRerkhYaj/T1UdS5G/56NyaZuu9krwUNMiM8gVI9COver9LVENTj2d7Y4yKQHPSbnA X-Received: by 2002:a05:6a20:5497:b0:18c:4105:9a9b with SMTP id i23-20020a056a20549700b0018c41059a9bmr16037808pzk.12.1701352020708; Thu, 30 Nov 2023 05:47:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701352020; cv=none; d=google.com; s=arc-20160816; b=db2jud0cHv9lVDdrbIcsFxU2xHzCI2GXYvH86KX34NmanAE+7JV8VJfII/myDwS7Co mDnbnNlWqtMA2DXulE3XOOhFeuLXOCKVEPxovZ8uFNqYkfg97Vu6BYzg8sP5HlRD94pO U7KY9yZLpRQcqaeB/5Dw6o4zExEyMGZmj5KH3GBEBahgWgOZCK2EnfX/QT2fvLbhBJ8g OWV7pDBi8H1kHWtVkSoZYKm+2Rrg+Lk+2gNVIPQGD/ZDKdb/HXK7w/7HyJcnnpzrFI13 41SYKi0NAKRY9wQEuf/vH0VeX3zq7HEBfbVjF0qalkgDGVUltcV0PsLFMDzBmZpZNa6J MdHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Q3aC6tvFROLQEKABOisLsa75C0gCr6RDOPC7pNb7PmE=; fh=fw6biwzn34ngIUS3OuPB+D+TvAzoz1YwnvitHxA+Jyw=; b=MkYd9r+voW4wG3fu1gHweMc+W6kPKq2oyFjZTpNalLmmi2lEcW8SyoQFDFlWu1otE5 z/v8ePoA1qQEme60TUvH16sATQuxJsEvkFadYmc0VAhdMztbR1xPhUKKZHO6WOEhQIMx 7VVNJb2vpbG93+TxtE5ZqD1NRekJicf91SH2ATGNh+DSlDQcJmj2yLDS5MM57KaW37iL qiqTSPjFUjS4pOJIN1SRzciQUrNIKken1IPxSpUnQY13VKi8sL8UMjHOUPEpYHPUdL7f uCoFov9RQtutDFXP+R0sOGwVMEDlQnuewYmToMuQek8mE1LCV4jqg/FsQ7OxUS0nJeQq 9FUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ACQlgKEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id fd6-20020a056a002e8600b006cd8db77f84si1305876pfb.274.2023.11.30.05.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 05:47:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ACQlgKEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 784FB826EE3D; Thu, 30 Nov 2023 05:46:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345653AbjK3Nqq (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Thu, 30 Nov 2023 08:46:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345697AbjK3Nqe (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 30 Nov 2023 08:46:34 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2CAC170B for <linux-kernel@vger.kernel.org>; Thu, 30 Nov 2023 05:46:36 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-409299277bbso7721385e9.2 for <linux-kernel@vger.kernel.org>; Thu, 30 Nov 2023 05:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701351995; x=1701956795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q3aC6tvFROLQEKABOisLsa75C0gCr6RDOPC7pNb7PmE=; b=ACQlgKECBbmNJ5SZR2JUaKBP6q8LPWRFBCXLf9qwXUbxQ+cUnTVBlO/KS8IxOMR9Rp YB36nIHEGwVNb7ueBffSdUTjzA7CG3wHz6/kURsyV0utro+N6VBEDYgXCS0wftSJnQ1e z++V+ERzaNzk3JLvzVInXkEqHDUsZ+bsigBb/gr7xKOlMeAuD42h3wtIZ+3d1JVzbhFM B39pNiE7AptF3A2xXvCcxU+7geEbvFvQR84MoVBBa74Lab/lCRxT1Psip+nG5RGQsYns EmtU+ltkUdeNUYfFFdZc71+PK03fjHEVn+ghjqRNrVbY6jRntLFKYArPOVjBPo8t5P8R qqgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701351995; x=1701956795; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q3aC6tvFROLQEKABOisLsa75C0gCr6RDOPC7pNb7PmE=; b=DtzQc8NsFZS0KBYB6CBo5No2mZEELnMgrM+hcjKcFn64H2dbS3fp2t3+YbnneJ2oQq geRTpJTZ6DRY7oTNHisjmLYG31tJ36T2EHM6Bf5lYbieiNX3m4LtNXlZkMAmcEfrBHHR Z2sszDgHcZV5HjeG/uawI2fxpcs2NY878cJKVJ3xxbrzPaE2w+OdqAxx67lMczGIdSK9 WBAngddpoUR2dxZ22j1tc2pIvSOvuMjZybCVu8tMxtJiCc5G6a/6qm5RBUmLyz8UKrS+ 0a02V6lHj3E2Fk3XSn8p3D+WWd96bTlZQzeZZSdfWP0xfK7QcvnuZnrqiOsjIqR4FAgB XxMw== X-Gm-Message-State: AOJu0YywI9X5nu29sVle/mR9uK7PP6Js4Fbpaw7Ec7PfjHK1WcPP33cz WclkMA9Odyj+5N2heklH1Qs4dw== X-Received: by 2002:a05:600c:310f:b0:40b:387b:1135 with SMTP id g15-20020a05600c310f00b0040b387b1135mr13398281wmo.5.1701351995242; Thu, 30 Nov 2023 05:46:35 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:ae84:904:6602:ec1e]) by smtp.gmail.com with ESMTPSA id n18-20020adffe12000000b0032d2489a399sm1574824wrr.49.2023.11.30.05.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 05:46:34 -0800 (PST) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH v2 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Date: Thu, 30 Nov 2023 14:46:20 +0100 Message-Id: <20231130134630.18198-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 30 Nov 2023 05:46:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783996896232754608 X-GMAIL-MSGID: 1783996896232754608 |
Series |
gpio/pinctrl: replace gpiochip_is_requested() with a safer interface
|
|
Message
Bartosz Golaszewski
Nov. 30, 2023, 1:46 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
While reworking the locking in GPIOLIB I realized that locking the
descriptor with users still calling gpiochip_is_requested() will still
be buggy as it returns a pointer to a string that can be freed whenever
the descriptor is released. Let's provide a safer alternative in the
form of a function that returns a copy of the label.
Use it in all drivers and remove gpiochip_is_requested().
I plan to provide this series in an immutable branch for the pinctrl and
baytrail trees to pull.
v1 -> v2:
- use DEFINE_CLASS() to register a destructor for making sure that the
duplicated label doesn't leak out of the for_each loops even with
break;
Bartosz Golaszewski (10):
gpiolib: provide gpiochip_dup_line_label()
gpio: wm831x: use gpiochip_dup_line_label()
gpio: wm8994: use gpiochip_dup_line_label()
gpio: stmpe: use gpiochip_dup_line_label()
pinctrl: abx500: use gpiochip_dup_line_label()
pinctrl: nomadik: use gpiochip_dup_line_label()
pinctrl: baytrail: use gpiochip_dup_line_label()
pinctrl: sppctl: use gpiochip_dup_line_label()
gpiolib: use gpiochip_dup_line_label() in for_each helpers
gpiolib: remove gpiochip_is_requested()
drivers/gpio/gpio-stmpe.c | 6 +++-
drivers/gpio/gpio-wm831x.c | 14 ++++++---
drivers/gpio/gpio-wm8994.c | 13 +++++---
drivers/gpio/gpiolib.c | 37 ++++++++++++++---------
drivers/pinctrl/intel/pinctrl-baytrail.c | 11 ++++---
drivers/pinctrl/nomadik/pinctrl-abx500.c | 9 ++++--
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 +++-
drivers/pinctrl/sunplus/sppctl.c | 10 +++---
include/linux/gpio/driver.h | 37 +++++++++++++++++------
9 files changed, 95 insertions(+), 48 deletions(-)