From patchwork Thu Nov 30 14:07:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Patchwork-Id: 17334 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp411362vqy; Thu, 30 Nov 2023 06:07:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWPFFZ/2rGJ7doh+xqEMKpYsv4grLE8x5PdmaNpGsa3e1hzDDjb+SHnTqdNeyGNFVefhNd X-Received: by 2002:a05:6808:221e:b0:3b2:f557:666e with SMTP id bd30-20020a056808221e00b003b2f557666emr31409416oib.19.1701353274018; Thu, 30 Nov 2023 06:07:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353274; cv=none; d=google.com; s=arc-20160816; b=kRbxpFDTork39JeeG9YPpno6TcRQVVr0wBIDB8ow12UBBx7N2hDQ/NaZzZcs5I4w/Z YJoFslok3Z495oAX/lpXCJJtsPXRLP33LWcwPPHT1gR8udSHP8qXvWgr9Bh4+ZGRFhzt FROS7QdkZJlx4bG8DN7NkUha7cppwiKC5COdJWQ988D2VARwsdKatKf03G8Rp4aUsyPI m54SAjGSmbgl7Py9Risy7KuEQBA3KbpNegbgZNvHTWLrd8lDuMWvozmqdMl4iBkXi4AE SxdNk3GQnta3IekLDqLafFcx+HgDGPSO4p50vbLsDBWQThj7AnC6dubukHhE6M6HaB8P prow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=6n5y5Y4ag6lEhCM60JkkPOe9LhwwAQaW6l5XEjQba18=; fh=AHZzcI0NKFNU1WuuS/FWF2LprSMGsTAGL8gmMiTfjNU=; b=tlzEbvWOHKQENfZOGrhcodZhdnYxc8DwdqwjXAhIL/ZCrwAbsj8SaBttl79J3Y08P1 N8KfIVfPnb18Sj3GO+cvaOG+lrSytG1JaKEfypifjtQq1VPvTrtiSUcUmdgQQ4igvVYf eGAEsjcPv1DcViq+PjMYvi0CW6u0oLli4rnWqSuLYimFX7x8q+IQXOKj62TbRw7W+xFx Ii5dM9nZ/S2+dwam2CIr8JrWsFwbnXcVVjJtkbJ5l07yr5QuDmtsv0c+IuVDNWHuyvCh 3dl3f7nEi8JwEQZ/bc3Olq89XmZ31+bP/QZJ3bZg1nu6G7UjpJiNwzbjhVhqxzmDptrx nNaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=jiiBmXTx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c23-20020aca1c17000000b003b863aa8281si475661oic.93.2023.11.30.06.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:07:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=jiiBmXTx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3B1848077584; Thu, 30 Nov 2023 06:07:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345862AbjK3OHf (ORCPT + 99 others); Thu, 30 Nov 2023 09:07:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345768AbjK3OHb (ORCPT ); Thu, 30 Nov 2023 09:07:31 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE578D46; Thu, 30 Nov 2023 06:07:34 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 623B540007; Thu, 30 Nov 2023 14:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701353253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6n5y5Y4ag6lEhCM60JkkPOe9LhwwAQaW6l5XEjQba18=; b=jiiBmXTxD+R0K1mUExooYO3IQW+9FJFg+tOT9rjRayt8ZhNqrwP6xB6YpdpAi69Mw1Sb/G NQr2h8nGRHljYmWDhj6fwlNLYLaHYqpM1b3ZZY1I3tcvW26dCxky5M35rzn4xxLE1TMlvx sBzwOWLihAlJQqkg6teyknxp2+ZdMYQeIvU2Fa8CxXPXvB+dCNJ2GLqpAkoIo7dST+3INU QJsFaEXkOZ9H0yESKKBPCT2wBz+EuwC4BWqlTZt5VIXz7wAdJN/de5upg8CszjttvVtZyy shicLGyppULTXyItSqKl/uzzbVEdr/qJfh83WmfCp4eCus/NwbKoN+IIU3G7IQ== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: [PATCH v5 0/9] Cleanup AMBA PL011 driver Date: Thu, 30 Nov 2023 15:07:12 +0100 Message-Id: <20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIABCXaGUC/2XPzQoCIRSG4VsJ1xn+jKO26j6ihdo5JdQYziRFz L1nQWS0cPGJzws+yAg5wkjWiwfJUOIY01CHWi5IOLrhADTu6yaCCcnroWd/utOryxN1GFzw3ho 0ntT3lwwYb+/Wdlf3MY5Tyvd3uvDX7afSN5XCKaNWKAPghNV7ufEpTac4rEI6k1eniK/l/MeKa k0vse9VACXYv5WNFay1slqmHUhltUWO/7Zrbfvz0lWr0XLpdIdo7K+d5/kJXPbCQFgBAAA= To: Russell King , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij , =?utf-8?q?Gr=C3=A9gory_Clement?= , Alexandre Belloni , Thomas Petazzoni , Vladimir Kondratiev , Tawfik Bayouk , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?T?= =?utf-8?q?h=C3=A9o_Lebrun?= X-Mailer: b4 0.12.3 X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:07:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998210662935491 X-GMAIL-MSGID: 1783998210662935491 Hi, While adding upstream support to a new platform (Mobileye EyeQ5[1]) that uses the AMBA PL011 driver, I took some time to look at the PL011 driver and ended up with a few patches that cleanup parts of it. The line-diff is big mostly because of the checkpatch-fixing commits. The driver hadn't received any love for quite some time. See commit messages for more information. v5 has been rebased upon v6.7-rc1, with [PATCH v4 3/6] split into many small commits and a header include in [PATCH v4 2/6] to fix a kernel test robot report. [1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@intel.com/T/ Have a nice day, Théo Lebrun Signed-off-by: Théo Lebrun --- Changes in v5: - Rebase upon v6.7-rc1. - Add #include in include/linux/amba/serial.h. - Split [PATCH v4 3/6] into 5 manageable commits. - Link to v4: https://lore.kernel.org/r/20231123-mbly-uart-v4-0-7f913a74ff89@bootlin.com Changes in v4: - Fix reverse if logic bug in [PATCH V3 6/6]. - Link to v3: https://lore.kernel.org/r/20231120-mbly-uart-v3-0-07ae35979f1f@bootlin.com Changes in v3: - Replace magic constants in linux/amba/serial.h by FIELD_PREP_CONST calls - Refactor QDF2400 SoC erratum 44 handling out of probe in a new patch - A nit in "unindent pl011_console_get_options function body" - Link to v2: https://lore.kernel.org/r/20231116-mbly-uart-v2-0-863f665ce520@bootlin.com Changes in v2: - [PATCH 2]: add #include in include/linux/amba/serial.h as we use the BIT() macro. - Move one whitespace cleanup from [PATCH 4/6] to [PATCH v2 3/5] where it belongs. - Drop [PATCH 6/6]: console will never have a word length of 5 or 6. - Link to v1: https://lore.kernel.org/r/20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com --- Théo Lebrun (9): tty: serial: amba: cleanup whitespace tty: serial: amba: Use linux/{bits,bitfield}.h macros tty: serial: amba-pl011: fix whitespace formatting tty: serial: amba-pl011: replace TIOCMBIT macros by static functions tty: serial: amba-pl011: avoid quoted string split across lines tty: serial: amba-pl011: fix formatting of conditions tty: serial: amba-pl011: fix miscellaneous checkpatch warnings tty: serial: amba-pl011: unindent pl011_console_get_options function body tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe drivers/tty/serial/amba-pl011.c | 261 +++++++++++++++++++++------------------- include/linux/amba/serial.h | 258 ++++++++++++++++++++------------------- 2 files changed, 266 insertions(+), 253 deletions(-) --- base-commit: 9e47ce5c186d8364f4de3e879a148121b37e5216 change-id: 20231023-mbly-uart-afcacbb98f8b Best regards,