mbox series

[drm-misc-next,v2,0/2] PowerVR VM fixes

Message ID 20231129220835.297885-1-dakr@redhat.com
Headers
Series PowerVR VM fixes |

Message

Danilo Krummrich Nov. 29, 2023, 10:07 p.m. UTC 
  Hi,

Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
went in rather quickly (review process was finished otherwise) I haven't had the
chance to review the subsequent code changes.

Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
make the drm_gpuvm_prepare_* helpers useful for PowerVR.

- Danilo

Changes in V2
=============
- GPUVM: update function DOC comment to indicate the passing zero fences to
  drm_gpuvm_prepare_* functions results into drm_exec_lock_obj() calls rather
  than drm_exec_prepare_obj() calls.
- pvr/vm: use drm_gpuvm_exec wrappers
- drop 3 patches which were applied already

Danilo Krummrich (2):
  drm/gpuvm: fall back to drm_exec_lock_obj()
  drm/imagination: vm: make use of GPUVM's drm_exec helper

 drivers/gpu/drm/drm_gpuvm.c          | 43 +++++++++++--
 drivers/gpu/drm/imagination/pvr_vm.c | 91 +++++++++++-----------------
 include/drm/drm_gpuvm.h              | 23 +------
 3 files changed, 77 insertions(+), 80 deletions(-)


base-commit: 83dc1029dcf50b5b849b26679a1b3f860b85d79c

Comments

Donald Robson Dec. 5, 2023, 2:54 p.m. UTC | #1 
Apologies, I didn't reply all last time.

Thanks Danilo!

Reviewed-by: Donald Robson <donald.robson@imgtec.com>

On Wed, 2023-11-29 at 23:07 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination Technologies. Think before you click a link or open an attachment ***
> 
> Hi,
> 
> Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
> went in rather quickly (review process was finished otherwise) I haven't had the
> chance to review the subsequent code changes.
> 
> Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
> make the drm_gpuvm_prepare_* helpers useful for PowerVR.
> 
> - Danilo
> 
> Changes in V2
> =============
> - GPUVM: update function DOC comment to indicate the passing zero fences to
>   drm_gpuvm_prepare_* functions results into drm_exec_lock_obj() calls rather
>   than drm_exec_prepare_obj() calls.
> - pvr/vm: use drm_gpuvm_exec wrappers
> - drop 3 patches which were applied already
> 
> Danilo Krummrich (2):
>   drm/gpuvm: fall back to drm_exec_lock_obj()
>   drm/imagination: vm: make use of GPUVM's drm_exec helper
> 
>  drivers/gpu/drm/drm_gpuvm.c          | 43 +++++++++++--
>  drivers/gpu/drm/imagination/pvr_vm.c | 91 +++++++++++-----------------
>  include/drm/drm_gpuvm.h              | 23 +------
>  3 files changed, 77 insertions(+), 80 deletions(-)
> 
> 
> base-commit: 83dc1029dcf50b5b849b26679a1b3f860b85d79c
Maxime Ripard Dec. 5, 2023, 3:35 p.m. UTC | #2 
Hi,

On Wed, Nov 29, 2023 at 11:07:59PM +0100, Danilo Krummrich wrote:
> Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
> went in rather quickly (review process was finished otherwise) I haven't had the
> chance to review the subsequent code changes.
> 
> Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
> make the drm_gpuvm_prepare_* helpers useful for PowerVR.

This doesn't apply on drm-misc-next anymore, could you rebase and
resend?

Thanks!
Maxime
Danilo Krummrich Dec. 5, 2023, 3:40 p.m. UTC | #3 
On Tue, Dec 05, 2023 at 04:35:00PM +0100, Maxime Ripard wrote:
> Hi,
> 
> On Wed, Nov 29, 2023 at 11:07:59PM +0100, Danilo Krummrich wrote:
> > Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
> > went in rather quickly (review process was finished otherwise) I haven't had the
> > chance to review the subsequent code changes.
> > 
> > Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
> > make the drm_gpuvm_prepare_* helpers useful for PowerVR.
> 
> This doesn't apply on drm-misc-next anymore, could you rebase and
> resend?

I already applied the two patches to drm-misc-next.

- Danilo

> 
> Thanks!
> Maxime
Maxime Ripard Dec. 6, 2023, 8:28 a.m. UTC | #4 
On Tue, Dec 05, 2023 at 04:40:40PM +0100, Danilo Krummrich wrote:
> On Tue, Dec 05, 2023 at 04:35:00PM +0100, Maxime Ripard wrote:
> > Hi,
> > 
> > On Wed, Nov 29, 2023 at 11:07:59PM +0100, Danilo Krummrich wrote:
> > > Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
> > > went in rather quickly (review process was finished otherwise) I haven't had the
> > > chance to review the subsequent code changes.
> > > 
> > > Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
> > > make the drm_gpuvm_prepare_* helpers useful for PowerVR.
> > 
> > This doesn't apply on drm-misc-next anymore, could you rebase and
> > resend?
> 
> I already applied the two patches to drm-misc-next.

Uh, sorry I didn't notice it.

Maxime