From patchwork Wed Nov 29 14:24:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 17274 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp373534vqn; Wed, 29 Nov 2023 06:24:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFakOqdAHVFqv5Da/MBYxEWzKlFXLWKVWIABfxlgERZULbCmyNTQILm6ZFcIK/L90Gyg3sB X-Received: by 2002:a92:c603:0:b0:35c:debc:94f8 with SMTP id p3-20020a92c603000000b0035cdebc94f8mr10205827ilm.10.1701267871345; Wed, 29 Nov 2023 06:24:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701267871; cv=none; d=google.com; s=arc-20160816; b=X5iFV7QjfSk72qHTc38Z6psqtgQ1zrj8guhmVQ3lPJHA72zoMDtrL3m9I1tkq87B3P pKNwMtNOgBtLufYc6NeneTHvlhDgB7LIa2aGvmtJeXC/oPnfhPfs5kqTHMFySdULCgto 99QMCnUXs5V/UWw13B62SuLY25J9mcasE0knsf0bxfnbi7IJGjGj5XI9nVM77RMwojqL bMBUgQGq5odqjRlZHLQ37lL6btcJ57h3PqfyUP51KDCoN42/qZioSM4xUHnHmdUhTPVo SMooWQMCHawJHYhocvXUjfTwbnj9Eucugwt1UWGJy8GADeukXSxv0Cl34sjXssmievJG oWsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Pl/Yt40SJcnA5LWZls34vPbbDSVAM5mPdOt7hL6FpRI=; fh=fw6biwzn34ngIUS3OuPB+D+TvAzoz1YwnvitHxA+Jyw=; b=SKhbgrJWIJEfSTCVdD9CjDykOcy+qIJReiVlHetDC8JAQVP0lwdxz0EPa9K0yHRF1k 2KUC7DCYj51ptQi+BQZ/xxMZ1f+CnvNOhMTGY5lAGCbCRipSilxmxV/pHkNBOqBct67W evDTBHUqwsAdOj9iMMlLtDmeESJ9rXp+GktUe0vlQuqrP9Bl5uCew/CuLXWU48M31eBr bEE9anX+YCNYiV8mqfaRu5GSCtfrOPi22Da2S562lU+Br1OBOj4ToLAo83lVrYK27QVV neG5yr4N0SeuLIP/XY41nK8DlE6y3GlIe2E8497F6RuwCt5GIJFPHDYdtxsNXkiXLVrz jLUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=HCSsw1pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bm6-20020a656e86000000b005bdbd1b52d4si15484027pgb.270.2023.11.29.06.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:24:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=HCSsw1pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BE0AA80B01F8; Wed, 29 Nov 2023 06:24:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233934AbjK2OYS (ORCPT + 99 others); Wed, 29 Nov 2023 09:24:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbjK2OYR (ORCPT ); Wed, 29 Nov 2023 09:24:17 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76C65E1 for ; Wed, 29 Nov 2023 06:24:23 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40b27b498c3so54860755e9.0 for ; Wed, 29 Nov 2023 06:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701267862; x=1701872662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pl/Yt40SJcnA5LWZls34vPbbDSVAM5mPdOt7hL6FpRI=; b=HCSsw1pEypV0Hu2l4QCZqQAta1w2V1vy47SO7s+08955+Oz1OmNTzj275Ntln/437j ShosRgFQqbfYYC5MOf4ka5HcJuVLMPT1tCBZ3HykvZG7f62zZVg1zjC7Yzlzb7vGEoZG MSB5352k4Tbvf5YRPjEjYNzBrV3i1ecyakGWjIc/b/VHeQ/DIPJPLqXJGCYcuAwawcwO DzmPhk4Zv281btsZfsqig3nTPTW5d8okJVpfn6WYlPc/g0ScwHSbjzrXvWLpNN+taaql 2HMw6kLjezUGJCEubPw9oV6gP+U8hA+Xa6U+7eysYBl8InXp9TF8zk74HJZM5xHW0qps K7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701267862; x=1701872662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pl/Yt40SJcnA5LWZls34vPbbDSVAM5mPdOt7hL6FpRI=; b=L5tZ/SKJVlYgtD6xMEcaFdxtWi548XueVDs3FH6WKJdQxIIv81YXcsYr+9LFqKXA/L 7pqUV7tYa4w6uY4mP8r77/mnSVt/jHOSTDwJqA05GiuN94k9MBnJHXPH++uFLalkJ+MI vVmsF1ZiMjBxtVQMzHj4lK1kFxp/MrC7j/IB1ibjF+ctlbPdw+YOeJwFfo9sQhiUgn/Q qCD1uwdgDaE3XAZ2ur54GXe3ssAqsr/PWVbSKLCtqIKeCT88tmCAcs38FeyK3FHS6Vga fs+vwCb3bcReBv7tLa5yENenVX+g014NwVWnIFXY+DfDqYu1rmroOOyw0iiNhmIVpVZt cxNw== X-Gm-Message-State: AOJu0Yx9pmtUP/lH6xjQVrIG75KwRB+LbOa/P2W57SXju6vzu7tc3FGM EkhorZsOYT/cOJHzLoCSkYX0oA== X-Received: by 2002:a05:600c:3b85:b0:40b:3e7e:af4d with SMTP id n5-20020a05600c3b8500b0040b3e7eaf4dmr9959596wms.19.1701267861770; Wed, 29 Nov 2023 06:24:21 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4520:2f25:4d3a:4adf]) by smtp.gmail.com with ESMTPSA id n40-20020a05600c3ba800b0040b34720206sm2406848wms.12.2023.11.29.06.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:24:21 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Date: Wed, 29 Nov 2023 15:24:01 +0100 Message-Id: <20231129142411.76863-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:24:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783908659562606799 X-GMAIL-MSGID: 1783908659562606799 From: Bartosz Golaszewski While reworking the locking in GPIOLIB I realized that locking the descriptor with users still calling gpiochip_is_requested() will still be buggy as it returns a pointer to a string that can be freed whenever the descriptor is released. Let's provide a safer alternative in the form of a function that returns a copy of the label. Use it in all drivers and remove gpiochip_is_requested(). Bartosz Golaszewski (10): gpiolib: provide gpiochip_dup_line_label() gpio: wm831x: use gpiochip_dup_line_label() gpio: wm8994: use gpiochip_dup_line_label() gpio: stmpe: use gpiochip_dup_line_label() pinctrl: abx500: use gpiochip_dup_line_label() pinctrl: nomadik: use gpiochip_dup_line_label() pinctrl: baytrail: use gpiochip_dup_line_label() pinctrl: sppctl: use gpiochip_dup_line_label() gpiolib: use gpiochip_dup_line_label() in for_each helpers gpiolib: remove gpiochip_is_requested() drivers/gpio/gpio-stmpe.c | 6 +++- drivers/gpio/gpio-wm831x.c | 14 ++++++--- drivers/gpio/gpio-wm8994.c | 13 +++++--- drivers/gpio/gpiolib.c | 37 ++++++++++++++--------- drivers/pinctrl/intel/pinctrl-baytrail.c | 11 ++++--- drivers/pinctrl/nomadik/pinctrl-abx500.c | 9 ++++-- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 +++- drivers/pinctrl/sunplus/sppctl.c | 10 +++--- include/linux/gpio/driver.h | 8 +++-- 9 files changed, 72 insertions(+), 42 deletions(-)