Message ID | 20231129132527.8078-1-bagasdotme@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp334523vqn; Wed, 29 Nov 2023 05:26:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/JBR4ZtIX5XS2eeARtOONtUIYdy+iDhQ4+AlsqOz9hW3vtn07aUG7aFEjftCCqu8Rd2QA X-Received: by 2002:a05:6830:438b:b0:6d8:282a:184a with SMTP id s11-20020a056830438b00b006d8282a184amr11910042otv.36.1701264361005; Wed, 29 Nov 2023 05:26:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701264360; cv=none; d=google.com; s=arc-20160816; b=Ae/WFp98Ge+v4uuAjAH273Eb8/Z9P4d1UGmxL0xNwvYQbu2Nyt9zPIZuUy9DptNarw yNdE/sSstXdgeYM6uzel84dU+PWxM6Fawp0CRveexs6HvFipbVOl2lCWPeFD6HVAMNjK z9gNhDCUdkY+fNvITr7bHl5UjbzlL/4mdEcXmJ6A0e1aImM1BBXGL6t9T3YqPDq6tE9O GiXVBnH428wxCLru5NAC8LXCZoO9drGDVqpc6tYvEse6qsbGWWw+TFk7S1vIMmkXunHs AMu/i99xtcPRgw48yxqAazL6gLR29rrTzG4ehqD97jDbJtFr72gYaQKJ5y3GNl5jRMjR pLPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s+ZIlO4sg/cP7zZFMR0rAT4hiXFZZBZjMQhwTCp44A4=; fh=+qnYP7xXfpR50bhz1+ra15koDRwPqtvqKU/d4Gxti/A=; b=cUdOlVpylEYphSbKLjn5Bff3GsTAOEUxqwbW50KO8qx4y0Wp5VZGBxguMRpyYUF8KT YawRvKjTYWzPSRka7S9UmD0c02QOBNuJIO5dOErHOg//oPxRmDErjlAaZTDi3K2RzB2W R+MrCoYbAAYP0yqZ996uF6aqcYUUFp1UrQpqw5yOH8oHhBwk2CJK1m4wT2kGU+DtvfY6 sHaGTZ4dtKrJDBhPUjEasbKTSLIDQFmt+MWRlcX1M0d9I+4l6GkTup32lLOiupWrJ3uG tKcXrp/14wti1n3IUWRnXeIk2B6bg9SR37cc6Msw9Vxriz9/ANoInhncf6kVGDqOl0bG OzIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Vn/UUsYF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b14-20020a631b4e000000b005bdbcdc9e3dsi4293098pgm.142.2023.11.29.05.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 05:26:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Vn/UUsYF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8A7A38030BB8; Wed, 29 Nov 2023 05:25:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234046AbjK2NZi (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Wed, 29 Nov 2023 08:25:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234007AbjK2NZb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 29 Nov 2023 08:25:31 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E75AA3; Wed, 29 Nov 2023 05:25:38 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1cc9b626a96so51964065ad.2; Wed, 29 Nov 2023 05:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701264337; x=1701869137; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s+ZIlO4sg/cP7zZFMR0rAT4hiXFZZBZjMQhwTCp44A4=; b=Vn/UUsYFa/vtxTlQyo2fh93u4tFOTG5TqrtwjLebIkfx7VNyF3zq7m8QQ02S+MRsVB JmspCM/CuiKCtqkQQNuPjR/xLsc5fl2UdvSHrJH+6GsuYFLP3oH6ACnaVrTYOgxkQzPd n6bQtyc30pCPd61f2N1T52GBTreIWhIogSsHwwPh67301Hd6bRjdqau7OKqo4saJq1Fz YKkKGEpTeEJiGpfwFuKPlKxsmlHKsG9GlEYzdHVHLZr2o810lna3U/SM8huxivOK7lQi KAEtqU6XwreoA+8Ny/fjb66X8k4ATlRoiHYc3kpS2zU0HlUWpHIiivBpkeLNzWXK1On5 Q8cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701264337; x=1701869137; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s+ZIlO4sg/cP7zZFMR0rAT4hiXFZZBZjMQhwTCp44A4=; b=Z++asUhYpBxQ2CyatXoEG/bF34YFRb4pwWy7y1S7SvsStJWKEfRd1HfS71nsd/3Y7b ZGqEewpgC/4iRgOUSv6G718D5GvFAtTerfcT8gBOIok/Vwj3g58A7FPPz0xHfF4mspsd u+/2Op9DG8ll/2k4jEdE4Wz8DwwTvawb6kBcQKNUqf7611kaXyhIHLMu4cEA56bzIcXy 1x43jRDd9QoCNZTF9XwpovBmJGe+8N+MnG+BewZEnok7uMrPRQlI+TlGbYz5ki0euDQX E0EQWznb2Y8L+Dwoj2+doPAhMdrtObDY0KzZPK+3AKp/X4YwJqDGZl8z0M/DSZHnI5NU EaHA== X-Gm-Message-State: AOJu0YztrlP9PX0yB2HJBEZVozRdHOx9NY39pZ6O2+Ak4jaBnRg9W5JQ dkWr5bthN9P/VRW1MBCszPA= X-Received: by 2002:a17:902:b608:b0:1cf:8cca:4f62 with SMTP id b8-20020a170902b60800b001cf8cca4f62mr16041606pls.46.1701264337664; Wed, 29 Nov 2023 05:25:37 -0800 (PST) Received: from archie.me ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id e13-20020a170902d38d00b001cf5c99f031sm10220343pld.283.2023.11.29.05.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 05:25:35 -0800 (PST) Received: by archie.me (Postfix, from userid 1000) id 09B1310205C79; Wed, 29 Nov 2023 20:25:29 +0700 (WIB) From: Bagas Sanjaya <bagasdotme@gmail.com> To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Documentation <linux-doc@vger.kernel.org>, Linux Kernel Livepatching <live-patching@vger.kernel.org> Cc: Josh Poimboeuf <jpoimboe@kernel.org>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Attreyee Mukherjee <tintinm2017@gmail.com>, Bagas Sanjaya <bagasdotme@gmail.com> Subject: [PATCH 0/2] Minor grammatical fixup for livepatch docs Date: Wed, 29 Nov 2023 20:25:25 +0700 Message-ID: <20231129132527.8078-1-bagasdotme@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=717; i=bagasdotme@gmail.com; h=from:subject; bh=gsdJWBuTmbS/IXxeLqNBKuw152ChX0KZJGcFrysa+Aw=; b=owGbwMvMwCX2bWenZ2ig32LG02pJDKnp1ocE/nG4mD8rDm1iiIhuPL52icCSvVs2S2xpqz+6p /T5gv9xHaUsDGJcDLJiiiyTEvmaTu8yErnQvtYRZg4rE8gQBi5OAZjIBlWGf+rTzte3fcvlzYu0 8P1x8+zeoOTKs78v971VCVf+8fPKSX6gCr+U+/cF88xa1kcdELmjN+GgnffeLGYtqUdVV3as8TF jBQA= X-Developer-Key: i=bagasdotme@gmail.com; a=openpgp; fpr=701B806FDCA5D3A58FFB8F7D7C276C64A5E44A1D Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 05:25:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783904978771924594 X-GMAIL-MSGID: 1783904978771924594 |
Series |
Minor grammatical fixup for livepatch docs
|
|
Message
Bagas Sanjaya
Nov. 29, 2023, 1:25 p.m. UTC
I was prompted to write this little grammar fix series when reading the fix from Attreyee [1], with review comments requesting changes to that fix. So here's my version of the fix, with reviews from [1] addressed (and distinct grammar fixes splitted). [1]: https://lore.kernel.org/lkml/20231127155758.33070-1-tintinm2017@gmail.com/ Bagas Sanjaya (2): Documentation: livepatch: Correct "step on each other's toes" idiom Documentation: livepatch: Correct opposite of releasing locks Documentation/livepatch/livepatch.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
Comments
On 11/29/23 08:25, Bagas Sanjaya wrote: > I was prompted to write this little grammar fix series when reading > the fix from Attreyee [1], with review comments requesting changes > to that fix. So here's my version of the fix, with reviews from [1] > addressed (and distinct grammar fixes splitted). > Typical kernel workflow would be for Attreyee to incorporate feedback and post their v2 after a day or two. From the format they posted, it appears to be a first(ish) kernel contribution post. Let's be kind and patient so they we all may benefit from the practice of iterating on their patch.
Bagas Sanjaya <bagasdotme@gmail.com> writes: > I was prompted to write this little grammar fix series when reading > the fix from Attreyee [1], with review comments requesting changes > to that fix. So here's my version of the fix, with reviews from [1] > addressed (and distinct grammar fixes splitted). How is this helpful? Why are you trying to push aside somebody who is working toward a first contribution to the kernel? This is not the way to help somebody learn to work with the kernel community. Attreyee, I would like to encourage you to redo your patch set based on the feedback you have received so that we can apply it. Thanks, jon
On Wed, Nov 29, 2023 at 07:29:35AM -0700, Jonathan Corbet wrote: > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > I was prompted to write this little grammar fix series when reading > > the fix from Attreyee [1], with review comments requesting changes > > to that fix. So here's my version of the fix, with reviews from [1] > > addressed (and distinct grammar fixes splitted). > > How is this helpful? Why are you trying to push aside somebody who is > working toward a first contribution to the kernel? This is not the way > to help somebody learn to work with the kernel community. This is not the first such "contribution" from Bagas recently. https://lore.kernel.org/linux-doc/20231121095658.28254-1-bagasdotme@gmail.com/ was as a result of https://lore.kernel.org/linux-xfs/87r0klg8wl.fsf@debian-BULLSEYE-live-builder-AMD64/ I didn't say anything at the time, but clearly I should have squelched this bad behaviour by Bagas before he did it to a newbie. Bagas, find your own project to work on. Don't steal glory from others.
On 11/29/23 20:53, Joe Lawrence wrote: > On 11/29/23 08:25, Bagas Sanjaya wrote: >> I was prompted to write this little grammar fix series when reading >> the fix from Attreyee [1], with review comments requesting changes >> to that fix. So here's my version of the fix, with reviews from [1] >> addressed (and distinct grammar fixes splitted). >> > > Typical kernel workflow would be for Attreyee to incorporate feedback > and post their v2 after a day or two. From the format they posted, it > appears to be a first(ish) kernel contribution post. Let's be kind and > patient so they we all may benefit from the practice of iterating on > their patch. > I do this posting because I thought the OP (Attreyee) didn't respond in timely manner (just like random Chinese contributors like @cdjrlc.com and @208suo.com people). Thanks.
On Thu, Nov 30, 2023 at 06:58:16AM +0700, Bagas Sanjaya wrote: > I do this posting because I thought the OP (Attreyee) didn't respond in > timely manner (just like random Chinese contributors like @cdjrlc.com > and @208suo.com people). That's a ridiculous excuse. The original posting was two days ago! If it had been a week since we last heard from Attreyee, I'd understand.
Bagas Sanjaya <bagasdotme@gmail.com> writes: > On 11/29/23 20:53, Joe Lawrence wrote: >> On 11/29/23 08:25, Bagas Sanjaya wrote: >>> I was prompted to write this little grammar fix series when reading >>> the fix from Attreyee [1], with review comments requesting changes >>> to that fix. So here's my version of the fix, with reviews from [1] >>> addressed (and distinct grammar fixes splitted). >>> >> >> Typical kernel workflow would be for Attreyee to incorporate feedback >> and post their v2 after a day or two. From the format they posted, it >> appears to be a first(ish) kernel contribution post. Let's be kind and >> patient so they we all may benefit from the practice of iterating on >> their patch. >> > > I do this posting because I thought the OP (Attreyee) didn't respond in > timely manner (just like random Chinese contributors like @cdjrlc.com > and @208suo.com people). Seriously? The original post was on Monday, yours came less than 48 hours later. Not only can we not expect that kind of rapid turnaround from anybody, but we actively discourage rapid resending of patches. Rather than dig yourself in deeper, I suggest you simply apologize to the original poster and find something more useful to do. Thanks, jon
On Wed, Nov 29, 2023 at 03:26:18PM +0000, Matthew Wilcox wrote: > On Wed, Nov 29, 2023 at 07:29:35AM -0700, Jonathan Corbet wrote: > > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > > > I was prompted to write this little grammar fix series when reading > > > the fix from Attreyee [1], with review comments requesting changes > > > to that fix. So here's my version of the fix, with reviews from [1] > > > addressed (and distinct grammar fixes splitted). > > > > How is this helpful? Why are you trying to push aside somebody who is > > working toward a first contribution to the kernel? This is not the way > > to help somebody learn to work with the kernel community. > > This is not the first such "contribution" from Bagas recently. > > https://lore.kernel.org/linux-doc/20231121095658.28254-1-bagasdotme@gmail.com/ > > was as a result of > https://lore.kernel.org/linux-xfs/87r0klg8wl.fsf@debian-BULLSEYE-live-builder-AMD64/ > > I didn't say anything at the time, but clearly I should have squelched > this bad behaviour by Bagas before he did it to a newbie. > > Bagas, find your own project to work on. Don't steal glory from others. OK, thanks! I was in 'gabut mode' then...
On Wed, Nov 29, 2023 at 09:07:01PM +0530, Attreyee M wrote: > Respected Maintainers, > > Please give me some time to make the changes again. > I will be making the changes in a day. > Please don't top-post; reply inline with appropriate context instead. OK, see you in v2! Don't forget to Cc: me in the v2.
On Thu, Nov 30, 2023 at 12:08:33AM +0000, Matthew Wilcox wrote: > On Thu, Nov 30, 2023 at 06:58:16AM +0700, Bagas Sanjaya wrote: > > I do this posting because I thought the OP (Attreyee) didn't respond in > > timely manner (just like random Chinese contributors like @cdjrlc.com > > and @208suo.com people). > > That's a ridiculous excuse. The original posting was two days ago! > If it had been a week since we last heard from Attreyee, I'd understand. OK, thanks!
On Wed, Nov 29, 2023 at 05:10:25PM -0700, Jonathan Corbet wrote: > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > On 11/29/23 20:53, Joe Lawrence wrote: > >> On 11/29/23 08:25, Bagas Sanjaya wrote: > >>> I was prompted to write this little grammar fix series when reading > >>> the fix from Attreyee [1], with review comments requesting changes > >>> to that fix. So here's my version of the fix, with reviews from [1] > >>> addressed (and distinct grammar fixes splitted). > >>> > >> > >> Typical kernel workflow would be for Attreyee to incorporate feedback > >> and post their v2 after a day or two. From the format they posted, it > >> appears to be a first(ish) kernel contribution post. Let's be kind and > >> patient so they we all may benefit from the practice of iterating on > >> their patch. > >> > > > > I do this posting because I thought the OP (Attreyee) didn't respond in > > timely manner (just like random Chinese contributors like @cdjrlc.com > > and @208suo.com people). > > Seriously? The original post was on Monday, yours came less than 48 > hours later. Not only can we not expect that kind of rapid turnaround > from anybody, but we actively discourage rapid resending of patches. > Rather than dig yourself in deeper, I suggest you simply apologize to > the original poster and find something more useful to do. Done, thanks! And yes, I'm also focusing on regression tracking and Bugzilla triaging. Ciao, Bagas.