Message ID | 20231128132534.258459-1-herve.codina@bootlin.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3917095vqx; Tue, 28 Nov 2023 05:26:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGV1RqzjArWbmy+CyPfOUwPuBwLcLqAji9MaSIfj28itkB+ShP+qDjC+xAGzfLD1NtglN38 X-Received: by 2002:a05:6808:1790:b0:3a4:8251:5f43 with SMTP id bg16-20020a056808179000b003a482515f43mr21270179oib.40.1701177994299; Tue, 28 Nov 2023 05:26:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701177994; cv=none; d=google.com; s=arc-20160816; b=lsO6t/BpqssOd3acix5NLq+C8fEjSYqi3JaeWZxBjcy+nhqqFg0LmULSBciXcSZ9Ip mQKl7DKk4PeI7jTJ+UEqxkO79DUVi52v6kUS1QSGefhJA1xLucly6x1H4bRaVU3ofvqL vTaCLaXRagtrIrTEN9toaGzQACrUFPNEd0DJi/MXKhFWmXeI5lqVydHIbJokQnjxEmFk msAZSOD+HhOIsY0un4uylUxCu2schlYIqW222iVhxuwsWLnFc3+LjkO7fLrjQn9x38aC GA73GLLVUPgj+Qq6DQG6HS1T3caSVRFzJj5fVkUCR6/KOUo0x79pQ0hWRmERZVlpUVZY vbKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ofb5DztxekXhN3yofu4Ak0quar7W/LQtnV5utRbbo1M=; fh=uku+KBcSBcFp2fEL9QwZN6TXmwY0Y7a4DjuIywlWVtw=; b=AGgDQCy0pr1Jcf+pjSH4IUwlm4GPtNrWaZL5pMlu+M9SI0mpLdbdGqHVOwPiJ+JnQM 47Fd4znitastznJDxvHgRWy+W4vT/uxL5OQJrB73XgHSEx3I/VI7UlHeb68Io16Ku5FL yAylYVp/1drJ7CPfMx6zuydrYmAVbxAQ7nLHn7P0l4TExGtznudGSd20hAdFKbGI8mWC 2aW9PpVYqMdqvmL/+nINbw2IFqL4Bb/9vlOnTAZzkemuNL8EBvEU+7N92TjAj72m+Mv/ kUcF3qFzLwRbc8bF7su8vUFT7Xh60fEVN1jLNB1+PjKFSvzFNXRGJauaGMtffUVKP45v +L9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=l+sNZgcm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id cl6-20020a056a02098600b005b9b68add8bsi13304474pgb.785.2023.11.28.05.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 05:26:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=l+sNZgcm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 2C2D2823FACF; Tue, 28 Nov 2023 05:26:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345106AbjK1NZh (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Tue, 28 Nov 2023 08:25:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345214AbjK1NZe (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 28 Nov 2023 08:25:34 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EEEEDA; Tue, 28 Nov 2023 05:25:39 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPA id 9036B60004; Tue, 28 Nov 2023 13:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701177938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ofb5DztxekXhN3yofu4Ak0quar7W/LQtnV5utRbbo1M=; b=l+sNZgcmAYNacJGLGSpjTmMqdte0rwzAYJYNk8htPE1wdgCBf1ALXWJ02vxb6XgXBwJ1fx 76KDjQ/Ala/8VIvrvWOphL0RB3kRzCg/3H1cnvyL9a4ASDckPotv+RFnJGkjoJ39g9MXZZ Oyun/EL3sMKmPScZcbh1fQ/1YCgfMHpgy1yLFe1yKQekfTIgLIaJF9kxrx/YkwCc1I+4k+ Ni3cIaqsiA75IMmI3A9egAf5z9PbdNxAytsdBg7IHO4TS/zcMgD69161TTW7UA0zClj/x5 nche3zL2uH6/EVJxl9lY8Pa+ZmOPk0KZjM3Qts9k4ziFGyz6DF4BYYUYiolGpQ== From: Herve Codina <herve.codina@bootlin.com> To: Herve Codina <herve.codina@bootlin.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Christophe Leroy <christophe.leroy@csgroup.eu>, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: [PATCH 0/5] Add support for framer infrastructure and PEF2256 framer Date: Tue, 28 Nov 2023 14:25:29 +0100 Message-ID: <20231128132534.258459-1-herve.codina@bootlin.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 05:26:29 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783814416966667911 X-GMAIL-MSGID: 1783814416966667911 |
Series |
Add support for framer infrastructure and PEF2256 framer
|
|
Message
Herve Codina
Nov. 28, 2023, 1:25 p.m. UTC
Hi, This series introduces the framer infrastructure and adds the PEF2256 framer provider. Patches were previously sent as part of a full feature series and were previously reviewed in that context: "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] In order to ease the merge, the full feature series has been split and this series contains patches related to the framer part (infrastructure and provider). - Introduce framer infrastructure (patch 1) - Add PEF2256 framer provider (patches 2, 3, 4, 5) Compare to the original full feature series, a modification was done on patch 3 in order to fix a dependency issue detected my a kernel test robot. Best regards, Hervé [1]: https://lore.kernel.org/linux-kernel/20231115144007.478111-1-herve.codina@bootlin.com/ Changes compare to the full feature series: - Patch 3 Add 'depends on HAS_IOMEM' to fix the following issue detected by a kernel test robot: WARNING: unmet direct dependencies detected for MFD_CORE Depends on [n]: HAS_IOMEM [=n] Selected by [y]: - FRAMER_PEF2256 [=y] && NETDEVICES [=y] && WAN [=y] && FRAMER [=y] && OF [=y] Patches extracted: - Patch 1 : full feature series patch 21 - Patch 2 : full feature series patch 22 - Patch 3 : full feature series patch 23 - Patch 4 : full feature series patch 24 - Patch 5 : full feature series patch 25 Herve Codina (5): net: wan: Add framer framework support dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer net: wan: framer: Add support for the Lantiq PEF2256 framer pinctrl: Add support for the Lantic PEF2256 pinmux MAINTAINERS: Add the Lantiq PEF2256 driver entry .../bindings/net/lantiq,pef2256.yaml | 213 +++++ MAINTAINERS | 8 + drivers/net/wan/Kconfig | 2 + drivers/net/wan/Makefile | 2 + drivers/net/wan/framer/Kconfig | 42 + drivers/net/wan/framer/Makefile | 7 + drivers/net/wan/framer/framer-core.c | 882 ++++++++++++++++++ drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 +++++++++++++++++ drivers/pinctrl/Kconfig | 15 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256.c | 358 +++++++ include/linux/framer/framer-provider.h | 194 ++++ include/linux/framer/framer.h | 205 ++++ include/linux/framer/pef2256.h | 31 + 16 files changed, 3098 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 drivers/pinctrl/pinctrl-pef2256.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h create mode 100644 include/linux/framer/pef2256.h
Comments
On Tue, Nov 28, 2023 at 02:25:29PM +0100, Herve Codina wrote: > Hi, > > This series introduces the framer infrastructure and adds the PEF2256 > framer provider. > > Patches were previously sent as part of a full feature series and were > previously reviewed in that context: > "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] > > In order to ease the merge, the full feature series has been split and > this series contains patches related to the framer part (infrastructure > and provider). > - Introduce framer infrastructure (patch 1) > - Add PEF2256 framer provider (patches 2, 3, 4, 5) If this gets applied it'd be good to get a signed tag based off Linus' tree so things that depend on it can be pulled into other trees (eg, the ASoC mapping for the framer).
On Tue, Nov 28, 2023 at 3:03 PM Mark Brown <broonie@kernel.org> wrote: > On Tue, Nov 28, 2023 at 02:25:29PM +0100, Herve Codina wrote: > > Hi, > > > > This series introduces the framer infrastructure and adds the PEF2256 > > framer provider. > > > > Patches were previously sent as part of a full feature series and were > > previously reviewed in that context: > > "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] > > > > In order to ease the merge, the full feature series has been split and > > this series contains patches related to the framer part (infrastructure > > and provider). > > - Introduce framer infrastructure (patch 1) > > - Add PEF2256 framer provider (patches 2, 3, 4, 5) > > If this gets applied it'd be good to get a signed tag based off Linus' > tree so things that depend on it can be pulled into other trees (eg, the > ASoC mapping for the framer). Do you mean my pin control tree or the big penguins tree? :D (I'm guessing mine.) I thought this thing would be merged primarily into the networking tree, and I don't know if they do signed tags, I usually create an immutable branch but that should work just as fine I guess. If people wants this from the pinctrl tree (and patches are ACKed by everyone involved etc) I can certainly do that if the netdev people are happy to pull an immutable branch from me. Yours, Linus Walleij
On Tue, Nov 28, 2023 at 03:26:56PM +0100, Linus Walleij wrote: > On Tue, Nov 28, 2023 at 3:03 PM Mark Brown <broonie@kernel.org> wrote: > > If this gets applied it'd be good to get a signed tag based off Linus' > > tree so things that depend on it can be pulled into other trees (eg, the > > ASoC mapping for the framer). > Do you mean my pin control tree or the big penguins tree? :D > (I'm guessing mine.) I actually meant mainline there. > I thought this thing would be merged primarily into the networking > tree, and I don't know if they do signed tags, I usually create an > immutable branch but that should work just as fine I guess. Right, I'd expect a signed tag on the immutable branch - it's generally helpful to avoid confusion about the branch actually being immutable.
On Tue, Nov 28, 2023 at 3:41 PM Mark Brown <broonie@kernel.org> wrote: > On Tue, Nov 28, 2023 at 03:26:56PM +0100, Linus Walleij wrote: > > On Tue, Nov 28, 2023 at 3:03 PM Mark Brown <broonie@kernel.org> wrote: > > > > If this gets applied it'd be good to get a signed tag based off Linus' > > > tree so things that depend on it can be pulled into other trees (eg, the > > > ASoC mapping for the framer). > > > Do you mean my pin control tree or the big penguins tree? :D > > (I'm guessing mine.) > > I actually meant mainline there. Ah based off, not residing in. My bad. > > I thought this thing would be merged primarily into the networking > > tree, and I don't know if they do signed tags, I usually create an > > immutable branch but that should work just as fine I guess. > > Right, I'd expect a signed tag on the immutable branch - it's generally > helpful to avoid confusion about the branch actually being immutable. Makes sense, best to create that in the netdev tree if possible I guess. Yours, Linus Walleij
On Tue, 28 Nov 2023 15:51:01 +0100 Linus Walleij wrote: > > > I thought this thing would be merged primarily into the networking > > > tree, and I don't know if they do signed tags, I usually create an > > > immutable branch but that should work just as fine I guess. > > > > Right, I'd expect a signed tag on the immutable branch - it's generally > > helpful to avoid confusion about the branch actually being immutable. > > Makes sense, best to create that in the netdev tree if possible > I guess. I think you offered creating the branch / tag in an earlier reply, that's less work for me so yes please! :) FWIW I usually put the branches / tags in my personal k.org tree. I don't wanna pollute the trees for the $many people who fetch netdev with random tags.
On Wed, Nov 29, 2023 at 2:31 AM Jakub Kicinski <kuba@kernel.org> wrote: > On Tue, 28 Nov 2023 15:51:01 +0100 Linus Walleij wrote: > > > > I thought this thing would be merged primarily into the networking > > > > tree, and I don't know if they do signed tags, I usually create an > > > > immutable branch but that should work just as fine I guess. > > > > > > Right, I'd expect a signed tag on the immutable branch - it's generally > > > helpful to avoid confusion about the branch actually being immutable. > > > > Makes sense, best to create that in the netdev tree if possible > > I guess. > > I think you offered creating the branch / tag in an earlier reply, > that's less work for me so yes please! :) OK I fix! Just waiting for some final reviews to trickle in. Herve: nag me if it doesn't happen in time! > FWIW I usually put the branches / tags in my personal k.org tree. > I don't wanna pollute the trees for the $many people who fetch > netdev with random tags. Aha yeah pin control is relatively small so I just carry misc sync tags there. Yours, Linus Walleij
Hi Linus, On Wed, 29 Nov 2023 15:00:40 +0100 Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Nov 29, 2023 at 2:31 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 28 Nov 2023 15:51:01 +0100 Linus Walleij wrote: > > > > > I thought this thing would be merged primarily into the networking > > > > > tree, and I don't know if they do signed tags, I usually create an > > > > > immutable branch but that should work just as fine I guess. > > > > > > > > Right, I'd expect a signed tag on the immutable branch - it's generally > > > > helpful to avoid confusion about the branch actually being immutable. > > > > > > Makes sense, best to create that in the netdev tree if possible > > > I guess. > > > > I think you offered creating the branch / tag in an earlier reply, > > that's less work for me so yes please! :) > > OK I fix! > > Just waiting for some final reviews to trickle in. > > Herve: nag me if it doesn't happen in time! As you tell me, this is my reminder. Best regards, Hervé > > > FWIW I usually put the branches / tags in my personal k.org tree. > > I don't wanna pollute the trees for the $many people who fetch > > netdev with random tags. > > Aha yeah pin control is relatively small so I just carry misc sync > tags there. > > Yours, > Linus Walleij
Hi Herve, Jakub, Mark, here is an immutable tag for the PEF2256 framer, as promised. I have already merged it into the pinctrl tree for starters. Yours, Linus Walleij The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86: Linux 6.7-rc1 (2023-11-12 16:19:07 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git tags/pef2256-framer for you to fetch changes up to 1e95d20ae8e6a383b4c1dd2282e5259790724037: MAINTAINERS: Add the Lantiq PEF2256 driver entry (2023-12-12 23:05:25 +0100) ---------------------------------------------------------------- Immutable tag for the PEF2256 framer ---------------------------------------------------------------- Herve Codina (5): net: wan: Add framer framework support dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer net: wan: framer: Add support for the Lantiq PEF2256 framer pinctrl: Add support for the Lantic PEF2256 pinmux MAINTAINERS: Add the Lantiq PEF2256 driver entry .../devicetree/bindings/net/lantiq,pef2256.yaml | 213 +++++ MAINTAINERS | 8 + drivers/net/wan/Kconfig | 2 + drivers/net/wan/Makefile | 2 + drivers/net/wan/framer/Kconfig | 42 + drivers/net/wan/framer/Makefile | 7 + drivers/net/wan/framer/framer-core.c | 882 +++++++++++++++++++++ drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 ++++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 ++++++++++++++++++++ drivers/pinctrl/Kconfig | 15 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256.c | 358 +++++++++ include/linux/framer/framer-provider.h | 194 +++++ include/linux/framer/framer.h | 205 +++++ include/linux/framer/pef2256.h | 31 + 16 files changed, 3098 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 drivers/pinctrl/pinctrl-pef2256.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h create mode 100644 include/linux/framer/pef2256.h
On Tue, 12 Dec 2023 23:15:38 +0100 Linus Walleij wrote: > here is an immutable tag for the PEF2256 framer, as promised. > > I have already merged it into the pinctrl tree for starters. Pulled to net-next as well, thank you!