mbox series

[v8,0/7] Add TPS6594 PMIC support on several boards

Message ID 20231128055230.342547-1-n-francis@ti.com
Headers
Series Add TPS6594 PMIC support on several boards |

Message

Neha Malcom Francis Nov. 28, 2023, 5:52 a.m. UTC 
  TPS6594 is a Power Management IC which provides regulators and others
features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
communicate through the I2C or SPI interfaces.
TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.

This series adds device tree nodes for TI TPS6594 PMICs found in the
following boards:
- J721EXSOMXEVM:
  Link: https://www.ti.com/tool/J721EXSOMXEVM
- J721S2XSOMXEVM:
  Link: https://www.ti.com/tool/J721S2XSOMXEVM
- J7200XSOMXEVM:
  Link: https://www.ti.com/tool/J7200XSOMXEVM
- J784S4XEVM
  Link: https://www.ti.com/tool/J784S4XEVM
- SK-AM69
  Link: https://www.ti.com/tool/SK-AM69
- SK-TDA4VM (J721E-SK)
  Link: https://www.ti.com/tool/SK-TDA4VM

Boot Logs with required config (DONOTMERGE patch) enabled:
https://gist.github.com/nehamalcom/f47fcd6183360ed8a146c9ba456202c3
Boot Logs without config enabled:
https://gist.github.com/nehamalcom/58217b100e614ae55726f314e02b5001

---
Changes from v7:
https://lore.kernel.org/all/20231122104513.2335757-1-n-francis@ti.com/
- (New Patches) Add support for SK boards that have TPS6594xx PMIC
  present (J721E-SK and AM69-SK)
- Add DONOTMERGE defconfig patch to show test logs

Changes from v6:
https://lore.kernel.org/all/20230810-tps6594-v6-0-2b2e2399e2ef@ti.com/
- Modify patch series to include only patches not merged (J7)
- Add boot logs for all affected boards

Changes from v5:
https://lore.kernel.org/all/20230809-tps6594-v5-0-485fd3d63670@ti.com
- Range-diff: http://0x0.st/H_fD.diff
- Reword the patch fixing interrupt ranges for mcu domain gpio intr, and
  add Fixes: tag
- Also fix interrupt ranges for main domain gpio intr in the same patch
- Change pinctrl node names to end in -pins to fix dtbs_check warnings
- (New Patch) Enable TPS6594 in defconfig

Changes from v4:
https://lore.kernel.org/all/20230727130908.10656-1-eblanc@baylibre.com/
- Range-diff: https://0x0.st/H_L7.diff
- Rebased on top of linux-next
- Fix min voltage on vdd_usb_3v3 regulator (ldo2) on j721e-som
- Use 3-hex-digit format for pinctrl values

Changes from v3:
https://lore.kernel.org/all/20230417154832.216774-1-eblanc@baylibre.com/
- Rebased on top of v6.5-rc1.
- Change pinctrl number for irq pin as wkup_pmx0 was split on some boards.
- Use already present wkup_i2c0 node instead of creating a new one.

Changes from v2:
https://lore.kernel.org/lkml/20230414112843.1358067-1-eblanc@baylibre.com/
- Change node name as per Krzysztof review.
- Add a fix for the interrupt range of wakeup gpio used by TPS6594 pmic
  on J784S4.
  The interruptions of the PMIC were not working before that.
- Remove dependencies on other patch series as that was a mistake, see
  https://lore.kernel.org/lkml/CRYY2V3HJ0CP.96JQ18PLZB3C@burritosblues/

Changes from v1:
https://lore.kernel.org/lkml/20230329142948.833800-1-eblanc@baylibre.com/
- Harmonize regulators names across the different boards.
- Adjust AVS voltage range.
- Remove some outdated comments.
- Add PMIC to J784S4 board.
- Compatible string modified to match dt-bindings.
- Add gpio-controller and gpio-cells properties.

Esteban Blanc (2):
  arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
  arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs

Jerome Neanne (2):
  arm64: dts: ti: k3-j721e-som-p0: Add TP6594 family PMICs
  arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC

Neha Malcom Francis (3):
  arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC
  arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs
  DONOTMERGE: arm64: defconfig: Enable TPS6594 PMIC for J7 devices

 arch/arm64/boot/dts/ti/k3-am69-sk.dts        | 100 ++++++++++
 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 157 +++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts       | 154 ++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 163 +++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 199 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 104 ++++++++++
 arch/arm64/configs/defconfig                 |   2 +-
 7 files changed, 878 insertions(+), 1 deletion(-)

Comments

Kumar, Udit Dec. 4, 2023, 4:09 a.m. UTC | #1 
On 11/28/2023 11:22 AM, Neha Malcom Francis wrote:
> TPS6594 is a Power Management IC which provides regulators and others
> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> communicate through the I2C or SPI interfaces.
> TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.

Please consider adding bootph property in avs regulator node.

Thanks

Udit


> This series adds device tree nodes for TI TPS6594 PMICs found in the
> following boards:
> - J721EXSOMXEVM:
>    Link: https://www.ti.com/tool/J721EXSOMXEVM
> - J721S2XSOMXEVM:
>    Link: https://www.ti.com/tool/J721S2XSOMXEVM
> - J7200XSOMXEVM:
>    Link: https://www.ti.com/tool/J7200XSOMXEVM
> - J784S4XEVM
>    Link: https://www.ti.com/tool/J784S4XEVM
> - SK-AM69
>    Link: https://www.ti.com/tool/SK-AM69
> - SK-TDA4VM (J721E-SK)
>    Link: https://www.ti.com/tool/SK-TDA4VM
>
> Boot Logs with required config (DONOTMERGE patch) enabled:
> https://gist.github.com/nehamalcom/f47fcd6183360ed8a146c9ba456202c3
> Boot Logs without config enabled:
> https://gist.github.com/nehamalcom/58217b100e614ae55726f314e02b5001
>
> ---
> Changes from v7:
> https://lore.kernel.org/all/20231122104513.2335757-1-n-francis@ti.com/
> - (New Patches) Add support for SK boards that have TPS6594xx PMIC
>    present (J721E-SK and AM69-SK)
> - Add DONOTMERGE defconfig patch to show test logs
>
> Changes from v6:
> https://lore.kernel.org/all/20230810-tps6594-v6-0-2b2e2399e2ef@ti.com/
> - Modify patch series to include only patches not merged (J7)
> - Add boot logs for all affected boards
>
> Changes from v5:
> https://lore.kernel.org/all/20230809-tps6594-v5-0-485fd3d63670@ti.com
> - Range-diff: http://0x0.st/H_fD.diff
> - Reword the patch fixing interrupt ranges for mcu domain gpio intr, and
>    add Fixes: tag
> - Also fix interrupt ranges for main domain gpio intr in the same patch
> - Change pinctrl node names to end in -pins to fix dtbs_check warnings
> - (New Patch) Enable TPS6594 in defconfig
>
> Changes from v4:
> https://lore.kernel.org/all/20230727130908.10656-1-eblanc@baylibre.com/
> - Range-diff: https://0x0.st/H_L7.diff
> - Rebased on top of linux-next
> - Fix min voltage on vdd_usb_3v3 regulator (ldo2) on j721e-som
> - Use 3-hex-digit format for pinctrl values
>
> Changes from v3:
> https://lore.kernel.org/all/20230417154832.216774-1-eblanc@baylibre.com/
> - Rebased on top of v6.5-rc1.
> - Change pinctrl number for irq pin as wkup_pmx0 was split on some boards.
> - Use already present wkup_i2c0 node instead of creating a new one.
>
> Changes from v2:
> https://lore.kernel.org/lkml/20230414112843.1358067-1-eblanc@baylibre.com/
> - Change node name as per Krzysztof review.
> - Add a fix for the interrupt range of wakeup gpio used by TPS6594 pmic
>    on J784S4.
>    The interruptions of the PMIC were not working before that.
> - Remove dependencies on other patch series as that was a mistake, see
>    https://lore.kernel.org/lkml/CRYY2V3HJ0CP.96JQ18PLZB3C@burritosblues/
>
> Changes from v1:
> https://lore.kernel.org/lkml/20230329142948.833800-1-eblanc@baylibre.com/
> - Harmonize regulators names across the different boards.
> - Adjust AVS voltage range.
> - Remove some outdated comments.
> - Add PMIC to J784S4 board.
> - Compatible string modified to match dt-bindings.
> - Add gpio-controller and gpio-cells properties.
>
> Esteban Blanc (2):
>    arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
>    arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs
>
> Jerome Neanne (2):
>    arm64: dts: ti: k3-j721e-som-p0: Add TP6594 family PMICs
>    arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC
>
> Neha Malcom Francis (3):
>    arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC
>    arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs
>    DONOTMERGE: arm64: defconfig: Enable TPS6594 PMIC for J7 devices
>
>   arch/arm64/boot/dts/ti/k3-am69-sk.dts        | 100 ++++++++++
>   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 157 +++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts       | 154 ++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 163 +++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 199 +++++++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 104 ++++++++++
>   arch/arm64/configs/defconfig                 |   2 +-
>   7 files changed, 878 insertions(+), 1 deletion(-)
>
Neha Malcom Francis Dec. 4, 2023, 4:12 a.m. UTC | #2 
Hi Udit,

On 04/12/23 09:39, Kumar, Udit wrote:
> 
> On 11/28/2023 11:22 AM, Neha Malcom Francis wrote:
>> TPS6594 is a Power Management IC which provides regulators and others
>> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
>> PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
>> communicate through the I2C or SPI interfaces.
>> TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> 
> Please consider adding bootph property in avs regulator node.
> 
> Thanks
> 
> Udit
> 

Thanks for catching that, I'll send out v9 with the bootph property added.

> 
>> This series adds device tree nodes for TI TPS6594 PMICs found in the
>> following boards:
>> - J721EXSOMXEVM:
>>    Link: https://www.ti.com/tool/J721EXSOMXEVM
>> - J721S2XSOMXEVM:
>>    Link: https://www.ti.com/tool/J721S2XSOMXEVM
>> - J7200XSOMXEVM:
>>    Link: https://www.ti.com/tool/J7200XSOMXEVM
>> - J784S4XEVM
>>    Link: https://www.ti.com/tool/J784S4XEVM
>> - SK-AM69
>>    Link: https://www.ti.com/tool/SK-AM69
>> - SK-TDA4VM (J721E-SK)
>>    Link: https://www.ti.com/tool/SK-TDA4VM
>>
>> Boot Logs with required config (DONOTMERGE patch) enabled:
>> https://gist.github.com/nehamalcom/f47fcd6183360ed8a146c9ba456202c3
>> Boot Logs without config enabled:
>> https://gist.github.com/nehamalcom/58217b100e614ae55726f314e02b5001
>>
>> ---
>> Changes from v7:
>> https://lore.kernel.org/all/20231122104513.2335757-1-n-francis@ti.com/
>> - (New Patches) Add support for SK boards that have TPS6594xx PMIC
>>    present (J721E-SK and AM69-SK)
>> - Add DONOTMERGE defconfig patch to show test logs
>>
>> Changes from v6:
>> https://lore.kernel.org/all/20230810-tps6594-v6-0-2b2e2399e2ef@ti.com/
>> - Modify patch series to include only patches not merged (J7)
>> - Add boot logs for all affected boards
>>
>> Changes from v5:
>> https://lore.kernel.org/all/20230809-tps6594-v5-0-485fd3d63670@ti.com
>> - Range-diff: http://0x0.st/H_fD.diff
>> - Reword the patch fixing interrupt ranges for mcu domain gpio intr, and
>>    add Fixes: tag
>> - Also fix interrupt ranges for main domain gpio intr in the same patch
>> - Change pinctrl node names to end in -pins to fix dtbs_check warnings
>> - (New Patch) Enable TPS6594 in defconfig
>>
>> Changes from v4:
>> https://lore.kernel.org/all/20230727130908.10656-1-eblanc@baylibre.com/
>> - Range-diff: https://0x0.st/H_L7.diff
>> - Rebased on top of linux-next
>> - Fix min voltage on vdd_usb_3v3 regulator (ldo2) on j721e-som
>> - Use 3-hex-digit format for pinctrl values
>>
>> Changes from v3:
>> https://lore.kernel.org/all/20230417154832.216774-1-eblanc@baylibre.com/
>> - Rebased on top of v6.5-rc1.
>> - Change pinctrl number for irq pin as wkup_pmx0 was split on some boards.
>> - Use already present wkup_i2c0 node instead of creating a new one.
>>
>> Changes from v2:
>> https://lore.kernel.org/lkml/20230414112843.1358067-1-eblanc@baylibre.com/
>> - Change node name as per Krzysztof review.
>> - Add a fix for the interrupt range of wakeup gpio used by TPS6594 pmic
>>    on J784S4.
>>    The interruptions of the PMIC were not working before that.
>> - Remove dependencies on other patch series as that was a mistake, see
>>    https://lore.kernel.org/lkml/CRYY2V3HJ0CP.96JQ18PLZB3C@burritosblues/
>>
>> Changes from v1:
>> https://lore.kernel.org/lkml/20230329142948.833800-1-eblanc@baylibre.com/
>> - Harmonize regulators names across the different boards.
>> - Adjust AVS voltage range.
>> - Remove some outdated comments.
>> - Add PMIC to J784S4 board.
>> - Compatible string modified to match dt-bindings.
>> - Add gpio-controller and gpio-cells properties.
>>
>> Esteban Blanc (2):
>>    arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
>>    arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs
>>
>> Jerome Neanne (2):
>>    arm64: dts: ti: k3-j721e-som-p0: Add TP6594 family PMICs
>>    arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC
>>
>> Neha Malcom Francis (3):
>>    arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC
>>    arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs
>>    DONOTMERGE: arm64: defconfig: Enable TPS6594 PMIC for J7 devices
>>
>>   arch/arm64/boot/dts/ti/k3-am69-sk.dts        | 100 ++++++++++
>>   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 157 +++++++++++++++
>>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts       | 154 ++++++++++++++
>>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 163 +++++++++++++++
>>   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 199 +++++++++++++++++++
>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 104 ++++++++++
>>   arch/arm64/configs/defconfig                 |   2 +-
>>   7 files changed, 878 insertions(+), 1 deletion(-)
>>