From patchwork Tue Nov 28 05:32:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiachen Zhang X-Patchwork-Id: 17183 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3698151vqx; Mon, 27 Nov 2023 21:34:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7lp5yCshP8YIspYpZrmNwcU8j/9/ClmHBOYgcvXzogNQ4XlCbdu4cTXiTCVYglJeQ3EDd X-Received: by 2002:a05:6870:d62b:b0:1fa:14a1:1d90 with SMTP id a43-20020a056870d62b00b001fa14a11d90mr13219783oaq.33.1701149663711; Mon, 27 Nov 2023 21:34:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701149663; cv=none; d=google.com; s=arc-20160816; b=q/0U4+FnKO7ohFqBNcPKBbKyfRx9P48D0T00Teiitxp786K8VuLC2g460DHNZKkrXB A9iK0NNkhIaf4iFJqnnVkI1vIa8W4giYs+bMr0jZXirg8nmtCKbnhpaMtX7xANyvh36N uOypaeJYDgzNKiQUDIMZ9oURqSTPOB90sVdfNZUlvg3yYJl76zZu2zo2dkkJZUq2o32h dodbtjne0fOpv3CysbDffo0c5Lu5L8CYJdmxr26njeGUkYA8Js8ChAF7W+u3BPcBAqHu JW/wjc6Tr3uuqUIeuB1LjbfflZdEAQg+9DK9IZvbT+/nHTZeZtWyvKPN/AEi0ItmmqoO f97A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yppdPakpPj/hSLJ9uZBVv46+PUQYqbzCgWp1lHeXxis=; fh=af6/g7Mw4PWw8c1/IQL1lMUyTpO0lxbaYh3SFBWn9U8=; b=axLpE3T8Cy0wijRKNlRXZWBcfUxuvCYS4tsXREskDWFu8AGikMGxorphmB8WKcBbo4 saWRJnyLWTfWo/cAZfE55g3LxXB5b1Olg0HQ508BG6Xzo5xx/gqg3KeqLOxYr+vCMJrr 4w4jS25vvT4KQHajz+cZ1BXFBwm+XqzZsaq9V9aCJO8P9xlL9GArFUHHFVuSNMAmIiUV 416j725BOuA7gzwETnA6EHo91A7QwaUX4ptvwnoQCUeQ0hXgUNwrkkKX3l9TRm4aHKtG q2mOipZTwWuf1Wn0am4p7U3Ick2k2bG/oV5hclO+5Es9gCM2lgKkFPf4kpZ5Qj0ZuIug 7shw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=fGfkLpjI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id s1-20020a056a0008c100b006cb6338dd60si11867800pfu.19.2023.11.27.21.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:34:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=fGfkLpjI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 58FEA805FD5A; Mon, 27 Nov 2023 21:34:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232892AbjK1FeJ (ORCPT + 99 others); Tue, 28 Nov 2023 00:34:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232810AbjK1FeI (ORCPT ); Tue, 28 Nov 2023 00:34:08 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88A6DCC for ; Mon, 27 Nov 2023 21:34:14 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6cd89f2af9dso2039266b3a.1 for ; Mon, 27 Nov 2023 21:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1701149654; x=1701754454; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yppdPakpPj/hSLJ9uZBVv46+PUQYqbzCgWp1lHeXxis=; b=fGfkLpjItIfWDyLNc/yBvAmWdQFixpU3BXrR9zcmm3PnEtVMnK2QucsZtT0AK3dmtd vZi0kdojw9PjqxAKUrLHTTNnxU0cQRp5pySKmft4XRoc+WG93GTSSfFy21jLysySEcvp qRMJoEzEnoiVWJwVar+SZu5E+bymzHsWOhL/Wv+e0/iv0p0bjKjl9GgN8lrMuJEty2x+ EYkdql0EMDWOmgHD5r8uv5NCeHN7gylmQObm5euHBpgnAQHSlyQnP47qZmSGcE0ngVPP TcnaZYYBO4C6GwccJJaCRb7rGSsKoTU9NkZYiBZDsh9Qw1tBfvW4k6bw7zggA82YxgRd R5MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701149654; x=1701754454; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yppdPakpPj/hSLJ9uZBVv46+PUQYqbzCgWp1lHeXxis=; b=BlRjHM7AgCE3UJ8NdFx6KbJTZM1tNXS8/rk/HA82BS7CbFtA73oRLLwKwQqJdIKiw+ DbWNzYxK2T4PE7dQGDdTFId0xjm/jXRkw0+TQ0vWw8RKYvEtGoOQWpt5QKz3UnsrIRzg ZewTiH5BdDIyUjXhJ3WP0yjKLpKk3OkLlvCMLkWopdS/hvD+YElx+xe5iL0UuNXsl0cr GmoluftYuB7ymJe94Z+8OPck9ky7Eh0B6xB6uFS6IPj6G1LIzB0OWlZhhFijeEhjrDUK hRXLagLH4VoR3DHJP9M3mSNXPhG1EOBrBrDN5amvyqUnZwfVPvu9yQJuIHt4lKNYjHFU rrEg== X-Gm-Message-State: AOJu0YxvI3G3LYc0Lldc5a7HrPyXTpXeSWd80kFmuHpWlGBFTHuwA6e9 zzrNyc+H9MyseQXmzHmjcmb5LLQoX+S/QdtNGZ0+ZTLb X-Received: by 2002:a05:6a20:12d3:b0:18b:d3db:7048 with SMTP id v19-20020a056a2012d300b0018bd3db7048mr18160990pzg.23.1701149654057; Mon, 27 Nov 2023 21:34:14 -0800 (PST) Received: from localhost.localdomain ([61.213.176.14]) by smtp.gmail.com with ESMTPSA id u12-20020a17090341cc00b001cfb6bef8fesm5372899ple.186.2023.11.27.21.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:34:13 -0800 (PST) From: Jiachen Zhang To: Chandan Babu R , "Darrick J. Wong" Cc: Dave Chinner , Allison Henderson , Zhang Tianci , Brian Foster , Ben Myers , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, xieyongji@bytedance.com, me@jcix.top, Jiachen Zhang Subject: [PATCH 0/2] Fixes for ENOSPC xfs_remove Date: Tue, 28 Nov 2023 13:32:00 +0800 Message-Id: <20231128053202.29007-1-zhangjiachen.jaycee@bytedance.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 27 Nov 2023 21:34:19 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783784709752601986 X-GMAIL-MSGID: 1783784709752601986 Hi, Recently, our use-case ran into 2 bugs in case doing xfs_remove when the disk space is in-pressure, which may cause xfs shutdown and kernel crash in the xfs log recovery procedure. Here are 2 patches to fix the problem. The 1st patch fixes an uninitialized variable issue. The 2nd patch ensures the blkno in the xfs_buf is updated when doing xfs_da3_swap_lastblock(). Thanks, Jiachen Jiachen Zhang (1): xfs: ensure tmp_logflags is initialized in xfs_bmap_del_extent_real Zhang Tianci (1): xfs: update dir3 leaf block metadata after swap fs/xfs/libxfs/xfs_bmap.c | 6 ++++-- fs/xfs/libxfs/xfs_da_btree.c | 12 +++++++++++- 2 files changed, 15 insertions(+), 3 deletions(-)