mbox series

[net-next,v7,0/3] Fine-Tune Flow Control and Speed Configurations in Microchip KSZ8xxx DSA Driver

Message ID 20231127145101.3039399-1-o.rempel@pengutronix.de
Headers
Series Fine-Tune Flow Control and Speed Configurations in Microchip KSZ8xxx DSA Driver |

Message

Oleksij Rempel Nov. 27, 2023, 2:50 p.m. UTC 
  changes v7:
- make pause configuration depend on MLO_PAUSE_AN
- use duplex == DUPLEX_HALF

changes v6:
- move pause controls out of duplex scope

changes v5:
- add Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
- use regs[S_BROADCAST_CTRL] instead of REG_SW_CTRL_4 as requested.
- s/synchronous/symmetric/
- make phylink_mac_link_up() not optional, as requested 

changes v4:
- instead of downstream/upstream use CPU-port and PHY-port
- adjust comments
- minor fixes

changes v3:
- remove half duplex flow control configuration
- add comments
- s/stram/stream

changes v2:
- split the patch to upstream and downstream part
- add comments
- fix downstream register offset
- fix CPU configuration

This patch set focuses on enhancing the configurability of flow
control, speed, and duplex settings in the Microchip KSZ8xxx DSA driver.

The first patch allows more granular control over the CPU port's flow
control, speed, and duplex settings. The second patch introduces a
method for port configurations for port with integrated PHYs, primarily
concerning flow control based on duplex mode.

Oleksij Rempel (3):
  net: dsa: microchip: ksz8: Make flow control, speed, and duplex on CPU
    port configurable
  net: dsa: microchip: ksz8: Add function to configure ports with
    integrated PHYs
  net: dsa: microchip: make phylink_mac_link_up() not optional

 drivers/net/dsa/microchip/ksz8.h       |   4 +
 drivers/net/dsa/microchip/ksz8795.c    | 123 ++++++++++++++++++++++++-
 drivers/net/dsa/microchip/ksz_common.c |  11 ++-
 drivers/net/dsa/microchip/ksz_common.h |   1 +
 4 files changed, 132 insertions(+), 7 deletions(-)

Comments

Russell King (Oracle) Nov. 27, 2023, 3:10 p.m. UTC | #1 
On Mon, Nov 27, 2023 at 03:50:58PM +0100, Oleksij Rempel wrote:
> changes v7:
> - make pause configuration depend on MLO_PAUSE_AN
> - use duplex == DUPLEX_HALF

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks for addressing my feedback!
patchwork-bot+netdevbpf@kernel.org Nov. 29, 2023, 4:50 p.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 27 Nov 2023 15:50:58 +0100 you wrote:
> changes v7:
> - make pause configuration depend on MLO_PAUSE_AN
> - use duplex == DUPLEX_HALF
> 
> changes v6:
> - move pause controls out of duplex scope
> 
> [...]

Here is the summary with links:
  - [net-next,v7,1/3] net: dsa: microchip: ksz8: Make flow control, speed, and duplex on CPU port configurable
    https://git.kernel.org/netdev/net-next/c/87f062ed853c
  - [net-next,v7,2/3] net: dsa: microchip: ksz8: Add function to configure ports with integrated PHYs
    https://git.kernel.org/netdev/net-next/c/2f58148c41e2
  - [net-next,v7,3/3] net: dsa: microchip: make phylink_mac_link_up() not optional
    https://git.kernel.org/netdev/net-next/c/71cd5ce7e2f3

You are awesome, thank you!