mbox series

[v2,0/5] vduse: Add support for reconnection

Message ID 20231121073050.287080-1-lulu@redhat.com
Headers
Series vduse: Add support for reconnection |

Message

Cindy Lu Nov. 21, 2023, 7:30 a.m. UTC 
  Here is the reconnect support in vduse,

kernel will allocted pages for reconnection
userspace need use ioctl VDUSE_GET_RECONNECT_INFO to
get the mmap related information and then mapping these pages
to userspace.
kernel and userspace will use these pages to sync
the reconnect information
kernel will use VDUSE_VQ_GET_INFO to sync the information      
userspace App  will call during the "user_app_dev_start()".

change in V2  
1. Address the comments from v1
2. Add the document for reconnect process

Cindy Lu (5):
  vduse: Add function to get/free the pages for reconnection
  vduse: Add file operation for mmap
  vduse: Add new ioctl VDUSE_GET_RECONNECT_INFO
  vduse: update the vq_info in ioctl
  Documentation: Add reconnect process for VDUSE

 Documentation/userspace-api/vduse.rst |  29 ++++
 drivers/vdpa/vdpa_user/vduse_dev.c    | 198 +++++++++++++++++++++++++-
 include/uapi/linux/vduse.h            |  50 +++++++
 3 files changed, 276 insertions(+), 1 deletion(-)

Comments

Jason Wang Nov. 22, 2023, 6:11 a.m. UTC | #1 
On Tue, Nov 21, 2023 at 3:30 PM Cindy Lu <lulu@redhat.com> wrote:
>
> Here is the reconnect support in vduse,
>
> kernel will allocted pages for reconnection
> userspace need use ioctl VDUSE_GET_RECONNECT_INFO to
> get the mmap related information and then mapping these pages
> to userspace.
> kernel and userspace will use these pages to sync
> the reconnect information
> kernel will use VDUSE_VQ_GET_INFO to sync the information
> userspace App  will call during the "user_app_dev_start()".

It would be better to describe the uAPI instead of duplicating the
logic of the codes.

>
> change in V2
> 1. Address the comments from v1

It's better to be more verbose here, people can easily forget the
comments since V1.

Thanks

> 2. Add the document for reconnect process
>
> Cindy Lu (5):
>   vduse: Add function to get/free the pages for reconnection
>   vduse: Add file operation for mmap
>   vduse: Add new ioctl VDUSE_GET_RECONNECT_INFO
>   vduse: update the vq_info in ioctl
>   Documentation: Add reconnect process for VDUSE
>
>  Documentation/userspace-api/vduse.rst |  29 ++++
>  drivers/vdpa/vdpa_user/vduse_dev.c    | 198 +++++++++++++++++++++++++-
>  include/uapi/linux/vduse.h            |  50 +++++++
>  3 files changed, 276 insertions(+), 1 deletion(-)
>
> --
> 2.34.3
>
Cindy Lu Nov. 25, 2023, 3:55 p.m. UTC | #2 
On Wed, Nov 22, 2023 at 2:11 PM Jason Wang <jasowang@redhat.com> wrote:
>
> On Tue, Nov 21, 2023 at 3:30 PM Cindy Lu <lulu@redhat.com> wrote:
> >
> > Here is the reconnect support in vduse,
> >
> > kernel will allocted pages for reconnection
> > userspace need use ioctl VDUSE_GET_RECONNECT_INFO to
> > get the mmap related information and then mapping these pages
> > to userspace.
> > kernel and userspace will use these pages to sync
> > the reconnect information
> > kernel will use VDUSE_VQ_GET_INFO to sync the information
> > userspace App  will call during the "user_app_dev_start()".
>
> It would be better to describe the uAPI instead of duplicating the
> logic of the codes.
>
sure will rewrite this part
> >
> > change in V2
> > 1. Address the comments from v1
>
> It's better to be more verbose here, people can easily forget the
> comments since V1.
>
will fix this problem

> Thanks
>
> > 2. Add the document for reconnect process
> >
> > Cindy Lu (5):
> >   vduse: Add function to get/free the pages for reconnection
> >   vduse: Add file operation for mmap
> >   vduse: Add new ioctl VDUSE_GET_RECONNECT_INFO
> >   vduse: update the vq_info in ioctl
> >   Documentation: Add reconnect process for VDUSE
> >
> >  Documentation/userspace-api/vduse.rst |  29 ++++
> >  drivers/vdpa/vdpa_user/vduse_dev.c    | 198 +++++++++++++++++++++++++-
> >  include/uapi/linux/vduse.h            |  50 +++++++
> >  3 files changed, 276 insertions(+), 1 deletion(-)
> >
> > --
> > 2.34.3
> >
>