Message ID | 20231121-josef-generic-163-v1-0-049e37185841@wdc.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp748470vqb; Tue, 21 Nov 2023 08:33:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9sdSpt9Khx7nGVg1EB0sTNjzFalYp3H46OAtr4sKc4l32yAclSvm6PZdNE/zo1J6Goocg X-Received: by 2002:a9d:6381:0:b0:6d7:e9a2:ad8f with SMTP id w1-20020a9d6381000000b006d7e9a2ad8fmr594295otk.21.1700584389524; Tue, 21 Nov 2023 08:33:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700584389; cv=none; d=google.com; s=arc-20160816; b=c3yON/xR5n35bWdo7yAjZEbArKvi+GcM1u5ryjqBDxYpnkQsjXXHOa9LokKc/z2cP5 T5PEdfzFNvBgoTKezdfBHx/CQjTXpbKsTwX+hOpnwOgs8QeXZbn6DnAcYUHrJW/t0LOd e3LmhuVkfml6Vcb4l2eJH43FkcTKAneVqTf0NjlWURKQ/F2xFRO+hZtIjvPIJRlW3kRA kb3bi/9N083yNyq6ghrKaNZa6i4gTKjxHYIo1Mxz5bXe3qmCEzx6//b3PT5hrm+xtVUL DBJRyBT+M1EFy1XhBGSmC78JsOOiaPbvRE2epXzpiG3+W/cRo/lzrLOpFyUXNQT1GoYC m2cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:wdcironportexception:ironport-sdr :ironport-sdr:dkim-signature; bh=ZJJGbwZ6qYznYJYOHvBo9D6ISXEGLyjwMT1OLAfF32Y=; fh=5/viNv8Fzx+nCNW5PGLTL+Se/9D0Q8TrzLPV3SudCmU=; b=u6g5Awu7Bt+EMlYPSUfpWvU9gmkk+jWm3QLHKGIjMQ5c7grXveeQWf1v5eBT6CUXTn I0dXOX2O7JqKHlUKl2h6On1mFsPi/wNFAGXpouzhE5jDApV7rSylrM6E4lDaJGZBRK7S ryLEYxVzvCD46NHrzMmvftiUy826YrKLunJogCTBQARWJy/3urRdbw0YBXXmtDZZsXJL 0onI76vxWWVtMI+f8YT/lpBJC2iC+oosnJllenQZCUWvAfVASNgsydOkhQufXt19q0DR hRV9L1ROa2hTxbYho/DduegVHBFxa4iiGlUDCP5AONFS/wEzKVJuKL+zuyJoRD5wz/dL x+uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=ojamMJT2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wdc.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y16-20020a634b10000000b005be14925624si10352742pga.714.2023.11.21.08.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 08:33:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=ojamMJT2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wdc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AF9D1804BDD4; Tue, 21 Nov 2023 08:32:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231631AbjKUQco (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Tue, 21 Nov 2023 11:32:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjKUQcm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Nov 2023 11:32:42 -0500 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6B2197; Tue, 21 Nov 2023 08:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1700584358; x=1732120358; h=from:subject:date:message-id:mime-version: content-transfer-encoding:to:cc; bh=a0hiW0ugZ3WPuFUH975iQYWx7zRQJgHR8z77ikQEbyE=; b=ojamMJT2u6v3rA0/92PTjhqD/kp12S+z9gu2sSVs/lDf/k7h86njj5hr Dw+wTMGfHZ0Z6jDal7D9sHxcb4tmPAIllPwHRE9qjZiZiA2m7+aQMrmgw RlOv8ukkJSyB3bdTxNmoN0hF70wFpwl+YmwqQbPcW2T/EbJiApw8KReZe nA/tPkg1DHVkmzJCPvpCcdvLDh/86L5FR3N0Mz6zZHDQ7Rh31FJnYXWDr i/42+KZoW7myFoQlCkSDHWBAy0QraETRpgcrgSEc6x+yU9vtiZJvmHTjy nR7aEM3tT66A71qDImWxXtWa3LePEvoTBSSHnCaXBDtE7ngP3IyquDxYT Q==; X-CSE-ConnectionGUID: vo7YZa9KRpuG7MJM9qH6Gw== X-CSE-MsgGUID: 0bZVuSChRxSruo+u2KkS3g== X-IronPort-AV: E=Sophos;i="6.04,216,1695657600"; d="scan'208";a="3076032" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 22 Nov 2023 00:32:35 +0800 IronPort-SDR: ihIXLt1ZSRxOPc4fPfNU/Ps569USj2QLcwiEve60FLuWXmA+ENIeaIiu9q4sXwf14bVPO9P5Ur IwuhJI+CYHjiGx1BKEa+JmNYGTWPsTvzq5qOKfG0zfkAPeaA+OKp98dkMGeWx82RJRQ40bX0QH jIWfH82/IjzSLQitiqxbxrEeuXb9fHZBCzgQs+Q+Ms96oTe50TqpxBZSnr1euthdFMUvUis1B/ Or7W6UHzIP1AVPefSU/xiia5bqDK7UgcCVyQC0bDqejMa2mGhpKY0nMm5sXWDouZYre4FDMtep fm4= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2023 07:38:14 -0800 IronPort-SDR: /h2oYavbxuBGrvAIhs5CjIcL2bCLulOjB9A3zzOQzQFnbvMLQFKpsRPU1UDw4zToEalirEELWh 6+E7niVyQt4YKV5MOjAa5w0XwKaB24gg8d3Th+dPksOpXka1LU/SgI1WBDGdCDffjVtUOZl5jA mD+BmavJQKsrosva49MRbkUQzIyLaQH4H1r5gNsYC3oyBN7ZoTA3A7QBayt3w9FFSVShQgTg8d dJI7l6sygkPvamjmkZjN65H39qGW2bVRmvFSmKD8/PKqRvHgD9S5J4EL3Ee8g4fmYlq3+AWTZy EkE= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 21 Nov 2023 08:32:35 -0800 From: Johannes Thumshirn <johannes.thumshirn@wdc.com> Subject: [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Date: Tue, 21 Nov 2023 08:32:29 -0800 Message-Id: <20231121-josef-generic-163-v1-0-049e37185841@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAJ3bXGUC/x3MTQqAIBBA4avErBvwj6iuEi1MR5sWFgoRSHdPW r7F9yoUykwF5q5CppsLn6mF7Dtwu02RkH1rUEJpKZXA4ywUMFJqzqEcNAbjgyG7KTeN0NyVKfD zP5f1fT/H+dmoYwAAAA== To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com> Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Naohiro Aota <Naohiro.Aota@wdc.com>, Johannes Thumshirn <johannes.thumshirn@wdc.com> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1700584354; l=1650; i=johannes.thumshirn@wdc.com; s=20230613; h=from:subject:message-id; bh=a0hiW0ugZ3WPuFUH975iQYWx7zRQJgHR8z77ikQEbyE=; b=nOE9SVbTJpXa0DAaj/6VwVfin9C7x/pPFeEgobBSeM7kam8Odx70p7GS+T8XAL7gGxHumZCAy 6BRRL//62EnAXIjhiUY/ekt0++TEM6q4aaYC6czH/N240Z6Pa8YH9tF X-Developer-Key: i=johannes.thumshirn@wdc.com; a=ed25519; pk=TGmHKs78FdPi+QhrViEvjKIGwReUGCfa+3LEnGoR2KM= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 08:32:44 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783191976895340457 X-GMAIL-MSGID: 1783191976895340457 |
Series |
btrfs: zoned: remove extent_buffer redirtying
|
|
Message
Johannes Thumshirn
Nov. 21, 2023, 4:32 p.m. UTC
Since the beginning of zoned mode, I've promised Josef to get rid of the extent_buffer redirtying, but never actually got around to doing so. Then 2 weeks ago our CI has hit an ASSERT() in this area and I started to look into it again. After some discussion with Christoph we came to the conclusion to finally take the time and get rid of the extent_buffer redirtying once and for all. Patch one renames EXTENT_BUFFER_NO_CHECK into EXTENT_BUFFER_CANCELLED, because this fits the new model somewhat better. Number two sets the cancel bit instead of clearing the dirty bit from a zoned extent_buffer. Number three removes the last remaining bits of btrfs_redirty_list_add(). The last two patches in this series are just trivial cleanups I came across while looking at the code. --- Johannes Thumshirn (5): btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED btrfs: zoned: don't clear dirty flag of extent buffer btrfs: remove now unneeded btrfs_redirty_list_add btrfs: use memset_page instead of opencoding it btrfs: reflow btrfs_free_tree_block fs/btrfs/disk-io.c | 4 +- fs/btrfs/extent-tree.c | 102 ++++++++++++++++++++++++------------------------- fs/btrfs/extent_io.c | 9 +++-- fs/btrfs/extent_io.h | 3 +- fs/btrfs/tree-log.c | 1 - fs/btrfs/zoned.c | 16 -------- fs/btrfs/zoned.h | 5 --- 7 files changed, 60 insertions(+), 80 deletions(-) --- base-commit: 592afe8e8b7ceee58107757fd29ff3290e6539e3 change-id: 20231120-josef-generic-163-f4df4eab2c98 Best regards,
Comments
On Tue, Nov 21, 2023 at 08:32:29AM -0800, Johannes Thumshirn wrote: > Since the beginning of zoned mode, I've promised Josef to get rid of the > extent_buffer redirtying, but never actually got around to doing so. > > Then 2 weeks ago our CI has hit an ASSERT() in this area and I started to look > into it again. After some discussion with Christoph we came to the conclusion > to finally take the time and get rid of the extent_buffer redirtying once and > for all. > > Patch one renames EXTENT_BUFFER_NO_CHECK into EXTENT_BUFFER_CANCELLED, because > this fits the new model somewhat better. > > Number two sets the cancel bit instead of clearing the dirty bit from a zoned > extent_buffer. > > Number three removes the last remaining bits of btrfs_redirty_list_add(). > > The last two patches in this series are just trivial cleanups I came across > while looking at the code. > Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef