From patchwork Mon Nov 20 23:51:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 16832 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp293452vqb; Mon, 20 Nov 2023 15:52:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3OYY8aePnXa2fpskzfBMNDC6Oig7sqUGxKYXpkeqtQIXGI37ADT2haQh3xF6ZlVyDMx/m X-Received: by 2002:a05:6359:697:b0:16d:e745:7284 with SMTP id ei23-20020a056359069700b0016de7457284mr1438420rwb.24.1700524371527; Mon, 20 Nov 2023 15:52:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700524371; cv=none; d=google.com; s=arc-20160816; b=0yWSJefZeBc/PHfqwNjvefKBuxTJ6mlr1z2/nhOYw9GaZQOg59Z0E5bxiFu//4l9YP W8qOCJvUMpR97PG38yI/e+TH1wgneEyqCw7H1e1XPaD3MkgA03VH1CxodMsKleuoQGLY 5UFd66b8vhXQbGRyXkg6XrI4Cs9ghOrwDB6vEBCMXioVO2aat28pBFk8Ru/e0ZPl0pOg QS8nuW6DysW9Id3BsEzyI926ElFeUHB+5SmQdNBCC+giJ2ybJ17c6RaaoD/aOyfK+nVY js5HeAIZTK04y07TW+06fmv0G9ZWIHY/yJta98zUzHF8tIKQHPi2fnie3LpkL+Z11yv2 5f7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=gyLv+XQZstPG1k8z7uQ36q2SBRp0+TVRXuGAO93oB38=; fh=YYLYUNl9fi7Qz/ewHIchNEmCcZiQFtZ0DRgTn9EckYA=; b=S/jjly4kY85EJmZUwNJmLIfh2fN1Sr6AvdE8r+vVfkXCLh4+jEqHPnwf3ILNNoOfzk t0YfUkjXgCLfC/EVzV7DeN6AdtR6A8wDKdJF2BKeJ4Q10GCQNhdvzeDAAJUZBZkGZzvZ pdYibDA9YZJKnyBD/VJ+DGgQMXxtmfLp5gucp6jjVgE+EsTMxbYme3UOII6ad1qZ0eze /y7sPzNS11wMJSDvANZwxRo9pQOdulx7BZ4OwkB8GCYBDt//3juOF43yWfe2rhmnqaBh Ei7b4ucHy6wrxwPsFcCNhEJtQPgILIWn6k/TGdG8OoaRSf3q5lm2hoesnIV1eapO593U JdnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id j7-20020a63e747000000b005aa6c0aa22dsi9162484pgk.724.2023.11.20.15.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 15:52:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 83A93805F40B; Mon, 20 Nov 2023 15:52:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbjKTXvo (ORCPT + 27 others); Mon, 20 Nov 2023 18:51:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232552AbjKTXvm (ORCPT ); Mon, 20 Nov 2023 18:51:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35032BE for ; Mon, 20 Nov 2023 15:51:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA214C433C7; Mon, 20 Nov 2023 23:51:38 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97-RC3) (envelope-from ) id 1r5E3W-00000002PmX-11ek; Mon, 20 Nov 2023 18:51:54 -0500 Message-ID: <20231120235105.834774147@goodmis.org> User-Agent: quilt/0.67 Date: Mon, 20 Nov 2023 18:51:05 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton Subject: [PATCH 0/2] eventfs: Fixes for v6.7-rc2 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 15:52:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783126822178264816 X-GMAIL-MSGID: 1783129043542424224 [ Resend to trigger my patchwork updates, and Cc linux-trace-kernel ] A couple of fixes to eventfs: - With the usage of simple_recursive_remove() recommended by Al Viro, the code should not be calling "d_invalidate()" itself. Doing so is causing crashes. The code was calling d_invalidate() on the race of trying to look up a file while the parent was being deleted. This was detected, and the added dentry was having d_invalidate() called on it, but the deletion of the directory was also calling d_invalidate() on that same dentry. - A fix to not free the eventfs_inode (ei) until the last dput() was called on its ei->dentry made the ei->dentry exist even after it was marked for free by setting the ei->is_freed. But code elsewhere still was checking if ei->dentry was NULL if ei->is_freed is set and would trigger WARN_ON if that was the case. That's no longer true and there should not be any warnings when it is true. Steven Rostedt (Google) (2): eventfs: Remove expectation that ei->is_freed means ei->dentry == NULL eventfs: Do not invalidate dentry in create_file/dir_dentry() ---- fs/tracefs/event_inode.c | 41 ++++++++++++++++++----------------------- 1 file changed, 18 insertions(+), 23 deletions(-)