From patchwork Mon Nov 20 23:15:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 16830 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp278368vqb; Mon, 20 Nov 2023 15:17:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFFz8d5XzCwOXzJ/bXoE2qLB4+pw+cwdO2ygt7LqNPbaPZlqikl1llbsc0Pnv3jz1hwRZd X-Received: by 2002:a05:6a21:1692:b0:188:2770:4076 with SMTP id np18-20020a056a21169200b0018827704076mr7504427pzb.7.1700522253015; Mon, 20 Nov 2023 15:17:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700522253; cv=none; d=google.com; s=arc-20160816; b=yLlEzIwA304JLcdy5kpN5IGnvhXyquOqVHhn+cPL8nkV8Gk4XbTkTQeQwmdSogyhWX VqlWTkHQrEF230Onlalbb7uL6TbuHJCVYOMoelfj3rZ2CwPDDYR25Mn1LzV/aA+xluNk agHaIKZd5kA8i6ngerOmcRU76T4T01pP/IyajzDTipmCpqEwEKXT4VBl8bcGT+4g70DI WQPxaAM9+4xB8kz8AuafQ9IPcOIG1FoD5+Fd87m0wLln/Cb1v5hQFBd1wOXgjOuwclRL UkY8NsjDukKAaPRfV19/ZvdTifLGrx1KKDgzqU+BWlq4sqhusPOG9mZ+3Nn7XSYZ10EV ho1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=sooJNrdRvTR1KRYH5EMrXFUBQYp0NZLZG3tI3qz7q9k=; fh=cY9HGbp9RiQ9xCYqjybSe1/cIiXVFs0Cn9z6ge1iyyY=; b=DKqU11v468yJjZ8P6k+t+mgi0jg34CuDRkGhJsV16H2KqJdzpYNogQ6r1TZ1f5Rlie M4WdMYFl+mouFcYRl6rUVMycigQltgLuzjOLmdY6f/EDKTXN9QnoLXR3mu/L5GiQcG+A JwCZqIDd1pM0ai2rnGZryQeFMdiWQwyAJVRq0uQFsJf2Y1QVW9VU7xDVcb23Vdpps7l0 uxFuh6pCWamKhHDThqycuh8TP53p3hScjZMjDlsctbU3RXdWpdomN2tTlIqdDbpUNh+I +cwyIkmsHzO9Oyl6e0wiCZJn+Cbt/0+w5dRTlyGaqWUhhlfcbDBxXLiMpq//t0XNxMZR UjEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id ls10-20020a17090b350a00b002810ae70420si11621560pjb.121.2023.11.20.15.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 15:17:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 715758097281; Mon, 20 Nov 2023 15:17:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbjKTXQV (ORCPT + 27 others); Mon, 20 Nov 2023 18:16:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjKTXQU (ORCPT ); Mon, 20 Nov 2023 18:16:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA0D0BC for ; Mon, 20 Nov 2023 15:16:15 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9920BC433CA; Mon, 20 Nov 2023 23:16:15 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97-RC3) (envelope-from ) id 1r5DVG-00000002Ob6-2QhA; Mon, 20 Nov 2023 18:16:30 -0500 Message-ID: <20231120231553.374392736@goodmis.org> User-Agent: quilt/0.67 Date: Mon, 20 Nov 2023 18:15:53 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton Subject: [for-linus][PATCH 0/2] eventfs: Fixes for v6.7-rc2 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 15:17:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783126822178264816 X-GMAIL-MSGID: 1783126822178264816 A couple of fixes to eventfs: - With the usage of simple_recursive_remove() recommended by Al Viro, the code should not be calling "d_invalidate()" itself. Doing so is causing crashes. The code was calling d_invalidate() on the race of trying to look up a file while the parent was being deleted. This was detected, and the added dentry was having d_invalidate() called on it, but the deletion of the directory was also calling d_invalidate() on that same dentry. - A fix to not free the eventfs_inode (ei) until the last dput() was called on its ei->dentry made the ei->dentry exist even after it was marked for free by setting the ei->is_freed. But code elsewhere still was checking if ei->dentry was NULL if ei->is_freed is set and would trigger WARN_ON if that was the case. That's no longer true and there should not be any warnings when it is true. Steven Rostedt (Google) (2): eventfs: Remove expectation that ei->is_freed means ei->dentry == NULL eventfs: Do not invalidate dentry in create_file/dir_dentry() ---- fs/tracefs/event_inode.c | 41 ++++++++++++++++++----------------------- 1 file changed, 18 insertions(+), 23 deletions(-)