From patchwork Mon Nov 20 15:11:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 16810 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d903:0:b0:430:37f2:e94a with SMTP id dt3csp2334608vqb; Mon, 20 Nov 2023 07:15:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4qZBZ6dE0sMI/VzdYQUEMBxdn69AlRu6D0QWmx3vxyWzxREh5LkU/QVZtc32Vg4TqrIW+ X-Received: by 2002:a17:902:7043:b0:1cc:b71:c96f with SMTP id h3-20020a170902704300b001cc0b71c96fmr4181152plt.41.1700493340247; Mon, 20 Nov 2023 07:15:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700493340; cv=none; d=google.com; s=arc-20160816; b=Zj0s+xPD6tJWu7zrHVqj5vX6S1/IAbQDHfd4IrfdCuCaoTYp3IbseiNTJojYJzWyZC V9jLhI8/AZZbWc5FhWXR3pHAaEbS0V5SdlWKZ9TCiHWrE9VOuJloSHaCl4MbjMPYVU9q DUt9dcN+PrNEHBXhhyIMqQwwduUsxVV4OXrDI7ho+59vZonzd3VuVEeGAqpoSZ5lllFg dfemluMtGpuXyrEg8ci3kzvfXa1tH1ucN2dU5rij1kAALndEsJE0Sxmfgkwud6SaI1QF HIWoXtupEboue6B+XSVkuhorczQMarO6SMTqUgBQurd9a1VJmURpamumSbO3zRcfvWkN Ywfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+xR2z2p4VIMuj4DrcXTtDSIQJ0Y7W6x/8RUiPwY5Zog=; fh=3VDKuUpnZHU/E7Q667FFh57Tg9oMevOil/UrLftGKk8=; b=pzWCUTiQhI+VClFk1Juh5kYokRHEQDagihGufkkaVJ4AvIyAqrHKzI0xWnK5VdWBw6 lpm2dnHZd79HsXUf0MRZ4dU+jvhmgXCCu4z6Apb9EMgmkbjYR5FcW+gGpKJWbetjRvY+ n3oqhdNmbSitTWU6gMohsaKbYcukmmtxn+qhT0HVLzOR9zSEcJcYCJwuXL+m97feTKfX uLZaLlcV0nFED5uX0aLLHaFcgldjjsWlEVrjy6Cb6vRxnS8MyXHfHZx9jofjQbTmQvKz TJzjL7bznVwQftFwXsixgaiqOv6uq3Vw6N86xxLD/dmAdlneQxqYPahjX5ABpwU/wcu6 ei2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jYZWFJLf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id m13-20020a170902db0d00b001cf64c06394si1312299plx.556.2023.11.20.07.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 07:15:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jYZWFJLf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 480628051AB8; Mon, 20 Nov 2023 07:15:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234271AbjKTPOa (ORCPT + 27 others); Mon, 20 Nov 2023 10:14:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbjKTPO2 (ORCPT ); Mon, 20 Nov 2023 10:14:28 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F28ACF; Mon, 20 Nov 2023 07:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700493265; x=1732029265; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RfU41fixaYxiF352iqz3sfz5IGykKH9mO563in4FsAg=; b=jYZWFJLfqfPe8m1aXMH6IkYGsx7aMEdVt7aJ9W0Ow+4gO7uFZAwCMgMZ JoWt+4oi7/cbEEI/ENU1P+5aB6Dlet8Jz+zSMFG6PwSmOt/B3eT1dN0i7 E3hu0UkjGQicrO74kTh5564EkoMPcXF6TBY8I3t2Z5fuj4okmxgwP3kdj +p7BaFyitSkNUwPE9kZf8Tlf8S+/uShXhdDXCUhA89GHJJWarb3I7j8Ar i0NZMaY7MeJFVGui0o1yZOcBkWCnBNgPWTuXNga6DqLaK+lhh7lNnyG9t L551jB7fGG5p1/GDTD9XtSWyS9R7erTRGtOdGYV8fACmYy7RsG9IlKMf8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="422730959" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="422730959" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 07:14:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="1097766555" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="1097766555" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 20 Nov 2023 07:14:22 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 374E06B; Mon, 20 Nov 2023 17:14:21 +0200 (EET) From: Andy Shevchenko To: Luis Chamberlain , Kees Cook , Andy Shevchenko , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Subject: [PATCH v3 0/5] params: harden string ops and allocatio ops Date: Mon, 20 Nov 2023 17:11:41 +0200 Message-ID: <20231120151419.1661807-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 07:15:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783096505153494182 X-GMAIL-MSGID: 1783096505153494182 A couple of patches are for get the string ops, used in the module, slightly harden. On top a few cleanups. Since the main part is rather hardening, I think the Kees' tree is the best fit for the series. It also possible to route via Greg's sysfs (driver core?), but I'm open for another option(s). Changelog v3: - added tags (Kees, Luis) Changelog v2: - dropped the s*printf() --> sysfs_emit() conversion as it revealed an issue, i.e. reuse getters with non-page-aligned pointer, which would be addressed separately - added cover letter and clarified the possible route for the series (Luis) Andy Shevchenko (5): params: Introduce the param_unknown_fn type params: Do not go over the limit when getting the string length params: Use size_add() for kmalloc() params: Sort headers params: Fix multi-line comment style include/linux/moduleparam.h | 6 ++-- kernel/params.c | 56 ++++++++++++++++++++----------------- 2 files changed, 33 insertions(+), 29 deletions(-)